south-paw/action-netlify-deploy

🙌 Netlify deployments via GitHub actions

action-netlify-deploy's Issues

Support GitHub enviroments

It would be nice to add support for GitHub repo environment deployments

`deploy` has been removed from `netlify/[email protected]`

Looks like the Netlify team have removed deploy from the netlify/js-client package and put it into their netlify/cli which doesn't appear at a glance to be usable programically.

• Can netlify/cli be imported and its internal deploy method called in the action?
  • Probably will blow the size of the action out way bigger than it needs to be
• Should the deploy functionality be re-implemented into this action?
  • Would be a pain to keep in sync with other packages
• Should a new package be created that re-implements the deploy function via wrapping the netlify/js-client somehow

Hebilicious improvements

@Hebilicious, you don't have issues open on your repo, but seems like you made some great improvements to the action (awesome job!)

Feel free to propose a PR back here to merge them into this repo 👍

Drafts are Failing

I'm using this script given in the Readme. My production build works fine but the draft releases don't seem to work. It fails on the deployment step.

Here is my workflow script if you need to glance over.

On pull requests, the Deploy draft to Netlify step is failing. After I merge those failed PRs (forcefully), it works on production. The secrets NETLIFY_AUTH_TOKEN and NETLIFY_SITE_ID are already present, because of which the production build isn't failing. But what's going on with the draft releases? It says it can't find the auth token. It would be awesome if you could help me out here.

Action does not behave as expected for releases

Created a new release on another repo and the action didn't put the correct message on Netlify.

I suspect that the isRelease flag isn't checking for the right thing in the payload.

Replacement action: South-Paw/action-netlify-cli

Finally got around to making a replacement action for this one: South-Paw/action-netlify-cli

• 🏎 It's super speedy (~30 second deployments)
• Utilizes netlify-cli under the hood (so #21 isn't an issue)
• Works with GitHub deployment environments 🎉
• Can be combined with other actions such as commit-comment or comment-pull-request to achieve same functionality as this action
• Quick and easy to migrate 👍

My intention is to archive this action in the near future. Please raise issues on the new project if you need a hand 😃

Minimize outdated deploy comments on new build

Description

When the Github action is going to comment on a new PR, it would be nice to see it check if there are any other deploy comments for the same Netlify Site ID and if they are older than the current one the action should minimize those comments and mark them as outdated.

Notes:

• This might require adding some hidden metadata to each comment (using HTML comment tags? <!-- -->) such as the time of build and the Netlify Site ID so that the action can compare comments easily.
• Could probably simply use the comments time to see if it's older 😄
• I don't think this applies to commits, only PRs
• Github v4 API has minimizeComment