squidfunk/terraform-aws-api-gateway-enable-cors

Easily add an OPTIONS method to an API Gateway resource to enable CORS

terraform-aws-api-gateway-enable-cors's Issues

Error in versions > v0.12 Terraform

On using the terraform-aws-api-gateway-enable-cors module and running terraform plan
Error
│ on .terraform/modules/cors/headers.tf line 27, in locals:
│ 27: headers = map(
│ 28: "Access-Control-Allow-Headers", "'${join(",", var.allow_headers)}'",
│ 29: "Access-Control-Allow-Methods", "'${join(",", var.allow_methods)}'",
│ 30: "Access-Control-Allow-Origin", "'${var.allow_origin}'",
│ 31: "Access-Control-Max-Age", "'${var.allow_max_age}'",
│ 32: "Access-Control-Allow-Credentials", var.allow_credentials ? "'true'" : ""
│ 33: )
│ ├────────────────
│ │ var.allow_credentials will be known only after apply
│ │ var.allow_headers is a list of string, known only after apply
│ │ var.allow_max_age is a string, known only after apply
│ │ var.allow_methods is a list of string, known only after apply
│ │ var.allow_origin is a string, known only after apply
│
│ Call to function "map" failed: the "map" function was deprecated in Terraform v0.12 and is no longer available; use tomap({ ... }) syntax to write a
│ literal map.

just wanted to say thank you!

hey man,

you solved me a problem with a 10' internet search and 6 lines of code. It works like a charm and just wanted to say thank you for releasing this module. keep up with the good work!

❤️

Deprecation warnings after upgrading to Terraform 0.12

After upgrading Terraform to 0.12 there appears to be multiple deprecation warnings coming from this library:

Warning: Interpolation-only expressions are deprecated
Warning: Quoted references are deprecated
Warning: Quoted type constraints are deprecated

Are there any plans to address these?

Update: I see there is an open PR for this already:

https://github.com/squidfunk/terraform-aws-api-gateway-enable-cors/pull/6/files

Thanks

Enabled CORS for nested resources

When I use the module to enable CORS on both a resource and its parent, I get the following error:

Error creating API Gateway Deployment: BadRequestException: No integration defined for method

Failing on Terraform 0.15

Terraform 0.15 removed the deprecated map() function, hence this module is not working. Error log below:

╷
│ Error: Error in function call
│
│   on .terraform/modules/cors_policy_item/headers.tf line 27, in locals:
│   27:   headers = map(
│   28:     "Access-Control-Allow-Headers", "'${join(",", var.allow_headers)}'",
│   29:     "Access-Control-Allow-Methods", "'${join(",", var.allow_methods)}'",
│   30:     "Access-Control-Allow-Origin", "'${var.allow_origin}'",
│   31:     "Access-Control-Max-Age", "'${var.allow_max_age}'",
│   32:     "Access-Control-Allow-Credentials", var.allow_credentials ? "'true'" : ""
│   33:   )
│     ├────────────────
│     │ var.allow_credentials will be known only after apply
│     │ var.allow_headers is a list of string, known only after apply
│     │ var.allow_max_age is a string, known only after apply
│     │ var.allow_methods is a list of string, known only after apply
│     │ var.allow_origin is a string, known only after apply
│
│ Call to function "map" failed: the "map" function was deprecated in Terraform v0.12 and is no longer available; use tomap({ ... }) syntax to write a literal map.

Using Binary Media Types in API Gateway causes OPTIONS requests failing with 500 errors

By using Binary Media Types set to */* in API Gateway cause OPTIONS requests failing with 500 errors. As a solution, the content_handling should be set to CONVERT_TO_TEXT in the aws_api_gateway_integration resource, see:
https://forums.aws.amazon.com/thread.jspa?threadID=256140

Error: Error creating API Gateway Method: NotFoundException: Invalid Resource identifier specified

Hello,

I had this error after the apply
Error: Error creating API Gateway Method: NotFoundException: Invalid Resource identifier specified
do you have any idea ?
Thanks