stankocken/presentation

An architecture for Android as a replacement of MVC.

presentation's Issues

README link broken

https://github.com/EfficientAdapter/ yields 404

OnDestroy on a presenter should unsubscribe from ActivityLifeCycle

If I use this lib on an Activity that switch presenter, (e.g an Activity with drawerLayout) I can't unsubscribe from ActivityLifeCycle.

If I use this code

    private void goToMenu(int id) {
        mActualMenuId = id;
        replaceView();
        replacePresenter(newPresenter());
    }

    private void replacePresenter(BasePresenter presenter) {
        BasePresenter actualPresenter = getPresenter();
        if (actualPresenter != null) {
            actualPresenter.onPause();
            actualPresenter.onStop();
            actualPresenter.onDestroy();
        }
        setPresenter(presenter);
        if (presenter != null) {
            presenter.onCreate(null);
            presenter.onStart();
            presenter.onResume();
        }
    }

    private void replaceView() {
        if (mDrawerLayout.getChildCount() == 2) {
            mDrawerLayout.removeViewAt(0);
        }
        int viewId = getViewId();
        if (viewId != 0) {
            View view = LayoutInflater.from(this).inflate(viewId, mDrawerLayout, false);
            mDrawerLayout.addView(view, 0);
        }
    }

And then start a new Activity, when I close the new activity all presenter already shown will be onResumed. Even if it's not present on the screen and if it's view is remove from layout.

One solution to achieve that is to add a method isDestroyed in com.skocken.presentation.util.ActivityLifeCycleListener and a mDestroyed member in BaseProvider class

com.skocken.presentation.util.ActivityLifecycleCallbackDelegate will become:

    @Override
    public void onActivityResumed(Activity activity) {
        if (!isForMe(activity) || mListener == null) {
            return;
        }
        ActivityLifeCycleListener listener = mListener.get();
        if (listener != null && !listener.isDestroyed()) {
            listener.onResume();
        }
    }

And so on...

Can I merge the activity and the viewProxy?

Its an amazing architecture but it make one class to five, I see the activity do nothing, Can I merge the activity and the viewProxy?

Presenter not calling activity lifecycle methods

In my presenter, I don't receive call on onResume, onPause…

This is due to the getActivity() of BasePresenter which is not working for ContextWrapper context.

The fix is to replace getActivity() from BasePresenter to:

public Activity getActivity() {
    Context context = getContext();
    if (context instanceof ContextWrapper) {
        context = ((ContextWrapper) context).getBaseContext();
    }
    if (context instanceof Activity) {
        return (Activity) context;
    } else {
        return null;
    }
}