stefanct/sglib

SGLIB - A Simple Generic Library for C (originally by Marian Vittek and not maintained by Stefan Tauner at all!)

sglib's Issues

Add an actual LICENSE or COPYING file

I know that you describe this in the header, but putting it there would make it much clearer.

License?

What license is this under?

Macro or an example to insert into a sorted array.

Adding to a sorted array is a pretty common task, though subject to errors.
Would be nice to have it generalized.

bugfix

sglib/sglib.h

Line 554 in 1d17ed7

if ((elem)->previous != NULL) (elem)->previous->next = (elem);\

Hi!
Would like to suggest a change. (bugfix)
After the indicated line above, there should be the line:
(place) = (elem)\

This allows consecutive use of sglib_type_add_before(dllist_first), in the corner case where the dllist_first is NULL to begin with.

Current solution results in keeping the dllist_first pointer value the same as first call and place all new entries behind this first one which is continuously is moving further away from the 'front'.

Hence, new entries are placed at length-2 position!

This change fixed it. I can also push the change for review, if you like.
I am only working with the doubly ended linked list.

Best regards

Query related to license

Hi,

Can this Software be freely used under ANY license? The terms are little ambiguous and I understand similar questions raised earlier.

"...You can also use derivative forms freely under terms of Open Source
Software license or under terms of GNU Public License. ..."

Does this mean this can be used under "Apache, BSD" licenses as well ?

What GPL version?

You specify GPL as a licensing option, but not which version. This is quite germane to its re-use, so a clarification would be appreciated.

Sort order is not clear from the documentation.

I couldn't find a mention - if a comparator(a, b) returns -1, will a or b be the first in a sorted array/list?