thenativeweb/boolean

boolean converts lots of things to boolean.

boolean's Issues

v3.1.3 dependent on node >= 16.7.0

The recent v3.1.3 has a set dependency for node >= 16.7.0. As it's a patch release, this breaks other packages dependent on it without a specified exact version number (in our case, pm2) when using a lower node version.

Suggestion of not using value.trim()

boolean/src/boolean.js

Line 5 in f35f011

return /^(true|t|yes|y|1)$/i.test(value.trim());

Is there a good reason to trim the string ? Could the following regex be used instead ?

return /^\s*(true|t|yes|y|1)\s*$/i.test(value); 

Browser-ready version?

Would be nice!

Firefox throws "SyntaxError: invalid regexp group"

The following regex causes Firefox to throw "SyntaxError: invalid regexp group":

boolean/lib/boolean.ts

Line 3 in bbad0b1

return /^(?<truthy>true|t|yes|y|on|1)$/iu.test(value.trim());

Firefox:

It works fine on Chrome(ium):

2.0.0 and 2.0.1 release is broken!!! please unpublish it asap

the main entry is pointing to "main": "build/lib/boolean.js", however the only available file is "main": "build/src/boolean.js",

ON / on to true

Hi,

Can you add the string "ON" and "on" to convert this to true?
Or is there a reason it shouldn't be?

Thanks!

Feature Request: isBooleanable()

I would love to see a function that tells you if an object/string/whatever is one of the "booleanable" options.

For example isBooleanable() would return True for the values you consider a truth or false: true, false, 'Y', 'N', '1', 0, 'on', 'off', etc...

But when passing something that isn't one of the covered true/false items, it would return False: 'computer', '2022-02-15T11:37:00-08:00', etc...

That would allow you to check if an object is something that should evaluate to a true/false before calling boolean() and potentially getting False as the default result.

Support Node.js version v8

There is really no reason to drop v8 support over a single line of code:

https://github.com/thenativeweb/boolean/blob/master/lib/boolean.ts#L3

It creates compatibility issues such as this:

gajus/roarr#25

v8 is still Maintenance LTS.

"TRUE "

Nice package. However, I was testing this package for my test cases and if failed for "TRUE " or "true ". trim might be required.

Readme is incorrect

This library is much more permissive than the readme claims.

Take this code as an example

var boolean = require('boolean')

console.log(boolean([false]))
console.log(boolean({}))
console.log(boolean(001))
console.log(boolean(100))
console.log(boolean('negative'))
console.log(boolean('hellyo'))
console.log(boolean('noyesno'))
console.log(boolean('321'))

All of these expressions will return true

Any object which is truthy and not a string will return true
Any string that contains a substring of 't', 'y', or 'yes' will return true
Any string that begins with the word 'true' or ends with the number 1 will return true

Lookbehind assertions are not compatible with FF

boolean/lib/boolean.ts

Line 3 in 329dac4

return /^(?<truthy>true|t|yes|y|on|1)$/iu.test(value.trim());

Lookbehind assertions got introduced in early 2018 and browsers like FF still don't support it. In order for this library to be more acceptable to work with all the major browsers, I would recommend to use look ahead assertions at this point in time.

This works on recent versions of Chrome and Safari. I haven't tested on IE.

Ref: https://stackoverflow.com/questions/641407/javascript-negative-lookbehind-equivalent#

SyntaxError using create-react-app and Node v13

Failed to compile.

./node_modules/boolean/build/lib/boolean.js
SyntaxError: /Users/gajus/dev/applaudience/applaudience-explorer-web-app/node_modules/boolean/build/lib/boolean.js: Expected atom at position 2
    ^(?<truthy>t
      ^
^C

Wrong result with primitive object wrappers

While I know it is advised not to use primitive object wrappers, you might still want to look into this:

const truthy = new String('true')
console.log(boolean(truthy)); // => false

A more robust approach would be doing something like this:

switch (Object.prototype.toString.call(value)) {
  case '[object String]':
    return [ 'true', 't', 'yes', 'y', 'on', '1' ].includes(value.trim().toLowerCase());
  case '[object Number]':
    return value.valueOf() === 1;
  case '[object Boolean]':
    return value.valueOf();
  default:
    return false;
}

Changelog missing 1.x and 2.x notes

Recently I've started working on a project that's badly outdated and "boolean" is "^0.2.0" ... I would like to 'just upgrade it' but not sure what the implications are.
Would be good if the changelog had some notes on any breaking changes.

Converting numbers other than “1” to “false”

I suppose it was done for some reason, but this reason is very unclear.

Is it bug or feature?

boolean(1) // true
boolean(2) // false

If its a feature, why is it so?

You can see demo on jsFiddle.