tjheslin1/dmspredictor

Combat results predictor for DMs for Dungeons & Dragons 5th Edition

dmspredictor's Issues

Barbarian and Berserker always uses recklessAttack even if they already have Advantage on their attacks

Needs an update in BaseBarbarianAbilities#recklessAttack and it's tests.

Handle updating spell slots for newly concentrating spells

Whilst all ConditionSpell's require concentration, spells other than ConcentrationConditionSpell also require concentration. This spell type is specifically for apply Conditions.

• Add new tests cases for concentrating in CoreAbilitiesSpec.
• Add every spell type of a given SpellEffect to each CoreAbilitiesSpec test which tests updating of spell slots.
• TODO: castSelfBuffSpell and castMultiTargetBuffSpell, referncing each other.
• Update spellcasting abilities in CoreAbilities to set newlyConcentrating correctly:
• It should be safe to set this to true for a type of spell with a mixture of concentration and non-concentration spells as it only enables checking for concentration.
• Rename SpellEffect cases to added "Effect" as a suffix.
• Rename ConcentrationConditionSpell to ConditionSpell.
• castConditionSpell and castMultiTargetBuffSpell should follow the same pattern as castSelfBuffSpell in terms of updating spell slots.
• Remaining TODOs

BaseBarbarian's resetStartOfTurn always resets its creatures attack and defense status

BaseBarbarian.scala

Intended to reset after using BaseBarbarianAbilities#recklessAttack but should check if RecklessAttack was used last turn.

A new field in Barbarian and Berserker might need adding.

Replace Spell#schoolAttribute with a spellcasting attribute in SpellCaster

schoolAttribute needs to be updated whenever a new SpellCaster is defined. Instead adding a field on trait SpellCaster will enforce this is implemented at a type level.

Should remove condition from whoever was targeted by adding identifier to Condition

See TODO in Actions.scala.

Possible edge case where a Condition could be removed from the wrong target.

weaponModifier doesn't cater for Ranged weapons

Actions#weaponModifier should be:

  private def weaponModifier(weapon: Weapon, creature: Creature): Int = weapon.weaponType match {
    case Melee if weapon.finesse =>
      Math.max(mod(creature.stats.strength), mod(creature.stats.dexterity))
    case Melee  => mod(creature.stats.strength)
    case Ranged => mod(creature.stats.dexterity)
  }

  "resolveDamage" should {
  ...
  ...
    "add a players dexterity modifier for a Ranged weapon" in {

Bonus Action is always made after the creatures main action

A good example of this is a Ranger using the Hunters Mark spell. Currently it will cast this at the end of its first turn. It would benefit from casting it (as a bonus action) at the beginning of its first turn.

This will involve updating Move#takeMove.

The intended implementation is for the Creature to look for a suitable bonus action to use at the start of its turn. A new boolean value stored in all bonus action abilities (e.g. useBeforeAction: Boolean) would be checked to determine at what point this ability is used.

It is not intended for a Creature to suddenly use more bonus action abilities when it might be better for it to continue to utilise twoWeaponFighting.

New tests in MoveSpec should be sufficient as the behaviour of the abilities themselves will remain unaffected.

Add a toHitModifier to Monster

Monsters should have a to hit modifier added to their attack rolls. Akin to a Players proficiency bonus.

E.g Goblin has a Dexterity score of 14 (+2). It's bonus to hit on its attacks is +4, suggesting a bonus of plus 2.

This will function in the same way as proficiency bonus and should set Spellcasting Monster's spellCastingModifier.

Monster weapon attack rolls dont include ability modifier

Barbarian's rage never ends

Currently the Barbarian's number of turns left during it's rage is not decremented.

When this reaches 0 or when the Barbarian has started its turn without being damaged or having attacked, it should lose it's rage. For this a new flag, something like: rageSatisfied: Boolean will need to be added.

Creatures are not immune to Vampires Charm effect after passing saving throw

Need to implement a CharmImmune condition.

Guiding Bolt should give advantage on next attack

Conditions should apply effects immediately

• Paralyzed and Stunned has DefenseStatus updated when condition is applied
• SavingThrow handles Paralyzed liked it does Stunned
• Poisoned sets AttackStatus to Disadvantage

ProficiencyBonus should be calculated based on Player level

Abilities which replace creatures into turn order may disrupt the order during a turn.

Using ListOps#replace may affect the turn order.

E.g the result of Actions#resolveDamage returns the updatedTarget and updatedOthers separately. Joining them together doesn't respect the turn order, which is determined by Combatant.index.

Once a turn has finished the queue of Combatants is re ordered according to the initiative scores. This may be too late and could result in a Combatant losing their turn or gaining an extra turn.

vendor.yml doesn't ignore sbt file

vendor.yml was added with the intention of ignoring the sbt script used during Travis CI builds. I haven't got this working but would like to remove the Shell % in the language breakdown of the project.

This uses the https://github.com/github/linguist project.

Consolidate tracked MultiTargetSavingThrowSpell implementations from Tracking

Tracking#trackedMultiMeleeSpellAttack and Tracking#trackedMultiTargetSavingThrowSpell appear to be duplicates.

trackedMultiMeleeSpellAttack was likely for a separate multi target attack (not saving throw) spell which has never been added.

• Consolidate
• Remove any duplicate CoreAbilitiesSpec tests

Add isSingleTargetSpell and isMultiTargetSpell to Spell.

To replace Spell#singleTargetSpellOnly and Spell#multiTargetSpellOnly matches will have to be updated and maybe become inexhaustive.

Implementation of Focus for players to fight a preferred enemy.

Currently the implementations of Focus are: LowestFirst and RandomFocus.

A Cleric, for example, would favour focusing Undead enemies, being able to use their Turn Undead ability. Furthermore if the Undead has been Turned they could move onto another enemy.

In Move.scala the method:
def nextToFocus(combatantsToAttack: Queue[Combatant], focus: Focus): Option[Combatant]
would match on the new type and perform this logic.

This can be tested in isolation in MoveSpec.scala

Saving throws with advantage / disadvantage using Legendary Resistance multiple times

Add Exhausted condition for Path of the Berserker

Path of the Berserker Barbarian's currently doesn't gain exhaustion when Frenzy ends.

This involves adding a new Condition: Exhuasted, which has number of levels. As a first iteration only one level of exhaustion could be added.

This should apply when the Berserker's rage ends: either rageTurns reaches 0 or it has not attacked/been damaged for a turn.

Depends on #23

Monster abilities implement levelRequirement

Abilities must implement a levelRequirement, however monster specific abilities such as mutliAttack have no use for the levelRequirement field as Monster has no concept of Level, instead implementing a challenge rating.

There is unlikely to be any ability used by both Players and Monsters. Likely a separate implementation is more appropriate (e.g Extra Attack / Multi Attack).

One possibility is to drop levelRequirement from Ability. This is undeseriable as it's main usage is to remind the developer to implement this and consider it.

Another option is to have a Level to represent Monsters (e.g LevelZero), however this will cause issues when pattern matching over levels (see Cleric#clericSpellSlots) where this would not make sense.