tokjun/curvemaker

Simple 3D Slicer module to generate a spline curve from a list of fiducials

CurveMaker

3D Slicer scripted module to generage a curve from a list of fiducials.

curvemaker's Issues

Curve less than 1 mm diameter

Currently, the extension does not allow the users to set the curve diameter < 1 mm.

Curve Maker not Installing! Please Help!

After installing Curve Maker from the extension tab and restarting slicer, Curve Maker does not appear in the informatics tab.

I get the following critical errors upon starting 3d slicer:

Stream Error:
File "", line 1
import imp;imp.load_source('CurveMaker', 'C:/Users/Mitchell O'Leary/AppData/Roaming/NA-MIC/Extensions-26813/CurveMaker/lib/Slicer-4.8/qt-scripted-modules/CurveMaker.py');del imp;
^
SyntaxError: invalid syntax

Qt Error:
loadSourceAsModule - Failed to load file "C:/Users/Mitchell O'Leary/AppData/Roaming/NA-MIC/Extensions-26813/CurveMaker/lib/Slicer-4.8/qt-scripted-modules/CurveMaker.py" as module "CurveMaker" !
Fail to instantiate module "CurveMaker"

Cannot set radius to less than 1mm

I'd need very thin models, it would be great to set the radius starting at a very small value. Thanks!

Support closed ring

Currently the CurveMaker module only generate a curve starting at the first point and ending at the last point. It would be great if it can also generate a closed ring curve, where the first and the last points are also connected with a smooth curve.

displaying the curve in the 3 planes.

What should I do to make the curve appear in the 3 planes as well?

Retire CurveMaker extension for Slicer-5.7 and later?

Since introduction of curves in Markups module and MarkupsToModel extension, the CurveMaker extension became redundant.

Recent rework of the Endoscopy module in Slicer core, the extension has been reported to not work anymore - see Slicer/Slicer#7519

Instead of fixing the extension, I would recommend stopping development and support of the extension for Slicer-5.7 and later.

Curve length measurement

It would be nice to have a feature to calculate the length of a curve.

Enable checkbox confusing

It is hard to find out exactly what the Enable checkbox does. If I turn it off, nothing changes in my model.

It seems like it means "auto-update". If it does, then I think it would make sense to change its name. I'd also add a button to generate the model in case auto-update is off, and the user just wants to make a model from the current settings.

Model does not appear in Windows

I tested today's nightly on Windows. This module seems to be working, but the model is not populated with polydata. So it does not appear. Maybe something is broken since the vtk6 migration?

Auto update not working

What I did: I place a bunch of fiducials (either manually or through sampling during tracking). They are all saved under one 'MarkerFiducial1'. Then I go to Curve Maker module. Select fiducial set as 'MarkerFiducial1' and for mode 'create new'. Then I press 'Generate' button and a curve/spline appears on the screen as expected.
Now if I add more fiducial points and hit 'Generate' button again, the curve updates as expected.

What I expect: I see that there is an 'Auto-generate' checkbox which should update the curve as soon as I place new fiducials.

What actually happened: So I checked 'auto-generate'. then added a fiducial (and then more) but the curve did not update. If I unceck and recheck 'auto-generate' then the curve updates once. Adding more fiducials, the curve again did not update.
If I add fiducials and hit 'generate' then the curve updates once (as expected)

Summary: The auto-update check-box is not working. and essentially acts like a 'generate' button.

P.S. I am using Slicer nightly version 4.11.0 2019-07-23

Constant name changed in vtkMRMLModelDisplayNode

line 516
"UseDataScalarRange" should be used instead of "UseDisplayNodeScalarRange".
The curvature function won't work without this modification, though other functions still work.
See the commit in slicer core for reference:
Slicer/Slicer@9f33785
For 4.8 and version afterward, we should use "UseDataScalarRange".
For earlier version we could still use UseDisplayNodeScalarRange.