tokuhirom/amon

yet another web application framework

amon's Issues

add_config is not needed.

Will it be deprecated?

Generate Job worker integration in Flavor

Jonk?

set warn_handler by default.

http://d.hatena.ne.jp/gfx/20110211/1297410013

$self->{__PACKAGE__}

https://github.com/tokuhirom/Amon/blob/master/lib/Amon2/Plugin/Web/HTTPSession.pm#L19

重箱の隅をつつくような報告で恐縮します。
パッケージ名でなく "__PACKAGE__" というキーが指定されています。

Large flavor does not support dotcloud

add nginx.conf

5.08+ fails on perl-5.19.4: needs HTTP::Session

Seems like new Amon2 needs an explicit dep on HTTP::Session for the CSRF defender test?

t/600_plugins/008_no_cache.t ................... skipped: Test requires module 'HTTP::Session' but it's not found
Can't locate HTTP/Session/Store/OnMemory.pm in @INC (you may need to install the HTTP::Session::Store::OnMemory module) (@INC contains: /home/zakame/.cpanm/work/1382262323.4252/Amon2-5.09/blib/lib /home/zakame/.cpanm/work/1382262323.4252/Amon2-5.09/blib/arch /home/zakame/.cpanm/work/1382262323.4252/Amon2-5.09/_build/lib /home/zakame/.plenv/versions/5.19.4/lib/perl5/site_perl/5.19.4/x86_64-linux /home/zakame/.plenv/versions/5.19.4/lib/perl5/site_perl/5.19.4 /home/zakame/.plenv/versions/5.19.4/lib/perl5/5.19.4/x86_64-linux /home/zakame/.plenv/versions/5.19.4/lib/perl5/5.19.4 .) at t/600_plugins/009_csrf_defender.t line 35.
BEGIN failed--compilation aborted at t/600_plugins/009_csrf_defender.t line 35.
t/600_plugins/009_csrf_defender.t .............. 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 

New generated app from 5.06 still needs Router::Simple

Seems that Amon2::Web::Dispatcher::Lite still calls Router::Simple and not Router::Boom:

[zakame@yorozuya:~/src/TmpSpike] master* ± carton exec perl -Ilib script/tmpspike-server
Can't locate Router/Simple.pm in @INC (@INC contains: script/../lib lib /home/zakame
/src/TmpSpike/local/lib/perl5/x86_64-linux /home/zakame/src/TmpSpike/local
/lib/perl5 /home/zakame/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/x86_64
-linux /home/zakame/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2 /home/zaka
me/perl5/perlbrew/perls/perl-5.14.2/lib/5.14.2/x86_64-linux /home/zakame/perl5/perlb
rew/perls/perl-5.14.2/lib/5.14.2 .) at /home/zakame/src/TmpSpike/local/lib/perl
5/Amon2/Web/Dispatcher/Lite.pm line 5.
BEGIN failed--compilation aborted at /home/zakame/src/TmpSpike/local/lib/perl5/
Amon2/Web/Dispatcher/Lite.pm line 5.
Compilation failed in require at script/../lib/TmpSpike/Web/Dispatcher.pm line 
5.

I know Amon2::Web::Dispatcher::Lite is going to be split off its own dist soon though, so probably its time for the boilerplate in $APP/Web/Dispatcher.pm to be updated? :)

support new flavor system: Amon2::Plugin::Web::FillInForm

.

bootstrap assets should contain all things

Current version of Amon2 contains only three files from bootstrap. There is no reason to strip.

Docs about FormValidator::Lite

FormValidator::Lite docs. or plugin?

Support Router::Boom

Change the message on the premise of using cartons

Banners should say "carton exec perl script/foo-server"

Amon2 4.x should depend/recommend Teng

From a freshly-set up Amon2 install and doing amon2-setup.pl HelloFromKoding:

guest-141158@vm-0:~/work/HelloFromKoding$ plackup -r
Watching ./lib app.psgi for file updates.
Error while loading /home/guest-141158/work/HelloFromKoding/app.psgi: Can't locate Teng/Schema/Declare.pm in @INC (you may need to install the Teng
::Schema::Declare module) (@INC contains: /home/guest-141158/work/HelloFromKoding/lib /home/guest-141158/work/HelloFromKoding/extlib/lib/perl5 /hom
e/guest-141158/.plenv/versions/5.18.1/lib/perl5/site_perl/5.18.1/x86_64-linux /home/guest-141158/.plenv/versions/5.18.1/lib/perl5/site_perl/5.18.1 
/home/guest-141158/.plenv/versions/5.18.1/lib/perl5/5.18.1/x86_64-linux /home/guest-141158/.plenv/versions/5.18.1/lib/perl5/5.18.1 .) at /home/gues
t-141158/work/HelloFromKoding/lib/HelloFromKoding/DB/Schema.pm line 6.
BEGIN failed--compilation aborted at /home/guest-141158/work/HelloFromKoding/lib/HelloFromKoding/DB/Schema.pm line 6.
Compilation failed in require at /home/guest-141158/work/HelloFromKoding/lib/HelloFromKoding.pm line 8.
BEGIN failed--compilation aborted at /home/guest-141158/work/HelloFromKoding/lib/HelloFromKoding.pm line 8.
Compilation failed in require at /home/guest-141158/.plenv/versions/5.18.1/lib/perl5/5.18.1/parent.pm line 20.
BEGIN failed--compilation aborted at /home/guest-141158/work/HelloFromKoding/lib/HelloFromKoding/Web.pm line 5.
Compilation failed in require at /home/guest-141158/work/HelloFromKoding/app.psgi line 9.
BEGIN failed--compilation aborted at /home/guest-141158/work/HelloFromKoding/app.psgi line 9.

I know, the new app's cpanfile itself does depend on Teng, but what I mean is that the Amon2 installation should ought to get Teng installed as well (as expected from a new user's perspective.) Or, at the very least, have some blurb at the end of the amon2-setup run for the Basic flavor about installing Teng before further work on the new app.

remove web_base

Generate loading.gif in Flavor.

I often use it.

Deny DB access from view by default

http://blog.64p.org/entry/2012/11/09/192010

依存モジュールのご連絡 HTTP::Session::Store::OnMemory

009_csrf_defender.t が HTTP::Session::Store::OnMemory 及び String::Random に依存しているのでテストの際、インストールが必要でした。
String::Random は 002_router_simple.t では Test::Requires に指定されていました。

Make Kolon as default.

document flavor architecture

Flavor's architecture and Plugin's flavor architecture.

twitter.bootstrap

Make http://twitter.github.com/bootstrap/ as default CSS framework.

Web::Request->uri_with(): URIエンコードのバグ

uri_with()でURIエンコードがうまくいかないケースがある

原因はよくわかりませんでした

$ amon2-setup.pl MyApp && cd MyApp
$ carton install

### tmpl/index.tt に記述して http://localhost:5000/?q=%E3%81%82 へアクセス(q=あ)
# <a href="[% uri_with() %]">uri_with()</a>: [% uri_with() %]<br>
# <a href="[% uri_with({}) %]">uri_with({})</a>: [% uri_with({}) %]<br>
# <a href="[% uri_with({page => 1}) %]">uri_with({page => 1})</a>: [% uri_with({page => 1}) %]<br>

$ carton exec plackup

# 3つのうち、uri_woth()の出力が違ってるものがある(3つ目のuri_with)

### 開いて何も編集せずに上書き保存
$ vim local/lib/perl5/Amon2/Web/Request.pm

$ carton exec plackup

# なぜか3つの出力が同じになってる！！！

# この後、local/を削除してcarton installし直してもバグは再現しない
# amon2-setup.plからやり直すとバグが再現する

Use jquery 2.0.x by default.

Older IE was mostly gone. Use jQuery 2.x.x by default.
If user want to support older IEs, users can replace jquery by himself.

Rewrite amon.64p.org based on Amon2 5.00

Amon2::DBI cannot handles error case on mysql.

This is a serious issue..

support new flavor system: Amon2::Plugin::Web::MobileAgent

.

add view('TT')->process method

is config read only?

https://github.com/tokuhirom/Amon/blob/master/lib/Amon2/Setup/Flavor/Minimum.pm#L148

ここでconfigに書き込みしてしまっている。

MyApp
MyApp::PC -> MyApp
MyApp::Admin -> MyApp
があるときに(Flavor::Largeで作るとこうなりますね)

MyApp->config;
MyApp::PC->config;
MyApp::Admin->config;
の順に呼ぶと

https://github.com/tokuhirom/Amon/blob/master/lib/Amon2.pm#L46
ここでconfigメソッドが定義されてしまう関係上
その三つの->configが返すのは同じreferenceになってしまうので
最初に提示した
view_conf->{path}
が、MyApp::PCとMyApp::Adminで一緒になってしまう。

で、ここはまあ事前に

$view_conf = +{ %{$view_conf} };

としてあげれば解決するわけですが
もし、Amonのポリシーとしてconfigは読み込み専用としないのであればsub configの実装はまずいのかなと思いました！

という、テストケースもつけないバグ報告ですみません＞＜

Move xslate instance creation to Flavor::Xslate or something...

.

Cache uri object by default.

Plack::Request does not cache the uri object. It hits high traffic web sites.

Windowsでもエラー出ないように

diff --git a/lib/Amon2/Setup/VC/Git.pm b/lib/Amon2/Setup/VC/Git.pm
index 08eb3d1..b1b9284 100644
--- a/lib/Amon2/Setup/VC/Git.pm
+++ b/lib/Amon2/Setup/VC/Git.pm
@@ -18,7 +18,7 @@ sub do_import {

     !system("git init") or die $?;
     !system("git add .") or die $?;
-    !system("git commit -m 'initial import'") or die $?;
+    !system("git commit -m \"initial import\"") or die $?;
 }

 1;

required perl version should be 5.8.1

TMT work with perl5.8.1

support new flavor system: Amon2::Plugin::LogDispatch

.

invalid tag

https://github.com/tokuhirom/Amon/blob/master/lib/Amon2/Setup/Flavor/Basic.pm#L237

make more plaggability for Flavors.

plugin the JS assets, etc.

admin.psgi の typo

admin.psgi の 25行目の adin は admin ではないでしょうか？

        root => File::Spec->catdir(dirname(__FILE__), 'static', 'adin');

amon2 シンプルで勉強になります。

JSON renderer

Amon2::Setup::Flavor::Basicのsetup_schema()がコメントなどに未対応

/* test; */

みたいなSQLに対応できません。まともな対応は難しいと思うので、テーブルのセットアップをフレーバーから外すべきかと。

perl 5.8.8でインストールしようとするとt/200_app/03_tt.tでこける。

Can't locate feature.pm in @inc～というのが出るので確認したら、Test::Requiresにfeatureが書かれてないからみたいです。

amon-setup.pl で作ったプロジェクトのmake testが通らない。

amon-setup.pl でプロジェクトを作成し、
$ perl Makefile.PL
$ make && make test
すると、blib内にtmplフォルダがない。tmpl見つからない。といった内容のエラーが出ます。

#perl-casualで相談してたらtを書き換える、こんな解決法が出ました。
http://gist.github.com/262149

API dispatcher

add a API dispatcher taken from Ukigumo

Make scripts as really CPAN installable.

Current version of standalone script is not installable. Maybe.

rename repository to tokuhirom/Amon2/

amon-setup.plで作成したtestが通らない

test_psgiでAmon::WebのPlack::Request->new($env)の$envがハッシュリファレンスじゃないようでエラーが出ているよう。

make MyApp::Web as context object for web app.

new flavor system for MobileJP

.

i18n support

Create script/foo-server script by default.

@kazeburo suggests to create server runner script instead of creating .psgi file.

I agreed this thing. Then, Amon2 5.00 will not create app.psgi and create script/foo-server instead.

after_dipatch,before_dispath is available in Controller.

Now,after_dipatch,before_dispath is available in MyApp::Web.I wanna add after_dipatch,before_dispath on individual Controllers.Please!

Minilla friendly dist.

Current Amon5's Build.PL is hacked well. It's not minil friendly.
Code move to builder/MyBuilder.pm.

Amon->base_dirが何だかおかしい。

Amon.pmのL28
- $libpath;
+ $libpath || '.';
にしたら正常に動きました。

軽い変更だったので、forkとかはしてません。