tripleslash/rocket

rocket - Fast single header signal/slots library for C++

rocket's Issues

Use clangformat for code style

Programmers may use different IDE/code editors so a .clangformat (or better .clangtidy) can be used to manage code style.

warning: implicit dereference will not access object of type

I compile source in wsl"gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)", compiler warn that

/e/Releases/cmake-librepo/ubn18.04/include/rocket/rocket.hpp: In member function ‘void rocket::detail::connection_baserocket::thread_safe_policy::disconnect()’:
/e/Releases/cmake-librepo/ubn18.04/include/rocket/rocket.hpp:2074:81: warning: implicit dereference will not access object of type ‘volatile rocket::intrusive_ptr<rocket::detail::connection_baserocket::thread_safe_policy >’ in statement
static_cast<intrusive_ptr<connection_base> volatile&>(prev) = nullptr;

[question] Rocket library into Conan dependency manager

Hi, I really like the library and using it in one of my project.
I'm planning to add a package for rocket into the conan C++ dependency manager.
This will ease the process of getting the library for conan users. I will soon(ish) issue the package into the conan repository. Is it ok for you? Is there something I need to know?

Exactly requires c++17 and higher

There is marked with cpp14, but project requires cpp17 at least
scoped_lock, template<auto N, ...>
if constexpr, std::apply do not let downscale requirements
msvc 19 at least c++17
gcc 12 at least c++20 with warning meantioned #8 (comment)
clang 15 at least c++20

example.cpp trackable should use public inheritance

Hello, I'm currently integrating your rocket lib into the signal-slot-benchmarks and encountered an issue with trackable not tracking connections unless public inheritance is used.

https://github.com/tripleslash/rocket/blob/master/example.cpp#L5

Should use public inheritance instead of private or else it will not track slots at runtime.

Possible race condition in call_queue

I misread the code.

rocket::thread_safe_signal::operator() argument by reference issue

Hello, I have integrated your rocket lib into the signal-slot-benchmarks and I'm encountering an msvc compilation issue when attempting to integrate the rocket::thread_safe_signal into the benchmark.

Here is the issue as well as the exact error message and line number that visual studio is reporting.

Note that using rocket::signal in the single thread version of the rocket benchmark compiles and runs fine.

(here are the msvc benchmark results)