Comments (12)
Ok, I have take a look and indeed there was an issue when using custom lyrics directories.
This should be now fixed in the latest DEV version, download and replace your files:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip
Thanks for reporting!
-TT
from georgia-reborn.
Yes, because the original Georgia theme had it for offline usage and that is why you have the "lyricsFilenamePatterns"
.
I have implemented to make it work with Lyric Show 3 user-component, and then switched to the better
ESLyric user-component and hacked it together to make it work with the theme.
Anyways, I'm working on the Georgia-ReBORN website with its documentation atm.
I'll be sure to add the information to the documentation...
-TT
from georgia-reborn.
Hi @kyxap,
if you want to have a different directory and not the default, i.e
foobar2000\profile\cache\lyrics
( %fb2k_profile_path%cache\lyrics
)
you need to set it in the ESLyric directory location:
foobar's Preferences
> Tools
> ESLyric
> Lyric Option
> Save settings
:
Location: Click on the ...
button and select The same folder as the track
( as shown in your screenshot ).
Now the lyrics will be auto saved and read from the album dir.
If you want to use a custom lyrics dir folder, you need to change it in top menu:
Options > Settings > Theme cache > Lyrics > Use custom lyrics directory.
This will activate the custom lyrics dir now defined in your georgia-reborn-custom.jsonc config file:
foobar2000\profile\georgia-reborn\configs\georgia-reborn-custom.jsonc
in the "customLyricsDir"
section.
You also need to set the same dir in the ESLyric directory location.
Additionally if needed, you can change the filename pattern in the ESLyric Save settings
window
and in your georgia-reborn-config.jsonc
config file:
foobar2000\profile\georgia-reborn\configs\georgia-reborn-config.jsonc
in the "lyricsFilenamePatterns"
section.
HTH
-TT
from georgia-reborn.
@TT-ReBORN
hi, yeah I do have such configuration (safe file in local dir) that how I got that file in there.
After enabling auto search on playback seems it started to work more stable but still im getting same issue occasionally.
For example if I do those steps im getting this issue all the time
- open foobar2000
- click play (you must have some audio in playlist with local lyrics)
- go to lyrics
It will start to search and after some time gives:
if I do double click on the same song it opens saved lrc file... but again after some time (>1m) it will shows that no lyric found
Some something is not right, hope this make sense
from georgia-reborn.
thanks for quick fix, now seems to be working with no issue๐
from georgia-reborn.
apparently coping over master reset all my configs so it started to use cache folder which gave me false positive, after making all my changes back this issue is still there...
is there a manual how to debug that js and see what is wrong on my end?
ok it seems like tfilename
has wrong file names and not using that one from UI I will continue looking tomorrow
from georgia-reborn.
apparently coping over master reset all my configs so it started to use cache folder which gave me false positive, after making all my changes back this issue is still there...
You can make a theme backup that saves all your settings, here is how to do that:
- Please make a theme backup via
Options > Settings > Theme backup > Make backup
. - Now make a new portable foobar install and install the latest DEV master version from here:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip - After you have downloaded and installed the theme, copy from your old foobar your theme backup folder:
foobar2000_old\profile\backup
to your new:
foobar2000\profile\backup
- Now restore your theme backup via
Options > Settings > Theme backup > Restore backup
is there a manual how to debug that js and see what is wrong on my end?
To debug, you use the console.log and print the result in the console ( top menu View > Console ).
You should probably take a look at this method here:
Can you please tell me the exact steps to reproduce?
Also can you post your modified lyrics settings and attach the lyric file that is making problems?
The default settings for the lyrics are as follows:
The ESLyric download directory:
%fb2k_profile_path%\cache\lyrics
The ESLyric filename is:
[%artist% - ]%title%
the brackets are optional, i.e when there is artist available, it will use %artist% - %title%
otherwise it will use just %title%
.
The "lyricsFilenamePatterns"
( tfilename
) in your georgia-reborn-config.jsonc
config file has these default patterns:
"%title%",
"%artist% - %title%",
"%artist% -%title%",
"%tracknumber% - %title%",
"%tracknumber% - %artist% - %title%"
from georgia-reborn.
After looking into this I've found that my custom file naming of the lyrics is ignored and there no mechanism to look into saved file format. Here is not the best but potential solution #177
from georgia-reborn.
I have tried your filename pattern and see no issues, it is working as expected.
It does apply and search for the user-set filename pattern from "lyricsFilenamePatterns"
in your
georgia-reborn-config.jsonc config
file and is finding the lyrics:
When deactivating foobar's Preferences
> Tools
> ESLyric
> Lyric Option
> Lyric Search section
> Automatically when playback starts
setting, it will not automatically fetch lyrics from the ESLyric Lyric Sources
( internet ) but then will try to find lyrics from the HDD/Tags ( offline ) using the "lyricsFilenamePatterns"
in your georgia-reborn-config.jsonc
config file.
So when using a custom lyric filename pattern, it should be set both in ESLyric Save settings
and "lyricsFilenamePatterns"
in your georgia-reborn-config.jsonc
config file.
P.S foobar should be restarted when making changes.
-TT
from georgia-reborn.
oh manually set lyricsFilenamePatterns
? yeah that will work, was not excepted such complexity :)
from georgia-reborn.
btw I do have georgia-reborn-config-3.0-DEV.jsonc
and also georgia-reborn-config.jsonc
which one in used ? should I do any cleanup?
from georgia-reborn.
The georgia-reborn-config-3.0-DEV.jsonc
is a backup of the georgia-reborn-config.jsonc
config file.
So the georgia-reborn-config.jsonc
and georgia-reborn-custom.jsonc
are the ones that are being used and read from.
The config backups will be created when the user has updated to a new Georgia-ReBORN version or
when old/invalid config setting names or values were updated.
-TT
from georgia-reborn.
Related Issues (20)
- Foobar Crashes; Sort Songs by "Artist now playing" HOT 2
- album art does not change HOT 5
- How to display "Hi-res" logo? HOT 2
- Audio Format/Quality Line Not Showing with Newest Release HOT 2
- Annoying Security Alerts Certificate pop up HOT 2
- Change format of CD image HOT 2
- Artist flags not showing HOT 14
- Unable to load fonts after restarting the OS HOT 3
- Waving 4K Country Flags
- Album Art Placeholder HOT 6
- Separate playlists for library view and currently playing queue HOT 4
- Playlist drag and drop issue on Wine/Linux
- [Suggestion] Spotify-styled "Like"/Heart button
- Crash On change Library View HOT 3
- There no `Options > Theme`
- Unable to set Default user interface to "Dark" HOT 1
- bug when clicking some where in the menu bar and/or menu elements HOT 6
- Can not restore the Backup HOT 10
- some tracks with 2 label logos HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from georgia-reborn.