ublock-llc/ublock

uBlock: a fast, lightweight, and lean blocker for Chrome, Firefox, and Safari.

ublock's Issues

Parse and enforce Adblock+ element hiding filters option not working properly.

I've only seen this, noticeably, on http://deviantart.com so far.

With the option on, it looks like this:

With the option off, the ad is blocked, but you can still see other elements on the page:

It would be nice to be able to globally enable/disable the filtering

Feedback from the Chrome store:

It would be nice to be able to globally enable/disable the filtering (without having to disable the whole extension). Sometimes I want to browse multiple sites without adblockers and it's much easier to temporarily pause filtering globally than to turn it off (and then on back again later on) for each site separately.

Thepiratebay leaves behind blocked element divs

I think I still have only the default filters turned on.

http://thepiratebay.se/torrent/10398445/Ubuntu_Server_14.04

Show the updated content of a list, not its content at install time

In 3rd-party filters tab, when clicking on a list, it shows the content of the list at install time, rather than the updated version, which may lead users to think uBlock is using an obsolete version.

Massive blocked iframe on some facebook sites

Perhaps this is what's meant by the disclaimer for the anti-facebook list, but a number of sites that use <iframe> to embed facebook content end up with huge blocked icons (the iframe height & width are 1000px ea):

e.g. http://www.monoprice.com/Product?c_id=104&cp_id=10401&cs_id=1040115&p_id=9436&seq=1&format=2

I figured "Hide placeholders of blocked elements" would hide that enormous iframe, but it doesn't.

Suggestion: add another stat when left clicking on icon showing how many data has been saved thanks to this addon

The title speaks for itself ^^

Whenever possible redirect blocked requests to noop versions of what is wanted

I believe this might help performance, but for sure this help not having the dev console firehosed with error messages because the resources were blocked. (probably do the same in HTTPSB)

Need translation of detailed description: Chinese Simplied

Reference detailed description in https://github.com/gorhill/uBlock/blob/master/dist/DESCRIPTION-reference.

Detailed description must go in: https://github.com/gorhill/uBlock/blob/master/dist/DESCRIPTION-zh_CN.

It doesn't have to be an exact translation, what matters really is a good description of what the extension does, as per Opera web store requirements (issue #23). Just do what you think is best.

"Error in response handler for browserAction.setIcon: No tab with id: 21"

Seen in the extension console while testing. I remember such error message with HTTP Switchboard. Looks like I removed too much code... Harmless though, but still need to fix.

Ability to disable the badge on top of the extension icon

Select element to block

Thanks for this, it's noticeably faster than adblock*. One thing I rely on that's missing is the ability to block an element from the context menu or at least clicking the icon and selecting an element to hide. Any plans to add something like this?

Changelog links wrong

About > Changelog links to the wrong page "https://github.com/gorhill/uBlock/wiki/Change-log" is the right link, but it links "https://github.com/gorhill/uBlock/wiki/Changelog"

Consider forcing a reload of the extension when filters have to be reloaded

I have noticed that whenever filters have to be reloaded, the memory footprint baseline of uBlock ever inches up. There is no memory leaks, it's just that it seems when temporarily handling MB of data (filter loading/parsing), the browser seems to keep stuff around and this is out of control of the extension. HTTPSB suffers the same problem, and as far as I can tell, other extensions too.

Since in uBlock nothing is temporary (as opposed to HTTPSB), when filters need reloading, simply force a reload of the extension, this way a new background page is created, all clean and tidy.

Option to also log non-blocked requests

Because some non-blocked requests may be the result of a exception filter, and we want to be able to see this.

Some images don't show up on Gmail and some thumbnails are also blocked.

Here's a screenshot of what I'm talking about: https://www.dropbox.com/s/tqbomlfzk8gpfb8/2014-06-24%2017_53_20.png

(Blurred out some private information).

I'm just wondering if this is happening to anybody else?

Make use of "fast.js"

https://github.com/codemix/fast.js
Not sure whether it'd be worth it or not, but just wanted to show you that project .. and as perf matters. :)

Sometimes requests are blocked *after* content script injected

Seen on Toronto-Star web site, some blocked iframes are not removed:

This happens because the request was not made yet when the content script executed, hence it was seen as not blocked, and since the iframe existed originally, no mutation event is dispatched for it.

suggestion : add a function to display the blocked items.

Hello everyone ! 💃

Firstly : this addon is working great ! Thanks a lot for this good work ! 👍

But I am like I am... I'll wish, if possible, display the blocked elements... :

Actually... I'd like to be able to see the blocked elements somewhere...
For instance, Ghostery shows a popup, while µBlock doesn't show anything, only the number of blocked requests...

I'm curious. ^^
I want to check everything before allowing it. ^^
So I like especially having control on my computer, as in privacy...

I prefer to see by myself the blocked elements.
Because if there is any problem, it will be easier to fix.

So, this is my question : Is it possible ?

Thank you in advance,

Best regards,
Thomas.

Filters using the `~example.com` syntax for the `domain=` option are broken

Using information bits in the hash for the domain which should not be there is quite silly.

Are you planning on releasing a Firefox port?

First of all, I saw that you have started another project (based on your first which is so awesome) and would like to congratulate you for yet another successful project. :D

Is there any plan on releasing a Firefox port for µblock? I tried it in Chromium and impressed in how light it is. It would be nice to see it running in Firefox. I have yet to find a blocker similar to µblock in Firefox.

Google ads on Google.com

Sometimes (but not very often), some Google ads appear on Google.com when you do a research. Here an example. I don't think the lists are the problem since the ads don't appear with Adblock Plus.

If needed, here's the link for the search: https://www.google.fr/#q=appareil+photo+stabilisateur+optique

Possibility to view blocked elements + corresponding filters

Feedback from the chrome store:

It would be nice to see which elements on webpage are being currently blocked and which filter blocks them. In future releases it could really help people to make whitelists. Thank you!

Need translation of detailed description: German

Reference detailed description in https://github.com/gorhill/uBlock/blob/master/dist/DESCRIPTION-reference.

Detailed description must go in: https://github.com/gorhill/uBlock/blob/master/dist/DESCRIPTION-de.

It doesn't have to be an exact translation, what matters really is a good description of what the extension does, as per Opera web store requirements (issue #23). Just do what you think is best.

Conflict with HTTPS Everywhere extension in Chrome

Hi :)

I'm really liking uBlock but I've noticed that HTTPS Everywhere is showing a 'Warning' message whenever uBlock is installed. It seems to occur whenever browsing sites that are using Google Ads and here is the error message:

Warning:
This extension failed to redirect a network request to https://partner.googleadservices.com/gpt/pubads_impl_42.js because another extension (µBlock) redirected it to chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/js/noop.js.

This message actually appears below HTTPS Everywhere in the Extensions menu in Chrome. There don't appear to be any adverse effects going on but it would be nice if there is a fix available so that the conflict no longer happens.

Thanks kindly for any help you can offer!

Could you add an overview of all whitelisted sites?

Feedback from the Chrome store:

Could you add an overview of all whitelisted (I mean: whitelisting by clicking the enable/disable button in the drop down menu) sites to the settings? What would be even better: an option to import/export those filters.

It blocks playing music on soundcloud.com

Reported here: http://www.reddit.com/r/chrome/comments/28xt2j/%C2%B5block_a_fast_and_lean_blocker_for_chromiumbased/cifl7k2

Minify code

If you know Node a little bit, you could use gulp for that. I'm using Node to minify html, css and js in my own projects, feel free to use the gulpfile and the package.json... You just need to install node, install gulp using "npm -g install gulp" (in your cmd), you switch to your dir where this project is, add the package.json and the gulpfile.js to the dir and run "npm update" in the cmd, with the folder as "target" / location. A simple "gulp" will minify the whole code then. Note: The script is configured to have a "src" (source code) and a "dist" (distribute code) folder.. not sure if you want that too. Just tell me if you need help configuring it for your needs :)

https://gist.github.com/kurtextrem/79da2dc2061d880088de

Oh, before I forget it: Thanks for this extension. Finally a good adblocker.

Twitter glitches when using Fanboy’s Annoyance List

From Wilder Securities forum:

I found one problem with Twitter. If I have uBlock enabled I can't write tweets with hashtag (#) included. The cursor just jumps right and left and it's impossible to write a tweet.

Update lists manually?

I was wondering: when do the list are updated? Since we can't manually do it. Plus, there's no indicator. When you to the third tab, it says "À jour" (I'm French, so I guess it's "Updated in english). But that's it.

Thanks!

Blocked contents don't always disappear properly

When you try to a block an image in particular, there's a problem. Here's what appear on website 9to5Mac.com. They have this image (http://s2.wp.com/wp-content/themes/vip/9to5mac2/images/adblock-inline-ad-1.png) when an ad blocker is enabled. When you try to block this image, this appears : http://i.imgur.com/6xxBFac.jpg

When you use Adblock Plus for example, the image disappear completely (see: http://i.imgur.com/16jUIqg.jpg). If you know a fix...

Opera requirements for acceptance in Opera store

Library:

I will need specific setting of uglyfy you use to minify yamd5.js because your results differs from mine (As a source I used version from master branch Jun 20, 2014)

Translation work:

Please supply Summary and Description in other languages or remove them until they will be fully translated.

Build work:

Remove ./assets/*.sh as these files are useless in production package4.

GUI for user-created filters?

I'm well aware I can add my own filters already but similar to how Element Hiding Helper works I'd really appreciate some form of GUI to make the process a lot simpler, if not doable at all. As it stands I believe I'm forced to install Adblock Plus a long with Element Hiding Helper in order to create my own filters and then import them to uBlock.

Exception filter `@@||yoursite.com^$document` doesn't seem to work

From the feedback section in the chrome store.

Possibility to add new filter list from custom url

From the feedback section in the chrome store.

uBlock blocking `chrome://`-based requests while it should not

Similar as what is reported in gorhill/httpswitchboard#364, I found that uBlock blocks too much, which in its case is a problem, as only https?-based web pages are to be dealt with, and nothing else.

For instance, this prevent signing in Google account. Fix ASAP.

Have uBlock maintain its own list of filters to unbreak sites

Because #20.

Support `elemhide` filter option

Currently not supported. There are 50 such filters in EasyList.

Add the new Fanboy's "Anti-Facebook Filters"

Home page of the list: http://www.fanboy.co.nz/filters.html

The list itself: http://www.fanboy.co.nz/fanboy-antifacebook.txt

Extremely generic element hiding selectors are current performance bottleneck

Talking about cosmetic filters here. "Extremely generic" means those selectors which are not id- or class-based (there are handled very well with low overhead), like a[alt="Follow on Facebook"].

When EasyList, EasyPrivacy, Fanboy's Annoyance and Fanboy's Enhanced Tracking are enabled, I count nearly 400 of such selectors.

See what, if anything, can be done to reduce overhead caused by these filters. It's definitely a current hot spot performance-wise.

Need translation of detailed description: Russian

Reference detailed description in https://github.com/gorhill/uBlock/blob/master/dist/DESCRIPTION-reference.

Detailed description must go in: https://github.com/gorhill/uBlock/blob/master/dist/DESCRIPTION-ru.

It doesn't have to be an exact translation, what matters really is a good description of what the extension does, as per Opera web store requirements (issue #23). Just do what you think is best.

Header tags to make the lists easier to read

From Wilder Securities.

Avoid avoidable overhead in contentscript_end.js / hideBlockedElementInAddedNodes()

Only if there are Node.ELEMENT_NODE is it worth to further enquire about blocked requests.

"Failed to load resource: net::ERR_FILE_NOT_FOUND" at launch

I often get this error at launch:

Failed to load resource: net::ERR_FILE_NOT_FOUND
    filesystem:chrome-extension://bmgihbijohdeghlojnnnpcageoekicik/persistent/assets___checksums.txt?ublock=1403611564239

Appears to be related to auto update occurring at launch. Need to figure what is happening. Appears benign otherwise, extension works fine thereafter.

Fanboy Annoyance's `||platform.twitter.com*/widgets/$third-party` not working

It's because:

FilterSingleWildcardPrefix0.prototype.match = function(url, tokenBeg) {
    return url.substr(tokenBeg, this.lSegment.length) === this.lSegment &&
           url.indexOf(this.rSegment, tokenBeg + this.lSegment.length) > 0;
};

Should be:

FilterSingleWildcardPrefix0.prototype.match = function(url, tokenBeg) {
    return url.substr(tokenBeg, this.lSegment.length) === this.lSegment &&
           url.indexOf(this.rSegment, tokenBeg + this.lSegment.length) >= 0;
};

EDIT: never mind, code above is good, the right-hand segment will never be at offset 0.

Provide a field to test a URL against the current filters

As there is no log, it's difficult to figure by which filter a specific URL is being hit.

Since all is the mechanic is in there already, just reuse it in order to get information about which filter is a hit on a specific URL. In the "Your filters" tab in the dashboard would be a good place for such feature.

Cannot directly access forum on xda-developers.com from front page

This is actually an issue when using AdGuard and Bluhell Firewall (on Firefox) too. If you browse to the front page of xda-developers.com and then click the 'Forum' button while uBlock is active absolutely nothing happens. You can open the link in a new tab without an issue but clicking on the 'Forum' button won't take you to the page at all. If you then disable uBlock (or any of the listed adblockers above) and refresh the page and click again, it goes through absolutely fine. Do you know what the issue might be and whether it can be solved?

Thanks in advance!

Checkboxes in Settings tab not initialized properly

EasyList Czech and Slovak moved

As per gorhill/httpswitchboard#361

Consider selecting "hpHosts’s Ad and tracking servers" out of the box

Author of this list is working to fix the over-zealousness.

That would be an extra over 19,000 new filters out of the box. I am currently using it, so far no problem, but I browse a limited amount of sites. If other users can try it and see if there are any issues -- i.e. we don't want the extension to break sites with out-of-the-box settings.

Report the filter list containing the filter of a blocked request

I saw it as a separate issue, it was originally reported in #12 by @zerkms:

Just as a minor addition: it also might be helpful to show not only the exact filter applied, but also a subscription name that it came from.