urschrei/polylabel-rs

A Rust implementation of the Polylabel algorithm, with FFI.

About

I'm a Marie Curie research fellow in the department of geography at Trinity College Dublin. My work focuses on public participation in climate adaptation, specifically, the use of "serious games", geodata, maps, and open urban data to inform and facilitate public participation.

I also work on computational geometry algorithms in Rust, and I have a longstanding interest in geographic data processing and visualisation in Python.

If you're interested, you can see my publications at Google Scholar. I almost never talk about work on social media. I am not overly interested in imputing meaning to the results of matrix multiplication.

polylabel-rs's Issues

new release for dependency updates

It looks like it's only dependency updates, but it'd be nice to avoid patches to avoid including multiple versions of depenencies, e.g. https://github.com/a-b-street/abstreet/blob/master/Cargo.toml#L45

Here are the changes compared to the commit which I think[^**] corresponds to the latest release: 12f0e5e...master

[**]Note: We're missing a tag on GH for the latest (2.4.1) release: https://crates.io/crates/polylabel/versions

I'd guess it corresponds to 12f0e5e which happened on the same date, but I'm not sure.

Python wheel

Hello,

Are you planning on creating a python wheel to utilize this binary? I have a use and was looking at the steps of creating one when I saw that you are making python packages for many of your rust implementations.

Thanks!

Would you consider making cbindgen dependency optional?

I have a pure rust project which has no need for the generated bindings.

I'm not familiar enough with cbindgen to know what the conventions are, but I was thinking it might make sense to simply make cbindgen an optional build dependency, and only generate the bindings when the feature is enabled.

Are you amenable to a PR?

For context, what brought me here was I noticed that your (up-to-date!) cbindgen resulted in my project duplicating the dependency. Now, I know I should go hound all the other crates to update their cbindgen, but the only thing better than an up-to-date dependency is no dependency at all!

Feature-guard cbindgen dependency

I'm having trouble depending on polylabel -- cbindgen 0.6.8 requires the old serde_derive 1.0.58, which is conflicting with the newer version demanded by some of my other dependencies. Is it possible to either guard the build-dependencies section by an optional feature, or upgrade the cbindgen dependency in the hopes that it'll use a more recent serde_derive? Thanks!

Tolerance parameter is too high in example

The L-shaped example uses a tolerance of 1.0 yielding the point (0.5, 1.5). Reducing this parameter to 0.1 matches the expected value (0.5625, 0.5625).

Using geo = "0.14.0" and polylabel = "2.3.0"