Comments (25)
change it like we want to have the focus on…
Add meta data (Person Date etc.) and Textstyling like the notebook
Finish each component so that it looks like in the notebook as the focus of the pdf rest like the on for the notebook
Fix also this broken unittests.
- testGetNotebookAndUploadedFilesForUser
- testGeneratePdf
from marugoto.
This is the same as #23 so I closed #23.
from marugoto.
I created a new bug for the pdf on the test system.
It's #52.
from marugoto.
so this issue is finally only about change the content of the pdf
content of pdf should be:
- all input from player and content like in the notebook (without audio and video)
if the user uploads a file, we add the file-name there (like it is now, if I remember that correctly) - add an appendix with all images that are zoomable.
The structure of the appendix is:
Title: Appendix of images
Subtitle: Title of the notebook entry
Image (as big as possible) with label (if there is one)
from marugoto.
As discussed here are the first rough drafts of the PDF of a notebook.
One example of Plantation Lives without appendix:
marugoto-notebook.pdf
One example of Demo Topic with new appendix:
notebook-nemanja tišma.pdf
@martindusinberre Should we continue with this approach? So we will finalize that.
Thanks for your feedback.
from marugoto.
Appendix added with commit: 807d96d
from marugoto.
The comment from Ramun was how it would actually look with a lot of inputted data. If I were to do a proper play through, then would you able to see my inputs and turn them into a notebook PDF? If so, I can do that on Wednesday so that you have a lot of dummy text.
As for my comments: it looks fine and please continue. Just a few issues:
- If I remember right, we said that we would keep single images (e.g. photo primary sources) together with the correct inputted page of the notebook, but any images with multiple jpg pages would be in the appendix: is that still the idea? Or would it be easier/quicker for you all if all imageComponents went into the appendix? Just tell me what you have in mind.
- I imagine that the fonts for the page titles/entries will be in a better font in the final PDF?
- Also, is it possible to add a header or a footer with page number and also the player's first and last name, so that the teacher can download multiple PDFs but be sure to whom they belong?
But in general: it's looking good! Many thanks and please keep going. Let me/us know how you progress, and if you want me to look at other drafts.
from marugoto.
Thanks for your feedback. To your points:
- We show only the first image in the notebook. And in the appendix we will show only the images where there is "zoomable" set to true.
OK for you? - Yes, there is a problem at the moment with the fonts. so yes.
- Yes, we can add a header with TopicName - player name and page number
from marugoto.
Great. So 1.: in the appendix are images with "zoom" and also with multiple jpgs, with each jpg file appearing as a separate image in the appendix, right?
3. Thanks. Is it also possible for you to set the name of the downloaded PDF file to include the player firstName+lastName?
from marugoto.
for 1: yes, exactly.
3: I think I would not waste time for it. Because it is always your name..... but we can do it, if you want.
from marugoto.
3: good, don't waste time on it! As long as the player name is visible on each notebook page, in that case. Thanks to you all.
from marugoto.
Drafts
v1:
marugoto-notebook.pdf
from marugoto.
Filename is also changed to match name of the player
from marugoto.
@christian-bernet The notebook is looking really great. My personal preference is for a white background, not grey, as I think it looks cleaner.
Can you just show an example in the appendix of a multi-jpg imageComponent, so that we can see what a 4 or 5 page document would look like in the notebook?
from marugoto.
- Show all images in appendix, not only the first
- Only the image at last page is wrong. I think also the title should have been on the same page
- footer: if we have a long name its not good like this.
- Show it Serge and change what is needed
@martindusinberre thanks for your feedback. Give us some time to finish it.... And then I can give you the wished example.
from marugoto.
Draft v3:
Nemanja Ti_ma.pdf
from marugoto.
@martindusinberre I think in the draft v3: it shows what you want to see.
And now the PDF download does also work at the test system. so you can download it at yourself. :-)
from marugoto.
Looks wonderful. Will try it with a full play-through on Friday/weekend and see how it copes with lots of material. Thanks to both of you, Martin
from marugoto.
@martindusinberre Can you have a look at this now and give us some feedback until Monday morning. It should works now on the test system.
We will do the last changes here on Monday.
We will also do some style changes on Monday that it looks better again.
from marugoto.
This is almost there. But one problem. Here is a screenshot of my very long notebook entry (to test #25 )
from marugoto.
And here is the relevant page in the notebook:
MD_Notebook_p2_19Sept19.pdf
from marugoto.
You can see that the right-hand side margins for the notebook entry aren't correctly set in the PDF.
You can also see that where there should be a page break in the notebook (because the entry is very long), the text just goes down to the end of the page and over the footer--and then runs out. Is there anything that can be done about this?
from marugoto.
@Helena-LiT @lfeine Can you also please check the PDF functionality for the notebook and give Christian any feedback before Monday? Thanks, Martin
from marugoto.
thanks. Yes, we can fix that at Monday.
from marugoto.
As mentioned, I'm going to close this issue now as it's basically done. Minor adjustments to the Notebook download PDF will be ticketed as new issues (e.g. the margins one is now #60)
from marugoto.
Related Issues (20)
- Autodeploy of test system broken? HOT 2
- "Download" button perhaps not working on "Your Games" page? HOT 9
- acrion captcha bug? HOT 1
- Feedback on madness-topic HOT 6
- Clarify length of demo HOT 2
- Game states not saved in autodeploy of test environment HOT 2
- Display improvements for Notebook HOT 1
- "Official" documentation HOT 2
- Broken page transitions HOT 2
- Minor issues to be fixed before launch if possible HOT 5
- Lingering input text in textExercise HOT 1
- It seems that most transitions are working again, but some are not. I have noticed that some transitions in lit-madness and in the trailer that have timers and an auto-transition feature don't work properly. In the trailer on page 1.1.7.1.2 there are two transition buttons displayed, when according to the page criteria there should be only one. In lit-madness on 4.5.15a the autotransition is never triggered after the timer runns out and the second transition (incorrectInput) never becomes available. However, I'm not sure if these problems are related.
- Problem with pageTransitions with criteria "visited" *and* time-settings HOT 10
- Changes to the LiT frontpage HOT 2
- After live launch: importer fix
- Descriptive text of Supervise group game
- First minor updates to live system HOT 4
- Your Games page (student view)
- Timer supersedes on other timer on different page HOT 2
- What's next after installing Marugoto?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marugoto.