Formatting

[volca02]

Formatting

[ktalik]

I think we can get rid of the leading whitespace in namespaces.

Do you mean indentations resulting from namespace brackets? I agree.

I'd also like to replace tabs with spaces.

I think 4 spaces will be good.

Multi-line arguments in function headers/constructors should mean the curly brace on separate line.

Moreover, it is good to treat every brackets as curly brackets (aesthetically). In other words I think about something like this:

void Root::addResourceLocation(
    const std::string& name,
    // all other arguments
) {
    // method contents
}

I also have a suggestion to write no more than 79 characters in one line. It helps in many circumstances, for example viewing two files on screen at the same time.

[volca02]

Although it is nicely consistent, I find the round bracket after newline somewhat displeasing.

Good idea with the line limit.

[ktalik]

This approach is acctually a convenience. When placing any bracket after a newline of some set of lines, it is then easier to add new line between the last line and the bracket. In other words, you don't need to navigate your cursor to a position placed before a bracket, but you simply navigate it to the end of the line (f.e. End key) and press Enter.

That's why we are placing { brackets in an usual code.

I find the round bracket after newline somewhat displeasing

While placing parameters in separate lines -- why not to separate a bracket too?

In case of definition bracket could also be not alone:
) {

I just used this style while programming with someone so I am disscussing it that much. However since there is a lot of code, there is no problem for me to follow its rules :)

[volca02]

Yea, I am hesitating to enforce new coding standard precisely because of the amount of code already in place. It would break git history on files, so for now am doing it lazily, just replacing tabs with spaces as I encounter them. Not a good solution either, but at least it does not cause so much headache when viewing history on files.

[volca02]

Transitioned to a more or less fitting clang-format rule file that is in the root of the repository. Reformatted most of the files correctly. Will continue working on this.