wangdayeeeeee/mysplash

An Unsplash Client

mysplash's Issues

Categories showing by latest images

Can you add a categories section by box to box ? Can you add this, like insWall or 500px?

download issues

About picture download issues,it's not to download.

Prevent downloading duplicate pictures

It is currently possible to download as many duplicates of a picture as one wants.

Load Nothing Again

In morning load nothing again...

像feedback那个图片是自己做的吗

如果不是，请问哪能找到这类扁平风格的插画或着图片啊，自己做app没有美工又不想将就....谢谢~

好像有人抄袭你的应用了

https://play.google.com/store/apps/details?id=com.brocoli.wally

Where is the new Version 3?

Please add new build?

Where is the new update?

I can't wait that. Because I really excited about new features. Please help.

Crash when viewing image

After an update to the latest version, I encounter an App crash when I click on an image to view its details.

App Version: 2.9.3
Android OS: 7.1/LineageOS 14.1
Reproducibility: always
STR: Tap an image in the stream.

From my logcat, I can see this NPE:

java.lang.NullPointerException: Attempt to read from field 'java.util.List com.wangdaye.mysplash._common.data.entity.unsplash.Photo$RelatedPhotos.results' on a null object reference
	at com.wangdaye.mysplash._common.ui.adapter.PhotoInfoAdapter.buildTypeList(PhotoInfoAdapter.java:125)

Some more context (stripped down a little bit):

02-22 08:45:59.053 I/ActivityManager( 3109): Start proc 20506:com.wangdaye.mysplash/u0a389 for activity com.wangdaye.mysplash/.main.view.activity.MainActivity
02-22 08:45:59.148 W/System  (20506): ClassLoader referenced unknown path: /data/app/com.wangdaye.mysplash-2/lib/arm
02-22 08:45:59.188 W/art     (20506): Before Android 4.1, method android.graphics.PorterDuffColorFilter android.support.graphics.drawable.VectorDrawableCompat.updateTintFilter(android.graphics.PorterDuffColorFilter, android.content.res.ColorStateList, android.graphics.PorterDuff$Mode) would have incorrectly overridden the package-private method in android.graphics.drawable.Drawable
02-22 08:45:59.642 I/AppCompatViewInflater(20506): app:theme is now deprecated. Please move to using android:theme instead.
02-22 08:46:00.017 I/ActivityManager( 3109): Displayed com.wangdaye.mysplash/.main.view.activity.MainActivity: +977ms
02-22 08:46:01.455 I/ActivityManager( 3109): START u0 {cmp=com.wangdaye.mysplash/.photo.view.activity.PhotoActivity (has extras)} from uid 10389 on display 0
02-22 08:46:01.931 I/ActivityManager( 3109): Displayed com.wangdaye.mysplash/.photo.view.activity.PhotoActivity: +340ms
02-22 08:46:02.003 D/AndroidRuntime(20506): Shutting down VM
02-22 08:46:02.004 E/AndroidRuntime(20506): FATAL EXCEPTION: main
02-22 08:46:02.004 E/AndroidRuntime(20506): Process: com.wangdaye.mysplash, PID: 20506
02-22 08:46:02.004 E/AndroidRuntime(20506): java.lang.NullPointerException: Attempt to read from field 'java.util.List com.wangdaye.mysplash._common.data.entity.unsplash.Photo$RelatedPhotos.results' on a null object reference
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at com.wangdaye.mysplash._common.ui.adapter.PhotoInfoAdapter.buildTypeList(PhotoInfoAdapter.java:125)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at com.wangdaye.mysplash._common.ui.adapter.PhotoInfoAdapter.updatePhoto(PhotoInfoAdapter.java:137)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at com.wangdaye.mysplash.photo.view.activity.PhotoActivity.requestPhotoSuccess(PhotoActivity.java:579)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at com.wangdaye.mysplash.photo.presenter.PhotoInfoImplementor$OnRequestPhotoDetailsListener.onRequestSinglePhotoSuccess(PhotoInfoImplementor.java:107)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at com.wangdaye.mysplash._common.data.service.PhotoInfoService$1.onResponse(PhotoInfoService.java:32)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run(ExecutorCallAdapterFactory.java:68)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at android.os.Handler.handleCallback(Handler.java:751)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at android.os.Handler.dispatchMessage(Handler.java:95)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at android.os.Looper.loop(Looper.java:154)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at android.app.ActivityThread.main(ActivityThread.java:6176)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at java.lang.reflect.Method.invoke(Native Method)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:888)
02-22 08:46:02.004 E/AndroidRuntime(20506): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:778)
02-22 08:46:02.006 W/ActivityManager( 3109):   Force finishing activity com.wangdaye.mysplash/.photo.view.activity.PhotoActivity
02-22 08:46:02.010 W/ActivityManager( 3109):   Force finishing activity com.wangdaye.mysplash/.main.view.activity.MainActivity
02-22 08:46:02.082 I/OpenGLRenderer( 3109): Initialized EGL, version 1.4
02-22 08:46:02.082 D/OpenGLRenderer( 3109): Swap behavior 1
02-22 08:46:02.511 W/ActivityManager( 3109): Activity pause timeout for ActivityRecord{63bd373 u0 com.wangdaye.mysplash/.photo.view.activity.PhotoActivity t275 f}

v3.0.8 source code not published?

There is v3.0.8 on Google Play. In this repo there is only v3.0.7 (see app/build.gradle), though tagged as v3.0.8. Could you please clarify my confusion? I'd like to bring the latest version of Mysplash to F-Droid.

Add To Collection size

Hello,

Is there a possibility that the popup to add a photo to a collection, could be a bit bigger? I can see just 2 actual collections, and having the popup a bit bigger would allow more to be visible.

Otherwise, amazing app! Love using it, feels really smooth and just simple.

Login fails (with other browser)

Using Firefox for Android v52 and Mysplash 3.0.5 I cannot login. When I login into my MySplash account I am redirected to the app, but the app does not recognize it and still says I am not logged in.

Maybe you could rather use built-in WebView like StreetComplete does it, which may be more robust for this login. However, this of course has the disadvantage that users cannot use the browser's password manager for logging in.

有办法get tags吗

我看文档中并没有相应的api。。

Custom APIKEY?

Add an option to allow user to set their own APIKEY to prevent rate limit.

About New Update*

When will the new update come?
@WangDaYeeeeee

Small bug

https://youtu.be/m1YfBVlP4hU

error when installing as wallpaper

error when installing as wallpaper Android 5.1.1

E/AndroidRuntime: FATAL EXCEPTION: main
                                                                     Process: com.wangdaye.mysplash, PID: 4117
                                                                     java.lang.RuntimeException: Unable to start receiver com.wangdaye.mysplash.common.receiver.DownloadReceiver: android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity  context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want?
                                                                         at android.app.ActivityThread.handleReceiver(ActivityThread.java:2616)
                                                                         at android.app.ActivityThread.access$1700(ActivityThread.java:151)
                                                                         at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1380)
                                                                         at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                         at android.os.Looper.loop(Looper.java:135)
                                                                         at android.app.ActivityThread.main(ActivityThread.java:5254)
                                                                         at java.lang.reflect.Method.invoke(Native Method)
                                                                         at java.lang.reflect.Method.invoke(Method.java:372)
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
                                                                      Caused by: android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity  context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want?
                                                                         at android.app.ContextImpl.startActivity(ContextImpl.java:1238)
                                                                         at android.app.ContextImpl.startActivity(ContextImpl.java:1225)
                                                                         at android.content.ContextWrapper.startActivity(ContextWrapper.java:323)
                                                                         at android.content.ContextWrapper.startActivity(ContextWrapper.java:323)
                                                                         at com.wangdaye.mysplash.common.b.a.d.d(DownloadHelper.java:382)
                                                                         at com.wangdaye.mysplash.common.b.a.d.a(DownloadHelper.java:297)
                                                                         at com.wangdaye.mysplash.common.b.a.d.d(DownloadHelper.java:260)
                                                                         at com.wangdaye.mysplash.common.receiver.DownloadReceiver.onReceive(DownloadReceiver.java:25)
                                                                         at android.app.ActivityThread.handleReceiver(ActivityThread.java:2609)
                                                                         at android.app.ActivityThread.access$1700(ActivityThread.java:151) 
                                                                         at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1380) 
                                                                         at android.os.Handler.dispatchMessage(Handler.java:102) 
                                                                         at android.os.Looper.loop(Looper.java:135) 
                                                                         at android.app.ActivityThread.main(ActivityThread.java:5254) 
                                                                         at java.lang.reflect.Method.invoke(Native Method) 
                                                                         at java.lang.reflect.Method.invoke(Method.java:372) 
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) 
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) 

Building Error

I have testing your project, but I have new issues. Let's check it out now. I'm not building your project.

I have not made any edits at all.

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.wangdaye.mysplash/com.wangdaye.mysplash.photo.view.activity.PhotoActivity}: android.view.InflateException: Binary XML file line #18: Could not inflate Behavior subclass com.wangdaye.mysplash._common.ui.behavior.PhotoCoverBehavior at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3319) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3415) at android.app.ActivityThread.access$1100(ActivityThread.java:229) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1821) at android.os.Handler.dispatchMessage(Handler.java:102) at android.os.Looper.loop(Looper.java:148) at android.app.ActivityThread.main(ActivityThread.java:7331) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120) Caused by: android.view.InflateException: Binary XML file line #18: Could not inflate Behavior subclass com.wangdaye.mysplash._common.ui.behavior.PhotoCoverBehavior at android.view.LayoutInflater.inflate(LayoutInflater.java:551) at android.view.LayoutInflater.inflate(LayoutInflater.java:429) at android.view.LayoutInflater.inflate(LayoutInflater.java:380) at android.support.v7.app.AppCompatDelegateImplV9.setContentView(AppCompatDelegateImplV9.java:288) at android.support.v7.app.AppCompatActivity.setContentView(AppCompatActivity.java:143) at com.wangdaye.mysplash.photo.view.activity.PhotoActivity.onCreate(PhotoActivity.java:124)

Images auto cropping like Wallsplash?

Hey, can you add auto crop and set background in auto? Like Wallsplash. When we touch wallpaper button wallpaper auto set?

Wrong name in readme

readme中repo名字打错了 ps 愿意支持MIUI的亮色状态栏吗

Error:(158, 57) error: cannot find symbol method setSearchPhotoList(List<Photo>)

Error:(158, 57) error: cannot find symbol method setSearchPhotoList(List)
Error:(171, 106) error: cannot find symbol method getSearchPhotoList()7

Error:(53, 19) error: cannot find symbol variable activity_tag_statusBar

and many errors. How to fix it?

v2.8.8 can't like pictures anymore

the latest update which "improves some of the logic behind liking pictures" actually broke it for me. the tiny spinner comes up for a second but the picture remains without a like. Have tried it with both official and custom API keys. Can you please check if everything is technically fine?

Tag Search

if user click tags then show tag's images? Is this possible? like http://www.arthurweill.fr/Unsplash/en maybe you can add your project :)

Issue with dark theme and settings page

Screenshot: https://u.pomf.is/lusmzn.png

Profile header stays fixed

Header (with photo,name and description of a person) sometimes stays fixed. I'm able to see pictures and scroll down with the header expanded.

Russian language support

russian language translation(values-ru)
rename to strings.xml
strings-ru.txt
arrays

[Idea] Live Photos

If user select a category, will soon live wallpaper on schedule? Is this possible? Maybe could this function very impreessive.

Cannot load trending

The F-Droid version cannot load anything, as the "trending" area always shows nothing. "Nothing loaded. Press to retry".

For some strange reason I can download images and set them as backgrounds.
It shows a strange loading animation then, but that's it.

Possible copyright infringement

Hi

I really like it, is super cool app, well designed, with good performance, etc.

I don't know what's the license of this project. But it seems like someone just forked and created an almost-exact (if not exact) copy of your app.

Just wanted to let you know in case you want to report it or do something about it.

Good luck and keep up the awesome work.

Link to the app:
https://play.google.com/store/apps/details?id=com.brocoli.wally

Dont looks good category section

I dont like new category section maybe you can add â bottombar like 500px get better. Is this possible?

Would you move the art things to an issue or anywhere else?

Really nice project!!

But there is quite a little bit of images making it hard to clone, would you like to move it to an issue? thx!

Always show "0" relative images

When I click more button always 0 relative photos. Please fix them.

跪求API整理😚

撸主可以整理一下API吗 万分感谢 😅

strange placeholder launcher icons on image viewer

this happens when I tap once inside the new image viewer. (v2.9.5)
http://i.imgur.com/3GQFtOI.jpg

Using weblate for translations

Weblate is a web service which makes translations easier and it is free for foss projects

Github pictures of translators may be non free

I dont think that github profile pictures are foss. When you download them the app might get tagged with a non-free antifeature on fdroid.

Automatically set image as background

It would be nice if this app would have an option to automatically download a good, recent image (maybe features or so) and set it as the Android home screen background image once a day.

This way we can always enjoy a nice "picture of the day".

Suggestion: Using Github releases to host apks

As we have more and more releases, the repo size grows fast. I suggest to use Github releases to host packages and remove them from git trees.

Can't load anything

Since the 2.7.3 > 2.7.8 update in F-Droid.

Some SSL error

Hi, I'm using v3.2.1 from F-Droid and getting a notification on the bottom of the screen saying:

Failed to load. (javax.net.ssl.SSLProtocolException: SSL... hand)

It's cut off at the ... point and I can't seem to expand it. I'm on Android 4.4.4 by the way.

[feature request] follow users

I am not sure if this feature is still in beta, but recently Unsplash introduced a new feature to their page that finally lets you follow specific photographers (just like you would on other social networks). Would be cool if this functionality could come to Mysplash as well.

FR: Include metadata for fdroid

When providing metadata via a fastlane directory, fdroid automaticly shows them in the store. You dont need to install fastlane, just create the folder

Example: https://github.com/Freeyourgadget/Gadgetbridge/tree/master/fastlane/metadata/android/en-US
Info: https://github.com/fastlane/fastlane/blob/2.28.7/supply/README.md#images-and-screenshots

Load nothing

Hi. Version 2.8.9 doesn't load any image.

Getting Building Error

ye.mysplash E/AndroidRuntime: FATAL EXCEPTION: main
                                                                     Process: com.wangdaye.mysplash, PID: 5489
                                                                     java.lang.RuntimeException: Unable to start activity ComponentInfo{com.wangdaye.mysplash/com.wangdaye.mysplash.main.view.activity.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.support.design.widget.NavigationView.inflateMenu(int)' on a null object reference
                                                                         at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2927)
                                                                         at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2988)
                                                                         at android.app.ActivityThread.-wrap14(ActivityThread.java)
                                                                         at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1631)
                                                                         at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                         at android.os.Looper.loop(Looper.java:154)
                                                                         at android.app.ActivityThread.main(ActivityThread.java:6682)
                                                                         at java.lang.reflect.Method.invoke(Native Method)
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1520)
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1410)
                                                                      Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.support.design.widget.NavigationView.inflateMenu(int)' on a null object reference
                                                                         at com.wangdaye.mysplash.main.view.activity.MainActivity.initView(MainActivity.java:356)
                                                                         at com.wangdaye.mysplash.main.view.activity.MainActivity.onStart(MainActivity.java:225)
                                                                         at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1256)
                                                                         at android.app.Activity.performStart(Activity.java:6959)
                                                                         at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2890)
                                                                         at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2988) 
                                                                         at android.app.ActivityThread.-wrap14(ActivityThread.java) 
                                                                         at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1631) 
                                                                         at android.os.Handler.dispatchMessage(Handler.java:102) 
                                                                         at android.os.Looper.loop(Looper.java:154) 
                                                                         at android.app.ActivityThread.main(ActivityThread.java:6682) 
                                                                         at java.lang.reflect.Method.invoke(Native Method) 
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1520) 
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1410) 

Every time building it, showing up. Can you help me? Thanks.

Where is the newest version in Relative Images and "more" section?

Where is the newest version in Relative Images and "more button" section?

Thanks.

[idea] show remaining API requests

Would it be possible to show the remaining API requests for this hour somewhere in the app (for instance inside the left panel)? as far as I understand their documentation you always receive something like

200 OK
X-Ratelimit-Limit: 1000
X-Ratelimit-Remaining: 999

as part of their HTTP Response header.
At this point when you know the global limit it would also be possible to just count the requests locally, right? I think this might be a good way to handle the current situation with the rate limiting.

App crashes when clicking on image item in Download

App always crashes when clicking on any download image item in Download.

Automatic download of pictures in certain collections

This is a feature request.

I think it would be really useful if there was an option to automatically download pictures in a certain collection, when one adds a new one.

Similar to what Spotify Premium offers with playlists.

I don't know if that would be possible, but it would be really great to have. Thanks

German translation

I've translated your app to German via Stringlate.

You may have to have a look at it first because I've translated some Strings with an underscore which I guess I'm not supposed to.

Error on sliding down

In new tab when I scrollling down always it crashed. Check it out app.