Comments (5)
Yeah, works again. I also noticed that as it seems up until now there was a mismatch between src and concat/minified files like e.g. models.js and all.js
I'll add a rebuild of the assets to the issue branch and merge this tomorrow.
from wcm-avatar.
I think the whole build process is broken:
package.json#L17 and scripts/scripts don't match.
After that it still doesn't work because something is wrong with scripts/scripts#L2
Also the versions used look old and I'm note sure of the packages themselves.
So yeah, this all needs a major overhaul. ๐
from wcm-avatar.
@kraftner should be working again. Use npm run build
to trigger a build. I am not really sure if the watch
process works. The last version used to just call npm run build
, which triggered endlessly. The current version just includes the commands from the js
and the css
files. While this might work better, the file location is relative to the location from where you call the script โย it just assumes you are in the project root when doing so. This might fail, please give this a test run. The branch to test is issue-27-assets
.
from wcm-avatar.
Thanks @kraftner โย Please do not forget about #48
from wcm-avatar.
@franz-josef-kaiser Is this good enough in your opinion or do you want to keep it open to further improve it?
from wcm-avatar.
Related Issues (20)
- Add better labels for GitHub
- Default/Fallback avatar HOT 1
- Reconsider positioning of UI on profile page HOT 3
- Disable Multi-Selection HOT 1
- Multi Uploader breaks when Upload fails HOT 3
- Helpers for common checks HOT 4
- Create *.pot file HOT 4
- Use correct text domain
- AvatarScriptsService lacks check for permissions HOT 1
- Reconsider using file_get_contents() in UnderscoreTemplateScripts HOT 11
- Make Plugin work for users without `upload_files` permission HOT 2
- Remove (apparently) unused AdminStylesService HOT 3
- Avatar Settings Page ends up weird HOT 3
- As a user who uploaded a custom avatar, I do not want to get fooled about using Gravatar HOT 6
- Uploader broken HOT 3
- AvatarBrowserUploaderSaveService breaks on non-english locale HOT 2
- AvatarMIMELimitService limits mime types for all uploads, but only for the browser-uploader HOT 3
- AvatarUploadSizeLimit only affects multi-uploader (plupload)
- AvatarBrowserUploaderSaveService nests errors one level to deep HOT 1
- AvatarDimensionLimitService and AvatarExistsLimitService only affect Multi-Uploader
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wcm-avatar.