xapple/plumbing

Helps with plumbing-type programing in python.

plumbing's Issues

Can SQLiteDatabase accept pathlib objects?

Current status

ipdb> db_v1 = SQLiteDatabase(db_path_v1)
*** TypeError: argument of type 'PosixPath' is not iterable
ipdb> str(db_path_v1)
'/home/paul/repos/eu_cbm/eu_cbm_aidb/countries/SI/aidb_v1.db'

Longer stack trace of the error in that case:

File ~/eu_cbm/eu_cbm_hat/scripts/conversion/update_aidb_1x_to_2x.py:66, in convert_aidb_to_v2(db_path)
     64 # Rename the old AIDB to v1
     65 shutil.copy(db_path, db_path_v1)
---> 66 # Remove the "index" column in the disturbance_matrix_value table.
     67 # This was introduced by mistake and shouldn't be there.
     68 db_v1 = SQLiteDatabase(db_path_v1)
     69 dm_values = db_v1.read_df("disturbance_matrix_value")

File ~/repos/autopaths/autopaths/base_path.py:60, in BasePath.__new__(cls, path, *args, **kwargs)
     58 def __new__(cls, path, *args, **kwargs):
     59     """A Path object is in fact a string."""
---> 60     return str.__new__(cls, cls.clean_path(path))

File ~/repos/autopaths/autopaths/base_path.py:38, in BasePath.clean_path(cls, path)
     36 if hasattr(path, 'path'): path = path.path
     37 # Expand the tilda #
---> 38 if "~" in path: path = os.path.expanduser(path)
     39 # We will store the path with the OS specific separator #
     40 # We will never mix both kinds of separators #
     41 if os.name == "posix": path = path.replace("\\", sep)

TypeError: argument of type 'PosixPath' is not iterable

Easily fixed by converting to a string

ipdb> db_v1 = SQLiteDatabase(str(db_path_v1))

But the error message "TypeError: argument of type 'PosixPath' is not iterable" is confusing at first.

Proposal

The "argument of type 'PosixPath' is not iterable" is a bit confusing. Can SQLiteDatabase accept pathlib objects?

Lean board product test

https://app.leanboard.io/board/14de89c2-ae04-4d15-9350-afe4507115fe