Giter Site home page Giter Site logo

Comments (5)

the-black-eagle avatar the-black-eagle commented on May 27, 2024 2

Meh !! So, what's happening is that there are streamdetails for episodes, but only a duration. Therefore, the test for no streamdetails fails and the file is not probed.

What I need to dig into, is whether that duration is not getting reset correctly, or whether it's coming from the scraper.

The symptom is clear, now to find the root cause and establish a fix.

from xbmc.

the-black-eagle avatar the-black-eagle commented on May 27, 2024 1

@Hitcher Yeah, it is. The scraper calls addVideoStream() and adds (just) the duration to it. Therefore HasStreamDetails() returns true, even though it's only a partial detail.

I have a fix which checks for one of the following missing

  • Video codec
  • video height
  • video width
  • video duration

If just one of those is missing, then the file will be checked for the details. I don't see a need really to check for missing audio stuff as I don't know of any 3rd party nfo manager that would miss out audio info but include video info. As a minimum, I would expect an nfo file to include all of that list, but if not, then the file will be probed anyway.

In my tests, nfo files are read correctly, even if they contain wrong info (as long as it is present). Refreshing from internet now works correctly for movies and tv shows. Music videos aren't affected as the scraper doesn't return any stream details anyway.

Bit more testing to do but PR should be done soon.

from xbmc.

biner73 avatar biner73 commented on May 27, 2024

I am seeing this same issue. Noticed this behavior started recently, sometime after the Beta 2 build. The Beta 2 build does not have this issue.

Something else to add, I've confirmed this to be occuring with both the MovieDB TV Shows and the TVDB4 scrapers alike.

from xbmc.

biner73 avatar biner73 commented on May 27, 2024

@the-black-eagle Having a quick look at the merges after the latest working build 7413267, could possibly be related to this change? #24386

from xbmc.

Hitcher avatar Hitcher commented on May 27, 2024

@the-black-eagle pretty sure the duration is coming from the scraper as we show the exact duration including seconds whereas tmdb doesn't.

from xbmc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.