Selected screensaver does not start when button are shown on a paused video and/or a window is opened in a menu. The image is dimmed instead.

[WizardKnight]

Selected screensaver does not start when button are shown on a paused video and/or a window is opened in a menu. The image is dimmed instead.

[enen92]

@vpeter4 https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240207-b8efd969-screensaver_modal-x64.exe
(might take a while to get propagated)

This test build does not appear to fix the menu issue.

It seems to fix bypass the paused video issue by forcing the Automatically close video OSD option to enabled, based on my observed behavior. If you didn't want your buttons to be automatically hidden, this could be considered introducing a new bug.

If this was accepted as the fix, you might as well remove the enable Automatically close video OSD option.

I would say that other options should be explored before this method should be selected as the same outcome can be achieved by just enabling enable Automatically close video OSD in the existing release.

However if I am missing something, feel free to call me out on it.

What the hell are you even talking about? The only thing the PR does is to remove the force of the dim screensaver when a modal is active. See the diff: https://github.com/xbmc/xbmc/pull/24664/files
If you have settings changed you must have messed things up on your end.

[vpeter4]

@enen92: Now there is no dim and no screensaver. In log I get this

2024-02-07 18:05:45.995 T:5520    debug <general>: CDVDAudio::Pause - pausing audio stream
2024-02-07 18:06:48.641 T:10368   debug <general>: Activating window ID: 12900
2024-02-07 18:06:48.641 T:10368    info <general>: Activate of window '12900' refused because there are active modal dialogs

Looks like somewhere else fails now.

[enen92]

@enen92: Now there is no dim and no screensaver. In log I get this

2024-02-07 18:05:45.995 T:5520    debug <general>: CDVDAudio::Pause - pausing audio stream
2024-02-07 18:06:48.641 T:10368   debug <general>: Activating window ID: 12900
2024-02-07 18:06:48.641 T:10368    info <general>: Activate of window '12900' refused because there are active modal dialogs

Looks like somewhere else fails now.

Hum, what screensaver are you using?
edit: Ok, I just checked WINDOW_SCREENSAVER is a window and not a dialog, pushed a test commit and asked for another test build. Will let you known when ready.

[vpeter4]

what screensaver are you using?

Asteroids gave this log above and doesn't start and video stays paused on screen.
But Digital Clock works. When video is paused then after time clock is shown on black screen as it should.

[vpeter4]

Asteroids still doesn't work - this time different issue

2024-02-07 20:45:13.726 T:424     debug <general>: Activating window ID: 12900
2024-02-07 20:45:13.726 T:424     debug <general>: ------ Window Init () ------
2024-02-07 20:45:13.726 T:424     debug <general>: ADDON: Dll Initializing - Asteroids
2024-02-07 20:45:13.726 T:424     debug <general>: SECTION:LoadDLL(C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.asteroids\screensaver.asteroids.dll)
2024-02-07 20:45:13.727 T:424     debug <general>: SECTION:UnloadDll(C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.asteroids\screensaver.asteroids.dll)
2024-02-07 20:45:13.727 T:424      info <general>: ADDON: Dll Destroyed - Asteroids
2024-02-07 20:45:13.727 T:424     debug <general>: ------ Window Deinit () ------

Now it also doesn't work in Screensaver selection as Preview (looks like same log as above) - this worked in previous build

2024-02-07 20:49:42.754 T:424     debug <general>: Activating window ID: 12900
2024-02-07 20:49:42.754 T:424     debug <general>: ------ Window Init () ------
2024-02-07 20:49:42.754 T:424     debug <general>: ADDON: Dll Initializing - Asteroids
2024-02-07 20:49:42.754 T:424     debug <general>: SECTION:LoadDLL(C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.asteroids\screensaver.asteroids.dll)
2024-02-07 20:49:42.757 T:424     debug <general>: SECTION:UnloadDll(C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.asteroids\screensaver.asteroids.dll)
2024-02-07 20:49:42.757 T:424      info <general>: ADDON: Dll Destroyed - Asteroids
2024-02-07 20:49:42.757 T:424     debug <general>: ------ Window Deinit () ------

Digital Clock is still working but now I see this is Python addon

2024-02-07 20:47:33.641 T:424     debug <general>: using python screensaver add-on screensaver.digitalclock
2024-02-07 20:47:33.642 T:9092    debug <general>: Thread LanguageInvoker start, auto delete: false
2024-02-07 20:47:33.642 T:9092    debug <general>: initializing python engine.
2024-02-07 20:47:33.642 T:9092    debug <general>: CPythonInvoker(3, C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock\default.py): start processing
2024-02-07 20:47:33.703 T:9092    debug <general>: -->Python Interpreter Initialized<--
2024-02-07 20:47:33.704 T:9092    debug <general>: CPythonInvoker(3, C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock\default.py): the source file to load is "C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock\default.py"
2024-02-07 20:47:33.704 T:9092    debug <general>: CPythonInvoker(3): full python path:
2024-02-07 20:47:33.704 T:9092    debug <general>: CPythonInvoker(3):   custom python path:
2024-02-07 20:47:33.704 T:9092    debug <general>: CPythonInvoker(3):     C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock
2024-02-07 20:47:33.704 T:9092    debug <general>: CPythonInvoker(3):   default python path:
2024-02-07 20:47:33.704 T:9092    debug <general>: CPythonInvoker(3):     C:\Program Files\Kodi\system\python\DLLs
2024-02-07 20:47:33.704 T:9092    debug <general>: CPythonInvoker(3):     C:\Program Files\Kodi\system\python\Lib
2024-02-07 20:47:33.704 T:9092    debug <general>: CPythonInvoker(3):     C:\Program Files\Kodi\system\python\Lib\site-packages
2024-02-07 20:47:33.705 T:9092    debug <general>: CPythonInvoker(3): adding args:
2024-02-07 20:47:33.705 T:9092    debug <general>: CPythonInvoker(3):  
2024-02-07 20:47:33.705 T:9092    debug <general>: CPythonInvoker(3, C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock\default.py): entering source directory C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock
2024-02-07 20:47:33.705 T:9092    debug <general>: CPythonInvoker(3, C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock\default.py): instantiating addon using automatically obtained id of "screensaver.digitalclock" dependent on version 3.0.0 of the xbmc.python api
2024-02-07 20:47:33.737 T:9092    debug <CAddonSettings[[email protected]]>: trying to load setting definitions from old format...
2024-02-07 20:47:33.747 T:9092    debug <general>: Digital Clock Screensaver 6.0.5: Started
2024-02-07 20:47:33.750 T:424     debug <general>: ------ Window Init (C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock\resources\skins\default\720p\skin.estuary.xml) ------
2024-02-07 20:47:33.751 T:424      info <general>: Loading skin file: C:\Users\peter\AppData\Roaming\Kodi\addons\screensaver.digitalclock\resources\skins\default\720p\skin.estuary.xml, load type: LOAD_ON_GUI_INIT
2024-02-07 20:47:33.761 T:9092    debug <general>: Digital Clock Screensaver 6.0.5: Initialising
2024-02-07 20:47:33.777 T:6580    debug <general>: Thread JobWorker start, auto delete: true
2024-02-07 20:47:33.783 T:6580    debug <general>: XCURL::DllLibCurlGlobal::easy_acquire - Created session to http://www.msftconnecttest.com

[enen92]

Now it is better but still one issue: Asteroids screen saver starts but it doesn't make black screen but instead video is still visible in background. Don't know if this is how it should look or not.

Interesting, just tried and it seems to only happen on windows. On mac and android it's fine (black background). Will look into it.

[vpeter4]

Hopefully it's done for now :)

Agree: I think it works now like it should.

[enen92]

Thanks for the feedback and continuous tests, I'll keep an eye for regressions during RC

[vpeter4]

Tested on Windows with Kodi Omega nigtly:

• If you press key Spacebar on keyboard to pause then screensaver starts.
• But if you press key I for Information Page and select pause from there then only Dim happen.

[WizardKnight]

Pressing the space bar on a keyboard results in the menu buttons not being shown.
The menu buttons being shown is part of the steps required to reproduce the bug as noted in my 'To Reproduce' section above.
4. Pause the video and leave the control buttons showing.

[vpeter4]

I know. I wanted to point out that it still depends what is on screen and when screensaver starts.

[WizardKnight]

Oh, ok.

[enen92]

Mind giving a go to #24664 to check if it covers all use cases reported?

[vpeter4]

Would be possible to get Windows testbuild?

[WizardKnight]

It is possible I suppose. The linked bug doesn't give much detail regarding its use cases, so it's very hard to say. -Sent from Android. Feb 7, 2024 3:09:14 AM Miguel Borges de Freitas ***@***.***>:

…

Mind giving a go to #24664[#24664] to check if it covers all use cases reported? — Reply to this email directly, view it on GitHub[#24627 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AMRMWFAQ45STOMY7NJLS4XLYSNOFVAVCNFSM6AAAAABCXUL6JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZRHAYTGMZXGY]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AMRMWFEYY5DGULAEE63D5YTYSNOFVA5CNFSM6AAAAABCXUL6JSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTTEURAA.gif]

[enen92]

@vpeter4 https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240207-b8efd969-screensaver_modal-x64.exe

(might take a while to get propagated)

[WizardKnight]

@vpeter4 https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240207-b8efd969-screensaver_modal-x64.exe

(might take a while to get propagated)

This test build does not appear to fix the menu issue.

It seems to fix bypass the paused video issue by forcing the Automatically close video OSD option to enabled, based on my observed behavior. If you didn't want your buttons to be automatically hidden, this could be considered introducing a new bug.

If this was accepted as the fix, you might as well remove the enable Automatically close video OSD option.

I would say that other options should be explored before this method should be selected as the same outcome can be achieved by just enabling enable Automatically close video OSD in the existing release.

However if I am missing something, feel free to call me out on it.

[WizardKnight]

@vpeter4 https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240207-b8efd969-screensaver_modal-x64.exe
(might take a while to get propagated)

This test build does not appear to fix the menu issue.
It seems to fix bypass the paused video issue by forcing the Automatically close video OSD option to enabled, based on my observed behavior. If you didn't want your buttons to be automatically hidden, this could be considered introducing a new bug.
If this was accepted as the fix, you might as well remove the enable Automatically close video OSD option.
I would say that other options should be explored before this method should be selected as the same outcome can be achieved by just enabling enable Automatically close video OSD in the existing release.
However if I am missing something, feel free to call me out on it.

What the hell are you even talking about? The only thing the PR does is to remove the force of the dim screensaver when a modal is active. See the diff: https://github.com/xbmc/xbmc/pull/24664/files If you have settings changed you must have messed things up on your end.

Of course. I am clearly at fault. I apologize for sharing my observations.

[enen92]

@vpeter4 https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240207-079db878-screensaver_modal-x64.exe

[enen92]

@vpeter4 thanks for the feedback (I don't have binary addons on my main dev machine (linux) so the last changes were done pretty much blindly :)).
Now I've tried to reproduce and fix on another platform which doesn't really require a lot of time to setup the binary screensaver scenario for debug (macOS). Here's a new attempt:

https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240208-2ff61fea-screensaver_modal-x64.exe

[vpeter4]

Now it is better but still one issue: Asteroids screen saver starts but it doesn't make black screen but instead video is still visible in background. Don't know if this is how it should look or not.

[enen92]

Ok so this is actually a screensaver issue since it only resets the renderarea to black on GL: https://github.com/xbmc/screensaver.asteroids/blob/Omega/src/main.cpp#L155-L158

I think screensavers as a dialog should be free to have transparency if they wish and it should be up to the screensaver to make it black. Since this might affect a lot of screensavers and the timing for omega is not the best one, and in order to keep the same behaviour I forced the black rect on the screensaver dialog itself (https://github.com/xbmc/xbmc/pull/24664/files#diff-9a3dd1bbb25043f321ca7c264fae88e2ef26b23ee2b3486a3999bfca70c2aa52R44-R47).
Hopefully we could revisit screensavers for v21 and nuke this block of code.

Testbuild is here: https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240209-8d8f56f1-screensaver_modal-x64.exe
Hopefully it's done for now :)