zsoltmolnarrr/combatroll

🧶 Adds combat roll ability, with related attributes and enchantments.

combatroll's Issues

Crash on loading world with TinyInv?!

Minecraft version - 1.20.1
Mod loader - Forge 47.2.0
Mod version - 1.3.0
I am using the latest version available - Yep

Describe the bug
The game crash, when loading a world, same when creating a new world.

To Reproduce
Steps to reproduce the behavior:
I don't really know how.

1. My modpack work perfectly without TinyInv, or without CombatRoll.
   When they're together, it crash on world loading.

2. When i put only them together into a new Modpack, it work fine...

3. TinyInv make the game crash, when using a weapon, in survival mod with BetterCombat. (the owner didn't respond about this bug for the moment)

NB : That a strange bug, and i don't really know what mod did this, i saw CombatRoll on top, so, that why i'm reporting to you first.

Expected behavior
Not a crash

Screenshots or video recordings
Not needed, i think?!

Additional context
TinyInv
Crash report

Crash client with a CombatRoll

Minecraft version - 1.20.1
Mod loader - Fabric (letest)
I am using the latest version available - Yes

Describe the bug
Client crash when trying to start a roll animation

Logs
combatroll_crash.txt

bug with the hotkey

Minecraft version - 1.20.1
Mod loader - Fabric 0.14.22
Mod version - 1.3.0+1.20.1
I am using the latest version available - yes

Describe the bug
if you type in the chat the letter that you put as hotkey for dash, for example "R", and quickly press Enter to send the message, the Dash may be used, and sometimes an even bigger bug occurs in which the Dash becomes happening nonstop

I made a video explaining it to make it easier to understand:

https://www.youtube.com/watch?v=qOR_hAJL8iM

in this video i was only using Cloth Config, Fabric API, ModMenu, PlayerAnimator and Combatroll

log:
latest.log

if you are going to fix this, please update to Fabric 1.20.1 and make it compatible with Fabric Loader 0.14.22 please, thank you

Support for left-handed GUI

I read project readme, checked client side and server side configurations, and no such feature exists
Yes.

Is your feature request related to a problem? Please describe.
When I select "Main Hand: Left" from the skin customization menu, the roll indicator covers the offhand slot in the hotbar (which gets moved to the right side when this setting is selected)

Describe the solution you'd like
When "Main Hand: Left" is enabled, move the roll indicator to the right side of the hotbar, or move the indicator somewhere else on the screen that won't cover the offhand under either main hand settings

Describe alternatives you've considered
Add an option to disable the roll indicator

Additional context
What using Main Hand: Left looks like currently:

Rolling acting as crawling

Not much to say here, but it would be really neat if rolling temporarily made you act as if crawling - lowering your first person camera and letting you fit into 1 block high gaps, leaving you in a crawling state if there isn't room at the end of the crawl

Crashing

Its all in the crash log https://mclo.gs/PHpTuY1

Add support for 1.20.4

It would be great to be able to use this mod in the latest version

Pressing the Roll Key causes the player to roll while in the Inventory Screen, but not other GUIs

Minecraft version - 1.18.2
Mod loader - Forge
Mod version - 1.0.5
I am using the latest version available - Yes

Describe the bug
When in the inventory, the player can still roll. This is an issue, because the R key is also used by jei etc. Changing it to a different button may also be an issue. It would be nice to have a config option to turn that off at least.

To Reproduce
Steps to reproduce the behavior:

1. Open the inventory
2. Press R
3. You roll

Expected behavior
Rolling being disabled while being in the inventory

(Request) Air Roll distance adjustment / max air rolls config options.

I read project readme, checked client side and server side configurations, and no such feature exists - YES
Is your feature request related to a problem? Please describe.
I just think it would be neat if we could adjust the ground rolling & adjust air rolling distance. (The config says we can only ADD ground rolling distance.)

Describe the solution you'd like
An option to change the roll distance in blocks or whatever would be easiest, being able to use the roll midair to try and clear a gap is a fun concept, but I feel it may be too powerful in terms of how much distance it can clear by default. (Also, I have not tested it yet, but if you can do multiple rolls in the air, then an option to change the max air rolls would also be appreciated.)

Describe alternatives you've considered
Adjusting roll distance, but the config only seems to allow adding roll distance, though adjusting both ground & air rolling distance separately would be ideal.

Additional context
I am using forge Combat Roll 1.1.5 (1.19.2)

Forge Version Crashes Servers

Minecraft version - 1.19.2
Mod loader - Forge
Mod version - combatroll-forge-1.0.0+1.19.jar
I am using the latest version available - Yes

Describe the bug
Mod crashes on server to due to calling screen code in common.

To Reproduce
Steps to reproduce the behavior:

Add mod to server

Expected behavior
Server works lol

Log: https://gist.github.com/AzureDoom/c7ecfefb78b56ad10f8998c9c53964e7

[Feature request] Configurable invincibility ticks upon rolling

I read project readme, checked client side and server side configurations, and no such feature exists - YES/NO
Yes
Is your feature request related to a problem? Please describe.
N/a
Describe the solution you'd like
The introduction of I-frames as a config option would make this mod perfect for what I have in mind, which is basically me looking for a replica of the dark souls dodgeroll.
TL:DR; I think it would be neat if the player was invincible for a period of time while rolling, to make rolling more useful.

Describe alternatives you've considered
I'm not really sure if there are any other alternatives to achieve the same feel in combat.

Disable rolling below certain hunger

As the title says. Feels a little bit cheaty that we can roll but not be able to run when the hunger value falls below six. Also to prevent click-spamming it, as it's easy to die.

Crash on launch

Minecraft version - 1.19.2
Mod loader - Forge
Mod version - 1.0.7
I am using the latest version available - Yes

Describe the bug
Once I added the mod to my modpack and tried to start the modpack, it unexpectedly crashed. I have the latest versions of the dependencies, and I cannot figure out why this happens. Here's the crash report.

crash-2022-10-07_17.10.13-fml.txt

1.20.1 Crashes When Loading A World

Any time I try to load a world with this mod in the mods folder, it gets to "Loading Textures" and then crashes and gives the crash message "Error: lava.lang.IllegalArgumentException: Can't find attribute combatroll:count" with the exit code 255. I am using Forge 1.20.1 with the latest version of the mod that is available on Forge 1.20.1.

Crash on world loading: Can't find attribute combatroll:count

Minecraft version - 1.19.4
Mod loader - Fabric
Mod version - 1.15

Describe the bug
Crash on creating a new world; Error: java.lang.IllegalArgumentException: Can't find attribute combatroll:count
Seems as though the entity attribute wasn't registered, possibly due to a conflict with another library.

Installed libs
player-animation-lib
owo-lib
libIPN
iceberg
geckolib
CorgiLib
cardinal-components-api

Error message
java.lang.IllegalArgumentException: Can't find attribute combatroll:count
at net.minecraft.class_5132.method_26865(class_5132.java:22)
at net.minecraft.class_5132.method_26862(class_5132.java:28)
at net.minecraft.class_5131.method_26852(class_5131.java:76)
at net.minecraft.class_1309.method_26825(class_1309.java:1881)
at net.combatroll.api.EntityAttributes_CombatRoll.getAttributeValue(EntityAttributes_CombatRoll.java:52)
at net.combatroll.client.RollManager.tick(RollManager.java:55)
at net.minecraft.class_310.tryRolling(class_310.java:3553)
at net.minecraft.class_310.handler$zho000$combatroll$tick_TAIL(class_310.java:3545)
at net.minecraft.class_310.method_1574(class_310.java:1958)
at net.minecraft.class_310.method_1523(class_310.java:1180)
at net.minecraft.class_310.method_1514(class_310.java:801)
at net.minecraft.client.main.Main.main(Main.java:237)

Crash on terrain generation with this and Simply Skills together

Minecraft version - 1.20.1
Mod loader - Quilt 0.21.1
Mod version - 1.3.0
I am using the latest version available - Yes

Describe the bug
The game crashes on finishing terrain generation, this only started after installing Simply Skills: https://www.curseforge.com/minecraft/mc-mods/simply-skills. Already reported there and was told to report it here since the log isn't Simply skills related.

To Reproduce
Steps to reproduce the behavior:

1. Start a world, wait on terrain generation.
2. Crash

Expected behavior
No crashes on generating terrain

Screenshots or video recordings
Will add screenshots if it becomes necessary

Additional context
crash-2023-11-10_21.22.03-client.txt

Feature request: Roll when double-tapping left, right or back.

I read project readme, checked client side and server side configurations, and no such feature exists - YES

Is your feature request related to a problem? Please describe.
Nope!

Describe the solution you'd like
When sprinting was active in the last half second, double-tapping a movement key will roll in the key's direction.

Describe alternatives you've considered
Stuffing my keyboard with even more confusing keys from a bunch of mods, probably.

Additional context
Removes the need for a dedicated keybind to activate a roll. Double-tapping a movement key to roll emulates the movement behavior seen in games such as Unreal Tournament.

In some instances you may need to press the keys four times to activate a roll (two forward to start sprinting, two backward to roll back and adjusting your view). This is preferable to having an additional keybind to keep track of.
Rolling should not occur until a player has begun sprinting. The existing keybind will work as normal regardless of sprint state.

crash minecraft 1.18.2 when entering world or server of mine

Minecraft version - ? Minecraft 1.18.2
Mod loader - ? forge 40.2.9
Mod version - ? combat roll 1.1.5+1.18.2
I am using the latest version available - ? Yes

Describe the bug
after i uninstalled pufferfish skills mod ,quark ,quark,oddities, whenever i tried to create new world or join server minecraft just crash and not enough crash mod show that combat roll have identified as potential crash.

To Reproduce
Steps to reproduce the behavior:

1. install the mod i mention above
2. enter minecraft
3. join server or world i created
4. See error

Expected behavior
working i guess

Screenshots or video recordings

crash-2023-08-11_15.29.52-client.txt

Additional context
the combat roll mod working with no issue before i installed pufferfish skills mod ,quark ,quark,oddities.
i suspect pufferfish skills might have to with this and all the mod is up to date.

allow_rolling_while_weapon_cooldown doesnt work

Minecraft version - 1.20.1
Mod loader - Forge
Mod version - 1.3.0
I am using the latest version available - Yep

Describe the bug

    "allow_rolling_while_weapon_cooldown": true,

This option in the config doesn't work. Even when I set this to true, I can't roll while my sword is on cooldown.

To Reproduce
Steps to reproduce the behavior:

1. set the allow_rolling_while_weapon_cooldown setting in the config file to true
2. go in minecraft and left click with a sword
3. attempt to roll on the weapon cooldown (it doesnt work)

Expected behavior
you roll whie you are on your weapon cooldown

Screenshots or video recordings
These are the mods im using


Additional context

Incompatibility with mod Immersiveweathering

Minecraft version - 1.19
Mod loader - Fabric 0.14.9
Mod version - 1.0.4
I am using the latest version available - yes

Describe the bug
Incompatibility with mod Immersiveweathering

To Reproduce
Steps to reproduce the behavior:
Opening minecraft and hitting play

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots or video recordings
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

latest.log

[Feature Request] Allow Some Actions to Happen Out of a Roll, to Allow Smoother Transitions for Traversial

I read project readme, checked client side and server side configurations, and no such feature exists- YES

Currently, while very powerful, the combat roll has a decent bit of ending lag. This is a good balancing method, but also makes it feel stiff for usage as a movement tool

Describe the solution you'd like
I would like some method to maintain some of the momentum of the roll, like the ability to jump out of the end of a roll (if still on the ground), with the jump having the horizontal speed (and potentially a lower amount of vertical distance on the jump). Preferably it would involve good timing to actually handle the jump and not able to be abuse with just holding the jump button. In addition to the small time-frame to do this, it could possibly modify the current cooldown recharge rate to be moderately slower after a roll-jump, Making it most tactical to use, and emphasizing the bonuses of the enchantments more.

Describe alternatives you've considered
Other ways to possibly balance this is by forcing this ability to be on an enchantment only, limiting the rarity (and allowing it to be mutually exclusive with other enchantments like cool down speed).

Other alternatives I thought of to help it feel like a good all-around mobility tool: maybe just shortening the small delay after the roll (for specific actions like jumping or when its interrupted like rolling into a wall, etc), but not giving those actions any special treatment (especially when rolling into a wall, where the distance is reduced anyways), or allowing a well timed roll to reduce fall damage some amount (a minuscule reduction), and gain bonus distance

Additional context
I like good mobility options that feel smooth and rewarding (even if they are not actually rewarding), and was a fan of smart moving when that was still updated, and overall good platformer-esque movement when possible, as it can be very satisfying learning and mastering the techniques. The combat roll asis is there as one of these techniques, but has smaller things that I believe could make it feel more dynamic with how to use it in other ways.

Server setting "allow_rolling_while_weapon_cooldown" not functional when used with Better Combat

Minecraft version - 1.20.1
Mod loader - Fabric
Mod version - 1.3.0
I am using the latest version available - ?

Describe the bug
The server config setting "allow_rolling_while_weapon_cooldown" has no effect (while used with Better Combat).
This was tested on the "Prominence II" Modpack.

To Reproduce
Steps to reproduce the behavior:

1. Install Prominence II Modpack on CurseForge.
2. Set "allow_rolling_while_weapon_cooldown" to true
3. Go ingame and attack with weapon
4. Try to roll during attack
5. Attack is not interrupted and roll is not performed

Expected behavior
I expected the attack to be interrupted with a roll.

Additional context
Sorry I couldnt test minimal working example
And also sorry if this is intended behaviour
But I would also really like to be able to cancel my attacks with the roll
It would make it feel really nice

Feature Request: Can cross 1 block hight

I read project readme, checked client side and server side configurations, and no such feature exists - YES/NO

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Add Fall Recovery (roll to reduce fall damage and nullify trip damage)

I read project readme, checked client side and server side configurations, and no such feature exists - Kind of… I haven't used the mod because I don't need a combat roll, but I figured since this mod already adds a roll function, this feature could be implemented into the existing one instead of creating a new mod or expansion.

Is your feature request related to a problem? Please describe.
In the mod description, it mentions that Roll ability can only be used when player is: not using item, not jumping, not swimming.

Describe the solution you'd like
While I agree the combat roll should not be performed while jumping (to avoid aerial front-flips), perhaps it can be used on the descent, so it is only available to use mid-air when a player falls a certain distance (namely the distance that would cause damage) or when there is a certain range of space between the player and the ground beneath them when they begin their descent– whatever seems the most balanced.

Describe alternatives you've considered
I thought to look for parachutes, which could save a player in the event that they fall with it equipped, but I feel like that's much more planned ahead, whereas a combat roll is something practical that can be done with no equipment. The current vanilla alternative is placing water, which nullifies all fall damage and is a stupidly cheap trick, but I want something more practical: a maneuver, not a tool.

Additional context
In real life, it only helps reduce injury by only a small amount, dissipating the damage to not cause the whole body to absorb the impact. That said, I imagine this could nullify damage from 'trips' (gentle drops) in the game if timed properly.
Rolling into a cleaner landing should probably cause additional wear to all equipment worn.

Less than 3 blocks roll distance

I read project readme, checked client side and server side configurations, and no such feature exists - YES

Is your feature request related to a problem? Please describe.
I'd like to set roll distance to one less than the default.

Describe the solution you'd like
Ability to set the roll distance rather than additional roll distance.

Describe alternatives you've considered
Just use the default of 3.

Thanks!

[Bug report] combatroll:count 0 allows one roll

Minecraft version - 1.19.2
Mod loader - Fabric 0.14.10
Mod version - 1.0.8
I am using the latest version available - yes.

Describe the bug
Setting attribute combatroll:count to 0 is the same as setting it to 1 (default).

To Reproduce
Steps to reproduce the behavior:

1. Run command /attribute @s combatroll:count base set 0
2. Attempt to roll.

Expected behavior
Doing this should take away player's ability to roll.

Reduce roll range in liquid.

I read project readme, checked client side and server side configurations, and no such feature exists - YES

Is your feature request related to a problem? Please describe.
Combat roll in water is odd.

Describe the solution you'd like
Reduce the roll range in water and lava to simulate resistance.

[Feature request] Enchantment tweaks

I read project readme, checked client side and server side configurations, and no such feature exists
Yes.

Describe the solution you'd like

1. Add an ability to disable enchantments in the configuration. Even better if there's an option to choose which enchantments to keep.
2. Combine Acrobat's Shirt and Acrobat's Pants into one enchantment Acrobat that can be applied to both chestplate and leggings. Having two enchantments with the same functionality is redundant.
3. Rename Multi-Roll to Multiroll for parity with vanilla enchantment Multishot.

cloth config window in mods menu crashes 1.18.2

Minecraft version - 1.18.2
Mod loader - fabric 0.14.9
Mod version 1.0.8
I am using the latest version available - for this version, yes

Describe the bug
cloth config window in mods menu crashes 1.18.2

go to mods menu and then click on roll combat then to the config button

Expected behavior
no crash

https://aofpaste.com/ogacibewey.yaml

CombatRoll mod crashing upon launch.

Minecraft version - 1.20.1
Mod Loader - Forge 47.2.19
Mod Version - 1.3.0
I am using the latest version available - Yes.

Describe the bug
(My english is not that good, so expect grammar fails)
I enter the launcher, with the mod on "mods" folder, and the game crashes on Minecraft loading screen, sending the error code 1.
This way i know the mods are the problem and not anything else.

I have tried:

• Putting every mod one by one to see which one is the problem to initiate. This way i discovered that 2 mods were the problem.
• Tried initiating without that mod. It launches successfully but, obviously, without the mod. Tried both empty folder and filled with mods i prepared and both worked.
• Launched with ONLY the mod, but the game crashed and sent me error code 1 again.

To Reproduce
Just initiate the game with the mod in, and it causes the error.

Expected behavior
I expected the launcher to, well, launch and play the modpack i made.

Screenshots or video recordings
No need.

Additional context
"Latest" filed in.
latest.log

If needed, i'll fill up with other files so the problem can be solved quickly.

New config option

I read project readme, checked client side and server side configurations, and no such feature exists - YES

Simple but powerful - configuration for the combat roll to be initially locked and players would need a book to learn it or an enchantment to unlock it.

Thanks for the mod :)