10up / retro-winamp-block Goto Github PK
View Code? Open in Web Editor NEWA Winamp-styled audio block for all your retro music player needs.
Home Page: https://wordpress.org/plugins/retro-winamp-block
License: GNU General Public License v2.0
A Winamp-styled audio block for all your retro music player needs.
Home Page: https://wordpress.org/plugins/retro-winamp-block
License: GNU General Public License v2.0
No response
No response
Base set of skins via Winamp Skin Museum:
Inspiration for custom skin(s):
Details on creating skins:
Easiest approach is probably extracting an existing skin, seeing what components it is made with, and then ensuring we're able to cut up any custom design into those relevant components (which are described in the two PDFs above).
Is your enhancement related to a problem? Please describe.
From @dkotter in #6:
Do we want to style the individual Audio blocks differently? I'd love to have these show up more as a playlist, with song title and artist but currently the Audio block doesn't store that information. This could be a reason to add our own custom block instead of using the core block (otherwise maybe some filtering would be needed)
Describe the solution you'd like
Review the work in #6, the current state of the develop
branch, and what approach should (if any) be taken to resolve this issue.
Designs
Describe alternatives you've considered
Additional context
Is your enhancement related to a problem? Please describe.
From @dkotter in #6:
The WinAmp player is meant to be moved around the page, which is fine though does get weird in the admin (I don't see any option to turn this off). But currently having a bigger issue (I'm guessing some styling conflict with core Gutenberg styles) where the player scrolls with the window. This needs fixed but I couldn't figure it out
Describe the solution you'd like
Review the work in #6, the current state of the develop
branch, and what approach should (if any) be taken to resolve this issue.
Designs
Describe alternatives you've considered
Additional context
Is your enhancement related to a problem? Please describe.
This is probably best left as a block setting and not something we'd need to worry about supporting on the site front-end. We should be able to test with available skins in the Winamp Skin Museum, but will want to determine if the way the webamp player works is that it expects skins to be in the Winamp Skin Museum or if they can be provided from within the same domain that the webamp player is rendered on (i.e., the site this plugin will be installed on and thus whether the plugin needs to be bundled with the skins or if the skins can be selected / linked from the Winamp Skin Museum).
Describe the solution you'd like
Designs
See #1
Describe alternatives you've considered
Only provide initial support for a single, default skin.
Additional context
n/a
More info: 10up/convert-to-blocks#123 (comment)
Is your enhancement related to a problem? Please describe.
See overall concept in the OSBP guide and example setups on Simple Podcasting, Restricted Site Access, and 10up/ElasticPress#2446.
Describe the solution you'd like
Designs
n/a
Describe alternatives you've considered
n/a
Additional context
https://github.com/10up/cypress-wp-setup/ && https://github.com/10up/cypress-wp-utils will be helpful in getting this spun up and some initial test commands to leverage.
Describe the bug
From @dinhtungdu in #6 (review):
The block works with audio files in the library. But it doesn't work if I upload the media file directly. I think that should be fixed because it's a bug, other enhancements can be implemented later.
Steps to Reproduce
Expected behavior
Screenshots
Environment information
Additional context
This issue is for tracking changes for the 1.2.0 release. Target release date: 25th January 2023.
develop
, cut a release branch named release/1.2.0
for your changes.package-lock.json
, package.json
, readme.txt
, and retro-winamp-block.php
if it does not already reflect the version being released.CHANGELOG.md
and readme.txt
.CREDITS.md
with any new contributors, confirm maintainers are accurate..distignore
.README.md
is geared toward GitHub and readme.txt
contains WordPress.org-specific content. The two are slightly different.develop
(or merge the pull request), then do the same for develop
into trunk
(git checkout trunk && git merge --no-ff develop
). trunk
contains the stable development version.trunk
to be sure it functions correctly. Don't forget to build.trunk
branch to GitHub (e.g. git push origin trunk
).trunk
branch. Paste the changelog from CHANGELOG.md
into the body of the release and include a link to the closed issues on the milestone.Due date (optional)
field) and link to GitHub release (in the Description
field), then close the milestone.X.Y.Z
do not make it into the release, update their milestone to 2.0.0
, 1.3.0
, 1.2.1
, or Future Release
No response
No response
This is to align with the current tooling versions used by WordPress - https://make.wordpress.org/core/2023/12/20/updating-wordpress-to-use-more-modern-versions-of-node-js-npm-2/
To allow for IDEs to pick up the phpcs config automatically, it would be lovely to add a .phpcs.xml.dist
file to the root directory.
From 10up/simple-page-ordering
<?xml version="1.0"?>
<ruleset name="Project Rules">
<rule ref="10up-Default" />
</ruleset>
N/A
N/A
There is a new WordPress version that the plugin hasn't been tested with. Please test it and then change the "Tested up to" field in the plugin readme.
Tested up to: 6.4
Latest version: 6.5
This issue will be closed automatically when the versions match.
Is your enhancement related to a problem? Please describe.
From @dkotter in #6:
On the FE, right now it renders out the audio players and then those get replaced with the WebAmp player. Thinking some basic styling here where those players get hidden and maybe some sort of placeholder container, so once the player loads in it's not shifting the page contents around
Describe the solution you'd like
Review the work in #6, the current state of the develop branch, and what approach should (if any) be taken to resolve this issue.
Designs
Describe alternatives you've considered
Additional context
The plugin includes a requirements check to ensure the PHP version installed is above PHP 7.4
Due to the return type definition on the function for the minimum supported version of PHP the plugin throws a fatal error on older versions of PHP
retro-winamp-block/retro-webamp-block.php
Lines 27 to 29 in 64a1e66
I suggest:
[19-Sep-2023 00:16:41 UTC] PHP Parse error: syntax error, unexpected ':', expecting '{' in /vagrant/content/plugins/retro-winamp-block/retro-webamp-block.php on line 27
[19-Sep-2023 00:16:41 UTC] PHP Stack trace:
[19-Sep-2023 00:16:41 UTC] PHP 1. {main}() /vagrant/wp-build/wp-admin/plugins.php:0
[19-Sep-2023 00:16:41 UTC] PHP 2. require_once() /vagrant/wp-build/wp-admin/plugins.php:10
[19-Sep-2023 00:16:41 UTC] PHP 3. require_once() /vagrant/wp-build/wp-admin/admin.php:34
[19-Sep-2023 00:16:41 UTC] PHP 4. require_once() /vagrant/wp-build/wp-load.php:55
[19-Sep-2023 00:16:41 UTC] PHP 5. require_once() /vagrant/wp-config.php:146
No response
WordPress 6.2
PHP 5.6
Bump WP & PHP Minimums to the following
This issue is for tracking changes for the 1.0.1 release. Target release date: 8 December 2021.
develop
, cut a release branch named release/1.0.1
for your changes.package-lock.json
, package.json
, readme.txt
, and retro-webamp-block.php
if it does not already reflect the version being released.CHANGELOG.md
and readme.txt
.CREDITS.md
file with any new contributors, confirm maintainers are accurate..distignore
.README.md
is geared toward GitHub and readme.txt
contains WordPress.org-specific content. The two are slightly different.develop
(or merge the pull request), then do the same for develop
into trunk
(git checkout trunk && git merge --no-ff develop
). trunk
contains the stable development version.trunk
branch to GitHub (e.g. git push origin trunk
).trunk
branch. Paste the changelog from CHANGELOG.md
into the body of the release and include a link to the closed issues on the milestone.Due date (optional)
field) and link to GitHub release (in the Description
field), then close the milestone.1.0.1
do not make it into the release, update their milestone to1.1.0
or Future Release
.As discussed in #116 (comment) (and further in that PR), let's discuss the following:
Audio List
to Preview Player
within the editor so that an author/editor can see how the player would load on the frontend?Audio List
/ Preview Player
toggle is better handled outside the block toolbar and instead in the block sidebar panel settings pane?n/a
No response
When WinAmp plugin is active, the post could not be saved in WordPress 5.8 with the error Publishing failed.
Also, it's not possible to open any existing post for edit:
There has been a critical error on this website. Please check your site admin email inbox for instructions.
Works fine with the current WordPress 6.1.1 and 6.2-RC
No response
No response
This issue is for tracking changes for the 1.1.0 release. Target release date: 8 December 2021.
develop
, cut a release branch named release/1.1.0
for your changes.package-lock.json
, package.json
, readme.txt
, and retro-webamp-block.php
if it does not already reflect the version being released.CHANGELOG.md
and readme.txt
.CREDITS.md
file with any new contributors, confirm maintainers are accurate..distignore
.README.md
is geared toward GitHub and readme.txt
contains WordPress.org-specific content. The two are slightly different.develop
(or merge the pull request), then do the same for develop
into trunk
(git checkout trunk && git merge --no-ff develop
). trunk
contains the stable development version.trunk
branch to GitHub (e.g. git push origin trunk
).trunk
branch. Paste the changelog from CHANGELOG.md
into the body of the release and include a link to the closed issues on the milestone.Due date (optional)
field) and link to GitHub release (in the Description
field), then close the milestone.1.1.0
do not make it into the release, update their milestone to1.2.0
or Future Release
.hi thanks so much for this plugin! I'm coming across an issue of my page loading at the bottom (where the player is located) but I need the page to load at the top. Do you know what I could do to fix this?
Once the following are completed:
... we can then work to update the support level for this plugin from Active to Stable as we can generally consider the optimal feature set of the plugin complete. Tasks to complete this change:
n/a
n/a
This issue is for tracking changes for the 1.3.0 release. Target release date: TBD.
develop
, cut a release branch named release/1.3.0
for your changes.package-lock.json
, package.json
, readme.txt
, and retro-winamp-block.php
if it does not already reflect the version being released.CHANGELOG.md
and readme.txt
.CREDITS.md
with any new contributors, confirm maintainers are accurate..distignore
.README.md
is geared toward GitHub and readme.txt
contains WordPress.org-specific content. The two are slightly different.develop
(or merge the pull request), then do the same for develop
into trunk
(git checkout trunk && git merge --no-ff develop
). trunk
contains the stable development version.trunk
to be sure it functions correctly. Don't forget to build.trunk
branch to GitHub (e.g. git push origin trunk
).trunk
branch. Paste the changelog from CHANGELOG.md
into the body of the release and include a link to the closed issues on the milestone.Due date (optional)
field) and link to GitHub release (in the Description
field), then close the milestone.X.Y.Z
do not make it into the release, update their milestone to 2.0.0
, 1.4.0
, 1.3.1
, or Future Release
Is your enhancement related to a problem? Please describe.
Clicking the +
(Toggle block inserter) in the top left of the block editor and searching for Webamp you see the block and its associated description but a blank preview.
Describe the solution you'd like
Could we generate a preview image showing the base Winamp player to use in that slot (maybe just the player window and not the associated equalizer and playlist windows)?
Designs
Describe alternatives you've considered
Additional context
Is your enhancement related to a problem? Please describe.
Describe the solution you'd like
Designs
n/a
Describe alternatives you've considered
None
Additional context
Reference PR: 10up/autoshare-for-twitter#201
This issue is for tracking changes for the 1.3.1 release. Target release date: October 2023.
develop
, cut a release branch named release/1.3.1
for your changes.package-lock.json
, package.json
, readme.txt
, and retro-winamp-block.php
if it does not already reflect the version being released.CHANGELOG.md
and readme.txt
.CREDITS.md
with any new contributors, confirm maintainers are accurate..distignore
.README.md
is geared toward GitHub and readme.txt
contains WordPress.org-specific content. The two are slightly different.develop
(or merge the pull request), then do the same for develop
into trunk
ensuring you pull the most recent changes into develop
first (git checkout develop && git pull origin develop && git checkout trunk && git merge --no-ff develop
). trunk
contains the stable development version.trunk
branch to GitHub (e.g. git push origin trunk
).trunk
to develop
to ensure no additional changes were missed.trunk
branch. Paste the changelog from CHANGELOG.md
into the body of the release and include a link to the closed issues on the milestone.Due date (optional)
field) and link to GitHub release (in the Description
field), then close the milestone.1.3.1
do not make it into the release, update their milestone to 1.3.2
, 1.4.0
, or Future Release
Once I add the Winamp Block in the editor and try to preview the Winamp Player in the editor I get a few console errors.
Screen Recording:
https://share.getcloudapp.com/lluE8rB1
Macbook: 12.3.1
Google Chrome: Version 100.0.4896.127 (Official Build) (x86_64)
`
version: 5.9.3
site_language: en_US
user_language: en_US
timezone: +00:00
permalink: /%postname%/
https_status: true
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: open
environment_type: production
user_count: 1
dotorg_communication: true
wordpress_path: /var/www/html
wordpress_size: loading...
uploads_path: /var/www/html/wp-content/uploads
uploads_size: loading...
themes_path: /var/www/html/wp-content/themes
themes_size: loading...
plugins_path: /var/www/html/wp-content/plugins
plugins_size: loading...
database_size: loading...
total_size: loading...
db.php: true
name: Twenty Twenty-One (twentytwentyone)
version: 1.4 (latest version: 1.5)
author: the WordPress team
author_website: https://wordpress.org/
parent_theme: none
theme_features: core-block-patterns, widgets-block-editor, automatic-feed-links, title-tag, post-formats, post-thumbnails, menus, html5, custom-logo, customize-selective-refresh-widgets, wp-block-styles, align-wide, editor-styles, editor-style, editor-font-sizes, custom-background, editor-color-palette, editor-gradient-presets, responsive-embeds, custom-line-height, experimental-link-color, custom-spacing, custom-units, widgets
theme_path: /var/www/html/wp-content/themes/twentytwentyone
auto_update: Disabled
10up Theme: version: 0.1.0, author: 10up, Auto-updates disabled
Astra: version: 3.7.3, author: Brainstorm Force (latest version: 3.7.10), Auto-updates disabled
Newspack Joseph: version: 1.50.0, author: Automattic, Auto-updates disabled
Newspack Katharine: version: 1.50.0, author: Automattic, Auto-updates disabled
Newspack Nelson: version: 1.50.0, author: Automattic, Auto-updates disabled
Newspack Sacha: version: 1.50.0, author: Automattic, Auto-updates disabled
Newspack Scott: version: 1.50.0, author: Automattic, Auto-updates disabled
Newspack: version: 1.50.0, author: Automattic, Auto-updates disabled
Twenty Twenty: version: 1.8, author: the WordPress team (latest version: 1.9), Auto-updates disabled
Twenty Twenty-Two: version: 1.1, author: the WordPress team, Auto-updates disabled
10up Plugin Scaffold: version: 0.1.0, author: 10up
Ad Refresh Control: version: 1.0.5, author: 10up, Auto-updates disabled
ClassifAI: version: 1.7.0, author: 10up, Auto-updates disabled
Debug Bar: version: 1.1.2, author: wordpressdotorg, Auto-updates disabled
Insert Special Characters: version: 1.0.3, author: 10up (latest version: 1.0.4), Auto-updates disabled
Query Monitor: version: 3.8.1, author: John Blackbourn (latest version: 3.9.0), Auto-updates disabled
Retro Winamp Block: version: 1.0.1, author: 10up, Auto-updates disabled
Akismet Anti-Spam: version: 4.1.12, author: Automattic (latest version: 4.2.2), Auto-updates disabled
Block for Apple Maps: version: 1.0.1, author: 10up (latest version: 1.0.2), Auto-updates disabled
Hello Dolly: version: 1.7.2, author: Matt Mullenweg, Auto-updates disabled
Insecure Content Warning: version: 1.0.0, author: 10up (latest version: 1.0.1), Auto-updates disabled
Publisher Media Kit: version: 1.0.0, author: 10up (latest version: 1.1.0), Auto-updates disabled
Simple Podcasting: version: 1.2.0, author: 10up (latest version: 1.2.2), Auto-updates disabled
image_editor: WP_Image_Editor_Imagick
imagick_module_version: 1692
imagemagick_version: ImageMagick 6.9.12-19 Q16 x86_64 2021-07-18 https://imagemagick.org
imagick_version: 3.5.1
file_uploads: File uploads is turned off
post_max_size: 150m
upload_max_filesize: 150m
max_effective_size: 150 MB
max_file_uploads: 20
imagick_limits:
imagick::RESOURCETYPE_AREA: 12 GB
imagick::RESOURCETYPE_DISK: 9.2233720368548E+18
imagick::RESOURCETYPE_FILE: 786432
imagick::RESOURCETYPE_MAP: 12 GB
imagick::RESOURCETYPE_MEMORY: 6 GB
imagick::RESOURCETYPE_THREAD: 1
imagemagick_file_formats: 3FR, 3G2, 3GP, AAI, AI, APNG, ART, ARW, AVI, AVS, BGR, BGRA, BGRO, BIE, BMP, BMP2, BMP3, BRF, CAL, CALS, CANVAS, CAPTION, CIN, CIP, CLIP, CMYK, CMYKA, CR2, CR3, CRW, CUR, CUT, DATA, DCM, DCR, DCX, DDS, DFONT, DNG, DOT, DPX, DXT1, DXT5, EPDF, EPI, EPS, EPS2, EPS3, EPSF, EPSI, EPT, EPT2, EPT3, ERF, EXR, FAX, FILE, FITS, FRACTAL, FTP, FTS, G3, G4, GIF, GIF87, GRADIENT, GRAY, GRAYA, GROUP4, GV, H, HALD, HDR, HISTOGRAM, HRZ, HTM, HTML, HTTP, HTTPS, ICB, ICO, ICON, IIQ, INFO, INLINE, IPL, ISOBRL, ISOBRL6, J2C, J2K, JBG, JBIG, JNG, JNX, JP2, JPC, JPE, JPEG, JPG, JPM, JPS, JPT, JSON, K25, KDC, LABEL, M2V, M4V, MAC, MAGICK, MAP, MASK, MAT, MATTE, MEF, MIFF, MKV, MNG, MONO, MOV, MP4, MPC, MPG, MRW, MSL, MSVG, MTV, MVG, NEF, NRW, NULL, ORF, OTB, OTF, PAL, PALM, PAM, PANGO, PATTERN, PBM, PCD, PCDS, PCL, PCT, PCX, PDB, PDF, PDFA, PEF, PES, PFA, PFB, PFM, PGM, PGX, PICON, PICT, PIX, PJPEG, PLASMA, PNG, PNG00, PNG24, PNG32, PNG48, PNG64, PNG8, PNM, POCKETMOD, PPM, PREVIEW, PS, PS2, PS3, PSB, PSD, PTIF, PWP, RADIAL-GRADIENT, RAF, RAS, RAW, RGB, RGBA, RGBO, RGF, RLA, RLE, RMF, RW2, SCR, SCT, SFW, SGI, SHTML, SIX, SIXEL, SPARSE-COLOR, SR2, SRF, STEGANO, SUN, SVG, SVGZ, TEXT, TGA, THUMBNAIL, TIFF, TIFF64, TILE, TIM, TTC, TTF, TXT, UBRL, UBRL6, UIL, UYVY, VDA, VICAR, VID, VIDEO, VIFF, VIPS, VST, WBMP, WEBM, WEBP, WMF, WMV, WMZ, WPG, X, X3F, XBM, XC, XCF, XPM, XPS, XV, XWD, YCbCr, YCbCrA, YUV
gd_version: 2.2.5
gd_formats: GIF, JPEG, PNG, WebP, BMP, XPM
ghostscript_version: not available
server_architecture: Linux 5.10.76-linuxkit x86_64
httpd_software: nginx/1.21.1
php_version: 7.3.29 64bit
php_sapi: fpm-fcgi
max_input_variables: 1000
time_limit: 30
memory_limit: 128M
admin_memory_limit: 256M
max_input_time: 60
upload_max_filesize: 150m
php_post_max_size: 150m
curl_version: 7.61.1 OpenSSL/1.1.1g
suhosin: false
imagick_availability: true
pretty_permalinks: true
extension: mysqli
server_version: 10.3.32-MariaDB-1:10.3.32+maria~focal
client_version: mysqlnd 5.0.12-dev - 20150407 -
max_allowed_packet: 16777216
max_connections: 100
WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /var/www/html/wp-content
WP_PLUGIN_DIR: /var/www/html/wp-content/plugins
WP_MEMORY_LIMIT: 40M
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_ENVIRONMENT_TYPE: Undefined
DB_CHARSET: utf8
DB_COLLATE: undefined
wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable
mu-plugins: writable
0: 1.7.0
1: no
2: undefined
3:
Configured: no
API URL:
API username:
Post types:
Features: {"category":null, "keyword":null, "entity":null, "concept":null}
Latest response: N/A
4:
Authenticated: no
API URL:
Caption threshold: 75
Latest response - Image Scan: N/A
Latest response - Smart Cropping: N/A
Latest response - OCR: N/A
`
Is your enhancement related to a problem? Please describe.
From @dkotter in #6:
I had debated on when the WebAmp player should load: if we only show that when the block isn't selected; if we have a preview toggle like some other core blocks use that renders that; some other approach? Right now that will render as soon as media items have been added, whether the block is selected or not. Need to decide if that is the right approach
Describe the solution you'd like
Review the work in #6, the current state of the develop
branch, and what approach should (if any) be taken to resolve this issue.
Designs
Describe alternatives you've considered
Additional context
PR #56 introduced a minor bug which prevents the player from being visible during 'Preview'.
No response
No response
No response
Is your enhancement related to a problem? Please describe.
From @dkotter in #6:
You can currently select multiple audio files but you have to do the command+click or shift+click, otherwise it deselects whatever you have. There is an audio playlist media modal but as far as I can tell, that is not supported yet in the
mediaPlaceholder
component (you can get to this flow using the Classic block). This may be as good as it gets until support is added for that
Describe the solution you'd like
Review the work in #6, the current state of the develop
branch, and what approach should (if any) be taken to resolve this issue. This may require some upstream work in Gutenberg to enable further progress on this issue.
Designs
Describe alternatives you've considered
Additional context
There is a new WordPress version that the plugin hasn't been tested with. Please test it and then change the "Tested up to" field in the plugin readme.
Tested up to: 6.3
Latest version: 6.4
This issue will be closed automatically when the versions match.
Is your enhancement related to a problem? Please describe.
Once WordPress 6.0 is released, we'll want to test Retro Winamp Block to see if any incompatibility issues arise.
Describe the solution you'd like
Designs
n/a
Describe alternatives you've considered
none
Additional context
Related: #34
There are couple of items that can be improved with Winamp block:
Note: I think all the items I mentioned should not be a problem. But, just wanted to add my experience being a new user.
No response
No response
No response
There is a new WordPress version that the plugin hasn't been tested with. Please test it and then change the "Tested up to" field in the plugin readme.
Tested up to: 6.1
Latest version: 6.2
This issue will be closed automatically when the versions match.
Is your enhancement related to a problem? Please describe.
From @dkotter in #6:
Some weirdness between the audio blocks and the WebAmp player, where if you click the start button on the Audio block it seems to start the player instead (which may be fine) and if you remove an Audio block, it sometimes starts playing the next song in the player
Describe the solution you'd like
Review the work in #6, the current state of the develop branch, and what approach should (if any) be taken to resolve this issue.
Designs
Describe alternatives you've considered
Additional context
Could await for WordPress/gutenberg#805 to get skipped and style on top of that, or alternatively craft a playlist block specifically within this plugin.
There is a new WordPress version that the plugin hasn't been tested with. Please test it and then change the "Tested up to" field in the plugin readme.
Tested up to: 6.0
Latest version: 6.1
This issue will be closed automatically when the versions match.
Craft a plugin that styles the core audio block to make it look like the retro WinAmp player. Ship with a couple skins available to select as an option plus a custom color one (called βHelenβ perhaps). Can use some sample MP3 files to test within the core Audio block. Uncertain if we'd be able to get super fancy and pull in components from the captbaritone/webamp project. An item to consider is whether this would affect the styling of ALL audio blocks on a site or just a specific audio block (in which case this would have to be what a block style specific to that audio block or even a new block altogether?).
This issue is for tracking changes for the 1.0.0 release. Target release date: 18 November 2021.
develop
, cut a release branch named release/1.0.0
for your changes.webamp-block.php
, readme.txt
, and package.json
if it does not already reflect the version being released. Update both the plugin "Version:" property and the plugin WEBAMP_BLOCK_VERSION
constant in webamp-block.php
.CHANGELOG.md
and readme.txt
.CREDITS.md
file with any new contributors, confirm maintainers are accurate..distignore
.README.md
is geared toward GitHub and readme.txt
contains WordPress.org-specific content. The two are slightly different.develop
(or merge the pull request), then do the same for develop
into trunk
(git checkout trunk && git merge --no-ff develop
). trunk
contains the stable development version.trunk
branch to GitHub (e.g. git push origin trunk
).PAUSE, EXHALE
retro-winamp-block
, make repo public, re-enable GitHub Actions, double-check release instructions are accurate to new file names noting we can likely remove Wait For Build step, and ensure all actions that get triggered are passing :woot:trunk
branch. Paste the changelog from CHANGELOG.md
into the body of the release and include a link to the closed issues on the milestone.Due date (optional)
field) and link to GitHub release (in the Description
field), then close the milestone.1.0.0
do not make it into the release, update their milestone to1.1.0
or Future Release
.Is your enhancement related to a problem? Please describe.
From @dkotter in #6:
Drag and drop of media items isn't working properly. They upload fine but it breaks the block
Describe the solution you'd like
Review the work in #6, the current state of the develop branch, and what approach should (if any) be taken to resolve this issue.
Designs
Describe alternatives you've considered
Additional context
There is a new WordPress version that the plugin hasn't been tested with. Please test it and then change the "Tested up to" field in the plugin readme.
Tested up to: 6.2
Latest version: 6.3
This issue will be closed automatically when the versions match.
As noted by Justin Tadlock here: https://wptavern.com/a-throwback-to-the-past-retro-winamp-block?utm_source=rss&utm_medium=rss&utm_campaign=a-throwback-to-the-past-retro-winamp-block
If I had one wish for this plugin, it would be to see the addition of Milkdrop, the popular Winamp visualizer add-on.
We'll need to assess if this is available in Webamp and how that might render on mobile layouts, plus how you might change the various visualizations available (and whether that might be another block setting or not).
No response
Could play off Winamp historical design and utilize a β‘ icon within the plugin assets:
Describe the bug
After inserting the block and picking one or more audio files, I get the dreaded "this block has encountered an error" message and TypeError: l.__experimentalUseInnerBlocksProps is not a function
in my console. I have a feeling this is related to my particular install, specifically that I am on WP nightly and perhaps because I have Gutenberg active.
Steps to Reproduce
Expected behavior
A working block :)
Screenshots
Environment information
Additional context
Cypress 13 was recently released, and Cypress 12 contains some breaking changes as listed below. We need to update our tests to make them work with the latest version and fix any issues that may arise.
cypress
to 13.0.0 (or latest version at the time of working on this)@10up/cypress-wp-utils
to 0.2.0Cookies.defaults
with the new replacements.Cookies.defaults
and Cookies.preserveOnce
APIs have been removed. Use the new cy.session() command to preserve cookies between tests.No response
No response
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.