OverlayShaderProgram ignores "enableColorTransfers" and always converts overlay colors

[kleiren]

OverlayShaderProgram ignores "enableColorTransfers" and always converts overlay colors

[tof-tof]

The DefaultVideoFrameProcessorFactory setting you mention only controls the colors of the input's to the VideoFrameProcessor, i.e. the input frames from the EditedMediaItem, not the input to individual effects or there corresponding shader programs.

The OverlayEffect requires the input (video) frame to be in optical (aka linear) input colors so it can blend the overlay into the frame a linear color space, so since bitmaps are stored in electrical colors, we always to convert them to linear.

In future, we will support color management in the DefaultVideoFrameProcessor, which will allow shader programs to announce what input colors they expect and what output colors they produce so that the DefaultVideoFrameProcessor can automatically insert the needed color transfers between shader programs so that the input frame is in the correct color space when it's inputted into the shader program. Until that is implemented, it's up to the user to ensure that the effect's required color space and input frames color space is compatible.