Deprecate actions property in action thunk

[atlassian]

Deprecate actions property in action thunk

[albertogasparin]

We are going to remove the support in v2, for now we remove the documentation for it and publish Typescript types without support for it (as recursive types are not supported anyway so it was never going to work)

[joshuatvernon]

I'm actually fighting this right now to have optional/extendable state and actions.

I'd like to create a createStoreInstance function that accepts the state/actions but as generics that can have extra values or have values omitted.

Also, I made this recursive type in Typescript to do wrap a type and recursively make all it's properties partial. It works in the case of state 👍(and everywhere else I use it in my app) but not for actions 😕

export type RecursivePartial<T> = {
  [P in keyof T]?: RecursivePartial<T[P]>;
};

Any chance of being able to support this so I can do the following?

export const createStoreInstance = (
  initialState: RecursivePartial<State>,
  actions: RecursivePartial<Actions>,
  storeName: string
) => {
  return createStore<RecursivePartial<State>, RecursivePartial<Actions>>({
    initialState,
    actions,
    storeName
  });
};

Then I can call it like so

const {
  thing,
  ...otherInitialState
} = initialState;

const {
  getThing,
  ...otherActions
} = actions;

// Note: These will actually be in different repos all together (thus having the `getStoreInstance` in a common package they both import)
const store = createStoreInstance(initialState, actions, 'complete-store');
const store = createStoreInstance(otherInitialState, otherActions, 'reduced-store');

[albertogasparin]

Can you provide a code example (for instance on codesandbox)?
Also, this ticket is to deprecate the actions access in the thunk function ( const myAction = () => ({ actions }) => ... not sure the issue you are describing is related to that.
If not, please open a dedicated issue so we can better discuss the options

[albertogasparin]

As of v2.5.0 Flow Action does not accept Actions anymore. actions are still available in code but they will be typed to any (Typescript never supported it anyway).