Giter Site home page Giter Site logo

Comments (5)

albertogasparin avatar albertogasparin commented on July 20, 2024

Thanks for reporting the issue. Would you mind reproducing the bug in codesandbox.io, so it is much easier for us to understand what is happening?

On replacing the default setState implementation with immer, that could be done by overriding the default mutator:

// somewhere in your top/config import
import { defaults } from 'react-sweet-state'
import { produce } from 'immer';

defaults.mutator = (...args) => produce(...args);

The you call setState with a function instead of passing an object:

const actions = {
  increment: () => ({ setState }) => {
    setState(draft => {
      draft.count += 1;
    });
  },
};

from react-sweet-state.

 avatar commented on July 20, 2024

So the issue happened when using setState and only returning a partial state. This was fixed when using immerjs to return the entire state. However I was unable to use your suggested mutator because the TypeScript check fails. I was able to do:

const actions = {
  increment: () => ({ getState, setState }) => {
    const newState = produce(getState(), draft => {
      draft.count += 1;
    });
    setState(newState);
  },
};

from react-sweet-state.

albertogasparin avatar albertogasparin commented on July 20, 2024

Yeah, not sure how you can make TS happy as the signature of setState is different.
Wonder if you can override the type SetState of the library, as by doing so TS should pick up the different setState implementation

from react-sweet-state.

 avatar commented on July 20, 2024

The typing issue seems to lie in index.d.ts with:

const defaults: {
  devtools: boolean;
  middlewares: any;
  mutator: <TState>(
    prevState: TState,
    partialState: Partial<TState> // I believe this second argument could be more flexible, but haven't been able to get the typing right yet
  ) => TState;
};

I tried with no luck:

partialState: Partial<TState> | (<TState>(draftState: TState) => TState)

from react-sweet-state.

albertogasparin avatar albertogasparin commented on July 20, 2024

I think I've found a solution to properly allow custom mutator types to be correct. Would you mind checking #53, try following the docs that I added and see if that works?

from react-sweet-state.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.