Comments (5)
Thanks for reporting the issue. Would you mind reproducing the bug in codesandbox.io, so it is much easier for us to understand what is happening?
On replacing the default setState
implementation with immer
, that could be done by overriding the default mutator:
// somewhere in your top/config import
import { defaults } from 'react-sweet-state'
import { produce } from 'immer';
defaults.mutator = (...args) => produce(...args);
The you call setState
with a function instead of passing an object:
const actions = {
increment: () => ({ setState }) => {
setState(draft => {
draft.count += 1;
});
},
};
from react-sweet-state.
So the issue happened when using setState and only returning a partial state. This was fixed when using immerjs to return the entire state. However I was unable to use your suggested mutator because the TypeScript check fails. I was able to do:
const actions = {
increment: () => ({ getState, setState }) => {
const newState = produce(getState(), draft => {
draft.count += 1;
});
setState(newState);
},
};
from react-sweet-state.
Yeah, not sure how you can make TS happy as the signature of setState
is different.
Wonder if you can override the type SetState
of the library, as by doing so TS should pick up the different setState
implementation
from react-sweet-state.
The typing issue seems to lie in index.d.ts
with:
const defaults: {
devtools: boolean;
middlewares: any;
mutator: <TState>(
prevState: TState,
partialState: Partial<TState> // I believe this second argument could be more flexible, but haven't been able to get the typing right yet
) => TState;
};
I tried with no luck:
partialState: Partial<TState> | (<TState>(draftState: TState) => TState)
from react-sweet-state.
I think I've found a solution to properly allow custom mutator types to be correct. Would you mind checking #53, try following the docs that I added and see if that works?
from react-sweet-state.
Related Issues (20)
- The useHook with selector does not trigger rendering properly HOT 3
- [Documentation request] - Example with Next.js SSR
- Possibly incorrect type definition for `ActionThunk` HOT 2
- Incorrect selector behaviour with promises
- Input caret will jump to end of string when using store HOT 4
- better type/name for dispatched actions HOT 1
- Persistent global scoped stores HOT 2
- "Families" containers HOT 7
- Ability to pass callback function during store creation for store initialisation and updates HOT 3
- Non global states HOT 4
- Container cleanup occurs after remounting, clearing state set by onInit HOT 1
- Hook mount/unmount time depends at number of hooks on page HOT 1
- New major HOT 2
- Move from .js to .ts HOT 1
- Uncaught TypeError: Cannot read properties of null (reading 'unsubscribe') HOT 6
- Unstable scheduling behavior
- Unexpected change in behaviour beween React 17 and 18 HOT 14
- Discussion: Should an error in onUpdate trigger the container's error boundary? HOT 3
- Using container on update hook causes React 16 errors to be printed HOT 5
- createActions helper HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-sweet-state.