azerothcore/mod-solo-lfg

Solo LFG Module for use on AzerothCore 3.3.5a

mod-solo-lfg's Issues

Cant apply and build with recent AC

AC rev. 413f316b6c6fce05099e1330e57194a4d2f5334b

git apply modules/mod-solo-lfg/lfg-solo.patch
error: patch failed: src/server/game/DungeonFinding/LFGMgr.cpp:26
error: src/server/game/DungeonFinding/LFGMgr.cpp: patch does not apply

make error log

azerothcore/modules/mod-solo-lfg/src/Lfg_Solo.cpp:38:76: fatal error: no member named 'IsSoloLFG' in 'lfg::LFGMgr'
        if (sConfigMgr->GetBoolDefault("SoloLFG.Enable", true) != sLFGMgr->IsSoloLFG())
                                                                  ~~~~~~~  ^
1 error generated.
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:8554: src/server/scripts/CMakeFiles/scripts.dir/__/__/__/modules/mod-solo-lfg/src/Lfg_Solo.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1141: src/server/scripts/CMakeFiles/scripts.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Bug: Getting stuck in a group.

Current Behaviour

When you join a LFG solo and use port out, char get stuck been in a group. Server need a restart to fix it.

Expected Behaviour

Should not be in a group if you use port out.

Steps to reproduce the problem

Join a LFG solo and use port out.

Extra Notes

No response

AC rev. hash/commit

azerothcore/azerothcore-wotlk@f46cf867ad10

Operating system

Debain 12

Custom changes or Modules

List enable modules:

• mod-account-achievements
• mod-account-mounts
• mod-ah-bot
• mod-aoe-loot
• mod-autobalance
• mod-eluna
• mod-gain-honor-guard
• mod-guildhouse
• mod-learn-spells
• mod-npc-beastmaster
• mod-npc-services
• mod-pvp-titles
• mod-random-enchants
• mod-reagent_bank_account
• mod-reward-played-time
• mod-skip-dk-starting-area
• mod-solo-lfg
• mod-solocraft
• mod-starter-guild
• mod-transmog

On death you cannot return to the instance to get your body

When you die or teleport out of the dungeon you are removed from queue, if you are dead and enter the instance you are still dead and cannot retrieve your body.

Implement this into the core directly

After discussing this with several developers (Darkon, Diel, Yehonal), this module should be implemented into the core with configurable options. It's mostly about the .patch file

In top of that, we should be able to set a minimum amount of players required for the group size before being teleported to the dungeon AND a maximum amount of players as well.

EDIT: game/Groups/Group.h:30:#define MAXGROUPSIZE 5

Issue applying patch

git apply modules/mod-solo-lfg/lfg-solo.patch
error: patch failed: src/server/game/DungeonFinding/LFGMgr.h:534
error: src/server/game/DungeonFinding/LFGMgr.h: patch does not apply

Compile fail

see azerothcore/mod-transmog#54

Money not being looted.

Money isn't being looted. I can't find any reports of this issue, so I have no idea what's going on.

Patch broken since last Update/Commit of azerothcore

After an update to the current commit of azerothcore, apply the patch in docker doesn't work any more.

error: patch failed: src/Lfg_Solo.cpp:20
error: src/Lfg_Solo.cpp: patch does not apply

Thanks for advise ;-)

Docker - Error building acore

I'm getting an error, when attempting to rebuild acore after applying the patch after using git pull origin master.
After patching I'm starting ./acore.sh docker build but it says that the size of the precompiled header changed. I tried deleting the whole /var-forlder and using build:nocache... but no success. Now I'm running out of ideas.
Can someone help me?

fatal error: file '/azerothcore/src/server/game/DungeonFinding/LFGMgr.h' has been modified since the precompiled header '/azerothcore/var/build/obj/src/server/scripts/CMakeFiles/scripts.dir/cmake_pch.hxx.pch' was built: size changed
note: please rebuild precompiled header '/azerothcore/var/build/obj/src/server/scripts/CMakeFiles/scripts.dir/cmake_pch.hxx.pch'
1 error generated.
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:394: src/server/scripts/CMakeFiles/scripts.dir/Commands/cs_lfg.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1162: src/server/scripts/CMakeFiles/scripts.dir/all] Error 2

Error while Applying the LFG-Solo.patch

Hello,
trying to install the mod into a newly updated AzerothCore instance, using the:
git apply modules/mod-solo-lfg/lfg-solo.patch

I get the below errors:

error: patch failed: src/server/game/DungeonFinding/LFGMgr.cpp:26
error: src/server/game/DungeonFinding/LFGMgr.cpp: patch does not apply
error: patch failed: src/server/game/DungeonFinding/LFGQueue.cpp:285
error: src/server/game/DungeonFinding/LFGQueue.cpp: patch does not apply

Can you help me out? Thank you :-)

Failed to compile in VS2019

The module failed to compile in VS2019 with the errors
`
D:\AzerothCore\source\azerothcore-wotlk\modules\mod-solo-lfg\src\Lfg_Solo.cpp(44,27): error C2039: 'IsSoloLFG': is not a member of 'lfg::LFGMgr'
D:\AzerothCore\source\azerothcore-wotlk\src\server\game\DungeonFinding\LFGMgr.h(396): message : see declaration of 'lfg::LFGMgr'
D:\AzerothCore\source\azerothcore-wotlk\modules\mod-solo-lfg\src\Lfg_Solo.cpp(46,22): error C2039: 'ToggleSoloLFG': is not a member of 'lfg::LFGMgr'
D:\AzerothCore\source\azerothcore-wotlk\src\server\game\DungeonFinding\LFGMgr.h(396): message : see declaration of 'lfg::LFGMgr'

`

Docker build fails

1 error generated.
src/server/scripts/CMakeFiles/scripts.dir/build.make:13902: recipe for target 'src/server/scripts/CMakeFiles/scripts.dir////modules/mod-solo-lfg/src/Lfg_Solo.cpp.o' failed
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir////modules/mod-solo-lfg/src/Lfg_Solo.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [src/server/scripts/CMakeFiles/scripts.dir/all] Error 2
CMakeFiles/Makefile2:1329: recipe for target 'src/server/scripts/CMakeFiles/scripts.dir/all' failed
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

Does not work

This happened when try to queue, and nothing else

Tested on fresh acore build & fresh world server.

conflict

azerothcore/azerothcore-wotlk@a2b2627

solo-lfg incompatible with AzerothCore 4.0

Unfortunately, latest AC build breaks the lfg-solo.patch.

error: patch failed: src/server/game/DungeonFinding/LFGQueue.cpp:285
error: src/server/game/DungeonFinding/LFGQueue.cpp: patch does not apply

The underlying code for LFGQueue.cpp doesn't look like it's changed aside from a minor line change, however I'm unfamiliar with how git patches work so I'm currently unable to propose a way to make this patch work with the updated core.

Hopefully someone can help :)

Compilation failed: unused parameter 'player'

Hey,

the module doesnt compile on standard installation. the "docker fix" worked for me.

/home/azerothcore/azerothcore-wotlk/modules/mod-solo-lfg/src/Lfg_Solo.cpp:40:25: fatal error: unused parameter 'player' [-Wunused-parameter]

   void OnLogin(Player* player)

replace patch implementing some hooks on AC

Bug: using Dungeon Finder (LFG) solo

Current Behaviour

When you are soloing a dungeon using Dungeon Finder (LFG) and you die, you get removed from LFG and dungeon will reset. You can recover your body and start over the dungeon. Is this intended or bug?

Expected Behaviour

When your are soloing a dungeon using Dungeon Finder (LFG) and you die, you are not removed from LFG and dungeon will not reset. You can recover your body and continue with the dungeon.

Steps to reproduce the problem

1. Click on Dungeon Finder (LFG) and click Find Group
2. Click Enter Dungeon and you will enter a random dungeon
3. Kill some mobs to see progress
4. Die in the dungeon

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. 9a38978eb0f8+ 2023-09-05 09:42:08 +0000 (master branch) (Unix, RelWithDebInfo, Static)

Operating system

Ubuntu 22.04.4 (docker)

Custom changes or Modules

List enable modules:

• mod-ah-bot
• mod-autobalance
• mod-fireworks-on-level
• mod-gain-honor-guard
• mod-learn-spells
• mod-solo-lfg

Unable to apply patch to AC core files - patch failed

Hey all,

After the recent change in the code, I was pulling the most recent core updates as well as the recent update for lfg-solo.
Unfortunately now I‘m unable to apply the patch anymore after the recent updates.
I pulled the core and the solo-lfg files this morning
From https://github.com/azerothcore/azerothcore-wotlk

• branch master -> FETCH_HEAD
  1c43e6ac6..e7743fbeb master -> origin/master
  Updating 1c43e6ac6..e7743fbeb

From https://github.com/azerothcore/mod-solo-lfg

• branch master -> FETCH_HEAD
  307d9a7..af1365f master -> origin/master
  Updating 307d9a7..af1365f

Error:

azerothcore-wotlk % git apply modules/mod-solo-lfg/lfg-solo.patch
error: patch failed: src/server/game/DungeonFinding/LFGMgr.h:532
error: src/server/game/DungeonFinding/LFGMgr.h: patch does not apply
error: patch failed: src/server/game/DungeonFinding/LFGQueue.cpp:285
error: src/server/game/DungeonFinding/LFGQueue.cpp: patch does not apply

Did I do something wrong or is the patch not working as intended?

Bug: Wrong dungeon type 0 for dungeon 0

Current Behaviour

After using the Dungeon Finder tool, subsequent dungeons result in the error "Wrong dungeon type 0 for dungeon 0" in the worldserver console. Will also see something similar to "LFGQueue::AddToQueue: Queue data not found for [GUID Full: 0x1f5000000000000b Type: Group Low: 11]" pop up in the worldserver console.

Expected Behaviour

Subsequent queues should allow player to queue with less than 5 players. This feature was previously working, but after updating AzerothCore with the most recent updates on 12/3, the LFG tool has been generating these errors.

Steps to reproduce the problem

1. Use Dungeon Finder tool solo.
2. Teleport out of the dungeon.
3. Attempt to queue for another dungeon.

Extra Notes

Restarting the worldserver fixes the issue, but it is unrealistic to do this every time it happens, especially on a server with other players playing.

AC rev. hash/commit

azerothcore/azerothcore-wotlk@eb1ecc38a5a3

Operating system

Windows Server 2022 Standard

Custom changes or Modules

• BreakingNewsOverride
• mod-solo-lfg
• mod-solocraft
• mod-weekendbonus
• All professions available (edit of worldserver configuration file)

Update to lates Core and fix #16 [30$]

Update this Module to latest Core and fix #16

Azerothcore PR #7008 breaks the patch provided.

As the title, now that LFGMgr.cpp has seen a change via Pull request #7008, the patch will no longer apply, effectively breaking mod-solo-lfg.