Comments (7)
@Contental SV have usable constructs (unique/priority) to deal with this kind of ambiguity.
https://www.verilogpro.com/systemverilog-unique-priority/
Interesting, this is actually the first time I have come across a mux being done this way after 3 years in the industry.
from cores-veer-eh1.
I'm not the designer of this core, but an and-or mux like this should be cheaper if you know that certain conditions can't occur. In this case it seems to take advantage of the fact that fetch_to_f1 and shift_f2_f1 can't be asserted at the same time
from cores-veer-eh1.
I see, that make sense. But I feel like there should be some arguments against for maintainability purposes. And these kind of optimizations should be recognized and made by the synthesis tool/design compiler instead whenever possible.
from cores-veer-eh1.
I'll leave it to the core designers to give a definite answer, but my personal experience is that the tools aren't always as clever as you might expect and that sometimes you need to sacrifice readability for performance. Especially if you want a consistent implementation across different tools
from cores-veer-eh1.
Assuming 'fetch_to_f1' and 'shift_f2_f1' are never asserted at the same time, this is a very quick mux. That's why it's done this way. It actually is a conventional way of implementing a fast mux.
case (and casez/casex) statements have intrisic priority, the first case is evaluated first (see section 12.5 of the LRM), so this adds extra logic that may or may not be optimised out.
from cores-veer-eh1.
This is logged as an issue with the core. It is not an issue with the core. Such discussions should be held on another forum. Don't know where though. Any suggestions?
This issue should be closed. Who does that?
from cores-veer-eh1.
There is no dedicated mailing list but https://lists.chipsalliance.org/g/technical-discuss has been used to discuss other technical aspects and questions about SweRV so I recommend that for now
from cores-veer-eh1.
Related Issues (20)
- fpga_optimize cannot be set to 0 in swerv_config HOT 1
- openocd timeout occurs when trying to load elf file using command 'load_image'. HOT 7
- Try running multi thread program on swerv EH1 core HOT 2
- CoreMark test score HOT 2
- Unable to replicate performance improvement achieved by using different target values HOT 1
- Usage scenarios of different DFFs
- GHR refresh HOT 1
- Fusesoc's sim target is deprecated HOT 10
- Question about pipeline FF enable signals
- facing issues when C code size goes beyond 8KB HOT 1
- Coremark for new extension
- Repo renaming HOT 2
- Blocking Loads/DMA disable
- OpenOCD download to ICCM/DCCM failed. HOT 1
- The new feature of verilator stops building procession HOT 2
- Formal Verification of SweRV EH1 using riscv-formal
- GCC version in Makefile HOT 4
- $readmem file address beyond bounds of array HOT 8
- Timing violations with Vivado HOT 4
- slip in dec_decode_ctrl
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cores-veer-eh1.