Module name problem on windows

[craigburke]

Module name problem on windows

[craigburke]

Yeah I'm betting that you're right. I'll take a look.

[craigburke]

Give version 2.0.4 a try. It should fix your issue.

[asteria277]

Thanks ... but I'm afraid I still have the same problem.

On Windows, both lines returns an array with only one item :
"myApp/appSection/templates/hello.tpl.htm".tokenize(Pattern.quote(File.separator))
"myApp/appSection/templates/hello.tpl.htm".tokenize("")
===> [myApp/appSection/templates/hello.tpl.htm]

I think File.separator shouldn't be used, as the path contained in AssetFile is not a path that follows the current operating system conventions.

[craigburke]

Well looks like I might have to fire up a Windows VM for this one. I'll give it anther try.

[asteria277]

Thank you.
I will test the new version as soon as it is available.

[dmahapatro]

@craigburke Looks like this PR should solve this issue.

I am also planning to upgrade Groovy version to 2.4.0 and asset pipeline to the latest version. That will be a separate PR and after some exploratory testing.

[craigburke]

Thanks a lot @dmahapatro! I really appreciate that 😄

There's no harm in upgrading the version of the asset pipeline core, but I'd like to keep the Groovy version lower for folks using older versions of Grails. Thanks again for the PR!!

[dmahapatro]

@craigburke You are most welcome. Any plans when to release v2.0.5 with this PR. I am planning to migrate a full fledged legacy angular based Grails app from resources to asset-pipeline ( I know it is high time that should have been done earlier, but you know corporate policies :) ).

Now there is no excuse if we want to upgrade to Grails 3, I have to use asset-pipeline. :)

I wanted to ask a question related to this plugin.
Why *.tpl.html instead of just *.html or *.htm?

Is it because you did not want to put all the html files under templates in $templateCache.

[craigburke]

@dmahapatro I'll probably cut 2.0.5 sometime Monday (I'll reply to this ticket when I do).

You'll never want to go back to Resources after that. Asset pipeline is awesome! 😀

Your assumption about tpl.html vs html is correct. It's also just better to differentiate them as well since otherwise I'd be adding my processor to an already existing asset file type (HtmlAssetFile). This way there's just less chance for surprises.

[craigburke]

Alright version 2.0.5 with @dmahapatro's PR is now live. @asteria277 does this resolve your issue?

[dmahapatro]

Awesome. Thank you.

Minor modification in README:

From:
In gradle these settings can be changed in your build.config

To:
In gradle these settings can be changed in your build.gradle

[craigburke]

@dmahapatro good catch! I changed it.

I'll wait until I get confirmation from @asteria277 until I close this issue.

[asteria277]

I will upgrade my app tomorrow morning at work, I will tell you the results asap.
Thanks already both of you !

[craigburke]

@asteria277 when you do, use version 2.0.6 (not 2.0.5). I've confirmed that it works on Windows.

[asteria277]

I've tested version 2.0.6 and I it is working for me ! Thanks again.

I just have another issue when building the war on hudson, but I will open another issue on the related git project.

[craigburke]

@asteria277 awesome! 😄

@dmahapatro thanks again for helping to point me in the right direction on this. That's much appreciated.