Giter Site home page Giter Site logo

Comments (18)

craigburke avatar craigburke commented on July 20, 2024

Wow, that's an odd one. I'll dig into this one today.

from angular-template-asset-pipeline.

davydotcom avatar davydotcom commented on July 20, 2024

whaaaa?

from angular-template-asset-pipeline.

davydotcom avatar davydotcom commented on July 20, 2024

just one small thing for grails 3 aren't you supposed to be doing java -jar on the war file not the jar file?

from angular-template-asset-pipeline.

craigburke avatar craigburke commented on July 20, 2024

@davydotcom haven't checked with the latest snapshot yet but that does work with RC1.

I saw the same behavior @bobbywarner did running it against the jar file, but the war file worked fine no matter where it was. Is the jar file not a fat jar?

from angular-template-asset-pipeline.

davydotcom avatar davydotcom commented on July 20, 2024

i think something is up with the jar file I'm not exactly sure what it is

from angular-template-asset-pipeline.

craigburke avatar craigburke commented on July 20, 2024

@davydotcom makes sense. @bobbywarner did you notice this issue using any AP plugin other than the AngularJS templates?

from angular-template-asset-pipeline.

davydotcom avatar davydotcom commented on July 20, 2024

i have not

from angular-template-asset-pipeline.

craigburke avatar craigburke commented on July 20, 2024

That's strange. Doing a jar tf on both the war and jar files, I see that the generated jar file doesn't contain the assets folder when my plugin is used. Everything is there in the war file though.

from angular-template-asset-pipeline.

craigburke avatar craigburke commented on July 20, 2024

@bobbywarner this appears to be work with RC2. Could you confirm that with your test project?

from angular-template-asset-pipeline.

bobbywarner avatar bobbywarner commented on July 20, 2024

@craigburke @davydotcom This is still an issue with Grails 3.0.0.RC2, but it might actually be an issue with Asset-Pipeline-Core as opposed to this plugin... I could have swore it was just happening for Angular templates processes by this plugin last night (using Grails snapshots), but when I try with RC2 today, no assets will work (404s) when building a Jar (./gradlew assemble) and then copying that Jar to another folder.

from angular-template-asset-pipeline.

davydotcom avatar davydotcom commented on July 20, 2024

Don't think you are supposed to use the jar file

Sent from my iPhone

On Mar 18, 2015, at 2:35 PM, Bobby Warner [email protected] wrote:

@craigburke @davydotcom This is still an issue with Grails 3.0.0.RC2, but it might actually be an issue with Asset-Pipeline-Core as opposed to this plugin... I could have swore it was just happening for Angular templates processes by this plugin last night (using Grails snapshots), but when I try with RC2 today, no assets will work (404s) when building a Jar (./gradlew assemble) and then copying that Jar to another folder.


Reply to this email directly or view it on GitHub.

from angular-template-asset-pipeline.

craigburke avatar craigburke commented on July 20, 2024

@bobbywarner I see exactly what you mean when using RC1 but RC2 works for me. Would you mind emailing me your test project. I just want to see if there's some difference I'm missing.

@davydotcom I thought with Spring Boot you could use the jar or war file (I might be wrong on that though). I'm wondering if we do find inconsistencies between the war and jar if it's worth raising a JIRA issue.

from angular-template-asset-pipeline.

davydotcom avatar davydotcom commented on July 20, 2024

its possible you will. asset-pipeline-gradle adds a task "assetCompile". Grails calls this during its build phase. Then these generated assets are copied into either the jar or war file. That last part is the task of the grails gradle plugin so we should verify where its inserting them

from angular-template-asset-pipeline.

craigburke avatar craigburke commented on July 20, 2024

@davydotcom how does it determine where it gets inserted?

from angular-template-asset-pipeline.

davydotcom avatar davydotcom commented on July 20, 2024

we would have to check but it may be using the gradle war plugin to do it not the gradle jar plugin

from angular-template-asset-pipeline.

bobbywarner avatar bobbywarner commented on July 20, 2024

@craigburke You're right, I'm dumb, ha! I still had my project using 3.0.0.SNAPSHOT. RC2 works without issues for all assets (including Angular templates with this plugin).

from angular-template-asset-pipeline.

davydotcom avatar davydotcom commented on July 20, 2024

huzzah!

from angular-template-asset-pipeline.

craigburke avatar craigburke commented on July 20, 2024

@bobbywarner I'm glad you reported this. I was unaware there could be differences running the jar outside of the project build folder. Something to verify with newer versions coming out.

Excellent work, gentlemen! 🍻 all around!!

from angular-template-asset-pipeline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.