Allow for module name default

[craigburke]

Allow for module name default

[mrapczynski]

Ah, I read your notes more closely and it mentions that the module name is derived from the folders. Can we make this more flexible? Maybe add a config option in the Gradle file to explicitly set a module name if one is not detected through your current approach?

[craigburke]

@mrapczynski that seems reasonable especially for the case where you have everything in a single module. I'm curious, what does you directory structure look like currently?

[mrapczynski]

@craigburke Very minimal.

[craigburke]

@mrapczynski alright, I'll work this into the next release (should have time next week).

[craigburke]

In thinking about it, it probably makes sense to just add a moduleNameBase property:

moduleNameBase: 'fhdaApp'

This would handle your particular case, but would still allow for you to put templates in submodules down the road if they are in the appropriate folder.

For example, a template in the /ng-views/directives folder could result in a template being added at fhdaApp.directives

[mrapczynski]

@craigburke That sounds like a good solution. Your directory handling is nice, and is definitely functionality that should stick around.

For now, I created a cludgy Gradle task that checks the asset output and puts the module name into wherever it is missing from. Looking forward to this update.

[craigburke]

Ok, I just published version 2.1.0 with this change. Give it a spin and let me know how it works for you.

[mrapczynski]

@craigburke OK, just tried it. No dice.

I configured the plugin like so:

And below is the unminified output - still module name not updated.

Am I missing anything?

[craigburke]

Hmmm... what kind of app (Grails, spring boot, etc)... did you try a gradle clean?

[mrapczynski]

@craigburke Just a plain Gradle Java app with Spring MVC (no Spring Boot). I am building out a template project that my colleagues will clone for training and to create new Angular projects.

To test the 2.1.0 version, I actually had a brand new project where I had not yet done the asset compile. After updating the artifacts, I ran the first build and got the result shown in my last comment.

I'll be working at this most of the day so anything you want to try or debug, I'm up for it.

[craigburke]

Would you be able to throw this sample project up on github so I could take a look?

[mrapczynski]

@craigburke Yes, here you go: https://github.com/mrapczynski/spring-banner-app-template

Our build refers to an internal Maven repo and some dependencies that will not resolve in Gradle so comment out accordingly

[craigburke]

I messed up the docs, the property is moduleNameBase not moduleBaseName. Does changing that help?

[mrapczynski]

@craigburke Sweet! That did it. This is the only issue I had, and it looks fixed. Thanks for all of your help on this.

[craigburke]

Awesome! I'm glad you're finding it useful 👍