cronoh/nanovault

Open source wallet for using the Nano cryptocurrency

nanovault's Issues

Account not displayed after unlocking wallet

Operating System = MacOS High Sierra 10.13.2
NanoVault Version = 1.0.0

Every time i close the app and reopen it, i should be able to see my accounts and balance after unlocking the wallet. However i am not able to see the balance and existing accounts even after unlocking the wallet. I had to press the "CREATE NEW ACCOUNT" button , which then displays my already created account and shows the balance with message "Wallet created xrb_XXXXXX" .

I am not sure if this is intended behavior but it is very confusing and misleading. I shouldn't have to "CREATE" an account thats already created.

Some improvements I can think of.

Hi,

First of all, thanks for NanoVault. It's, in my opinion, what the average user experience should be.

Here are some points to make the software better :

1. When importing a wallet, only the first key is loaded. A Electrum-like loading system would be better : load addresses until you find 20 unused addresses in a row. This would avoid some half a second heart attack to people loading their holding and seeing a 0 XRB balance before they understand that they have to load more accounts.
2. The wallet allow only 10 addresses. For privacy reasons, the wallet should allow more than that. To avoid server overload, maybe reduce the update rate: allow to check the balance of 10 addresses no matter how many address you use. People using 10 times more addresses are going to have a update rate divided by 10 witch is a fair trade of for their privacy.
3. For the same privacy reasons, showing the number of transaction per account on /accounts would be useful.
4. Browser POW has already been discussed in other issues.
5. When arriving to /send, the default 'from' account should not be the first one but the first with a non-zero balance.
6. Beeing able to see the global transaction history would be nice. I think it may be a valuable feature (and probably hard to implement) since, from what I saw, the official nano wallet does not even provide this.
7. Beeing able to send XRB without selecting the 'from' would be nice too. If I have an account A, B and want to send to C. The wallet would do (A->B) then (B->C) if neither A or B have enough balance. Doing (A->C) and (B->C) to send the exact amount would not be good because it gives too much information: A and B private keys are mine while only B private key is mine in the first case. From what I saw, this is not implemented in the other wallets.

I will to look to the code to see if I can help (even if I am not a web dev).

Posting JSON blocks

Hi,

It would be nice to have a page where users can post transactions signed elsewhere as JSON blocks.

ISSUE OPENING NANO APP FROM BTC WALLET

Hello I was directed to add a support issue here from the ledger support team. When I open the LEDGER BTC wallet on my desktop and then open the recently added nano crypto app from my ledger nothing happens at all. It works fine for all other apps and they open perfectly. I was told by ledger support team that most likely there is some problem with my operating system? The computer Im using is only 1 month old and Im using windows 7.

The firmware on my ledger has been confirmed to be updated to the latest version and I also experimented saying yes and no to browser support in the nano app. Still the nano wallet wont open using the BTC wallet.

Please advise asap...

Regards,

J

Integrating POW in-browser

Can you add integration for in-browser POW for both sending/receiving blocks?

Switchable on/off

https://github.com/numtel/node-raiblocks-pow
https://github.com/jaimehgb/RaiBlocksWebAssemblyPoW
https://github.com/numtel/nano-webgl-pow

When offline, v1.0.2 x86-64 AppImage results in blank white window

Perhaps a runtime flag or network detection timeout here would permit the app to open without a network connection (experimenting with offline use now - would like to generate addresses etc).

Checking for update
Error: Error: net::ERR_INTERNET_DISCONNECTED

Thank you

Rep went offline, unable to change rep now. Balance shows zero.

https://www.reddit.com/r/nanocurrency/comments/8bvv0w/nanovault_showing_zero_balance_nanode_says/?st=jfxcfe7r&sh=f8c836fc

Short of downloading the full wallet, syncing the node, and then changing reps, is there any way that we can still change representatives in this state?

Ledger marked "disconnected" after each confirmation on the Ledger

Everytime I click the button on my ledger to confirm a receive, the Ledger disconnects from nanovault.
(I currently have auto-receive = No)
According to roosma, it's an issue with nanovault. here is what he says:
"Technically the U2F protocol used for communication between the browser and the device is stateless. There's no way to tell if the device is still connected unless you try to run some commands on it.

So if NanoVault just claims that the device is disconnected but when you try to do things it still works, then it's just NanoVault illusion breaking down (the connected/disconnected state illusion) If the app on Ledger quits or it freezes Ledger (so that you need to unplug and replug it), then its my issue."

So yes, since the app is still running on the Ledger device, and it gets marked "connected" when i click "reload ledger status" on nanovault, it seems that it's an issue with nanovault.io

"Account details" view not updated when wallet receives funds

If I am in "Account details" on the account that received the funds, the "Account details" page does not reflects the received funds even though Nanovault pops a notifications that the funds were received. I have to return in Accounts and re-click on the account that received the funds to see the updated "Account details".

Change representative

Is it possible to also add the function to change the representative?

account viewer/explorer not showing pending deposits

I know there's a pending deposit there, because it shows on nanode block explorer.

This is for addresses in the address book, not the account you're currently logged in with.

Add incoming link support

Links likexrb:xrb_3rropjiqfxpmrrkooej4qtmm1pueu36f9ghinpho4esfdor8785a455d16nfshould be handled by NanoVault, opening directly the compiled send tab after unlock.
Under linux adding
MimeType=x-scheme-handler/xrb;
in .desktop file works well - just the wallet will not hande it.
test: http://nanode21.cloud/link_xrb.htm

Rounding Errors

Selecting "Max" when sending can lead to some weird behaviours. It left 0.000001 NANO on my address address.

Link to the address.

Representative set improvement

Add option to set a default rep for every new account
Add option to change all previous account's rep

Unable to connect to the Nano node, your balances may be inaccurate!

Hello,
Using the ledger nano s with nanovault. Everything seems fine except I get an error message at the bottom stating:
' Unable to connect to the Nano node, your balances may be inaccurate!' -- how do I sort out this issue?
Thank you - Cheers.

Remove Account label

1. If you want to edit an account label the red X might be a bit misleading. It works as "cancel" or "go back", I would have expected to clear the label. However, I see the point to have "cancel" or "go back" button.
2. To remove most user will delete labels in the Adressbock section. It is also possible to edit a label in the "account details" view and to save a blank label. This is equal to deleting the label. So for so good, just have a look at the pop-up message. I am not a native speaker, but this does look odd.

Not yet compatible with nanode.co alias

hello

This week nanowallet.io just got the nanode.co alias to be used as way to enter an account address when sending transactions.

In this image you can see in the account to send from: the grey observation "(HODL)" that's the local name of this address. The next textbox is filled with "pizza" that is a nanode.co alias, and just by typing this alias it entered the full address for me.

In this other image you can how the alias look on the main page, as the grey being the local name and the red with an "@" the nanode.co alias

That would be super helpful, as today the nanovault.io is the best option for a mobile wallet (even smother than the devs mobile wallet right now), so adding this option to use nanode.co alias as a way to retrieve addressed

Import seed from Ledger Nano show wrong account

I connected a new Ledger Nano S to nanovault and I was given an account. I started to send to that account (and verified all transactions with the ledger button). To verify I closed browser (with wallet storage set to "none" in settings), opened again and connected ledger and everything was fine.

Now one week later I almost got a heart attack when I opened up a fresh browser and imported my ledger and it showed a different account and zero balance! Back from my head I remember reading somewhere that you need to hit "Add new account" and I did that. The old account was generated with correct balance. Now I have to do this every time I connect my ledger. Is this safe? What if that account is not generated next time and I get a third account? I'm thinking of moving my nano to the default account instead but will it happen again, and why?

I'm not 100% sure but I think it failed to give me an account first time I connected my ledger and I had to press "add new account". I know I only had 1 account when I started to use it but this might have "delayed" the default account somehow and it first appeared now and the account I thought was the default one is now number 2.

New logo proposal.

This is an example of a possible new logo. I may follow different directions.

Ledger Nano S support on the desktop version

Will the desktop app support Ledger Nano S, or only the webwallet with chrome?

Improve UX when Node API cannot be reached

We should have a notification and probably a persistent UI element that notifies a user when the Node cannot be reached properly, and have the balance display something like -- with a note about connectivity issues rather than just having 0. Several users have been a bit freaked out when this has happened, one being #47 and a few in the Discord as well.

change the default representative for new wallets

either run a nanovault rep,
or pick some of the trusted known reps (apart from the devs and exchanges)

then pick one of them at random when creating open blocks

Add representative change blocks

Will be a must in future, giving user the choice; not all will do that so there should be a system for randomly assign them or similar...

Add donation account to your github repo

Add this even on your gihub repo xrb_318syypnqcgdouy3p3ekckwmnmmyk5z3dpyq48phzndrmmspyqdqjymoo8hj

I have not received the funds

Hello,

Yesterday I sent 33.99 Nano from Binance to NanoVault. From Binance they confirm to me that everything is correct and the transaction has been completed.

But I still have not received the funds, it says "Unpocketed Transactions".

Please, can you help me?

https://www.nanode.co/block/95E1655BDEB0DD510BA9B500796CC76C00E60E112ED701C77D3F0E2DC2B86FCB (the operation)

https://www.nanode.co/account/xrb_1rdrxuzorhod5k6esa3oxfuzths6ir9exuiatb4gktsywh78jiepk1amrym6
(where I sent it)

Thank you,

Account balance not appearing

After importing seed, one account balance is not showed, but if I click on the account, the balance is showed correctly.

Address book should be locked

Currently the address book doesn't get locked when you lock the wallet. I can see a security problem on that.

Lets say someone with access to my computer/phone opens NanoVault. My wallet is locked but if this person has free access to my address book then he could "change" one of my address (delete it, create a new one and set the same label). If after that I send some coins to this address just by looking at the label then my coins will be on another wallet (not the one I thought).

"Missing" accounts

I found another UX problem similar to #2.

I have two accounts, the main one and a secondary which I manually created with the Create new account button. Every time I lock and unlock my wallet this second account disappears. The account is already opened (sent a transaction from the main one) and it also has balance on it.
To make it visible again I have to click again on "Create new account" which is a bit misleading.

Wallet does not lock on close

Using AppImage, on closing it does not lock the wallet. Security risk.

UX: when no password set, unable to send, no explanation

says "generating proof of work" and then just carries on apparently trying to send forever.

Can't send Nano from NanoVault if balance is 0.000001 NANO

Whenever my wallet has a balance of 0.000001 NANO I can't send it to another wallet. If I try to send it I get the notice From account does not have enough XRB.

While you can obviously see that the balance is there

Pending deposit stuck loading...

Hoping someone can help me with this. I've been trying to get my pending nano deposit to receive, but it's stuck loading. I've tried multiple browsers on my mac (chrome, brave, safari) and they all do the same thing. Also tried the MacOS desktop version with no success. My screenshot says all. Thanks in advance!

App version (and auto-update?)

After reading about your last release
https://github.com/cronoh/nanovault/releases/tag/v1.0.2

I tried to run again the app, to see how the auto-update works.

Maybe it worked, maybe not.

I didn't get any message, and I don't know where I can check its version from the interface.

Default localStorage to off and provide strong warning when turning it on

Storing data unencrypted in localStorage is a pretty massive vulnerability--a single XSS attack could steal anything stored there. See: https://www.owasp.org/index.php/HTML5_Security_Cheat_Sheet#Local_Storage

Therefore I propose we should

1. Really consider turning off the localStorage option by default (or providing a warning/option while creating the account) and
2. Definitely enforce locking the wallet before it is saved to localStorage

Missing Nano from

I transferred Nano from Kucoin on 25 Mar to Nanovault. It was showing initially, but today I went to check the account and noticed the account balance is 0 even though I have not transferred out of the Nanovault wallet

Send a $$ value option

Paying for stuff in $$ rather then Nano. Perhaps one day the world will talk Nano rather then $$, but it's not quite ready yet. So,it would be nice to have a send $$ function rather then trying to work out the current exchange Nano / $$ rate.

Online|offline indicator for representative

It would be nice if beside each representative address, there was some indication of whether your representative is online and voting. That way you'll be prompted to consider changing rep if it's offline, and otherwise, feel reassured.

Update wiped account and address book

After adding loads of addresses to the address book, the auto-update to the latest version (1.0.3) seems to have reset everything. Would be nice if future updates imported the config from previous.

Phone freezes

My phone started to freeze when opening the webpage, it wasn't happening few days ago. Anyone else with this problem?

Add spacing in FIAT value display

For some currencies it's hard to read.

Lock Sidebar

Only a minor UI issue: If you scroll down in "App Settings" the sidebar on the left hand side scrolls down as well. Therefore you have to scroll up again to make the Sidebar visible again and to access the menu.

Support for 'nano_' address prefix

Currently, when sending, the app thinks this is an invalid address.

The official wallet is able to parse this address:
https://github.com/nanocurrency/raiblocks/blob/master/rai/lib/numbers.cpp#L82

Logo proposals.

Hi @cronoh !
I prefer the full background version (squared one). With a more lighter blue color, so it looks more young and UI friendly.

(square borders are necessary on iOS due to its policy for iOS app (no transparency), I guess borders will be automatically rounded when uploaded for iOS.

I attach the generated png and the svg version (zip).

Let me know.

3.zip

Add alias support

https://documenter.getpostman.com/view/2206404/nano-alias/RVfsFYHj#1a0df0fa-4cc8-3ded-eec5-58ee80628e77

It's built on suggestion from Zack , work in progress.

Scanning qr code with mobile wallet adds 'xrb:' in front of xrb address

How to reproduce?

1. Install the Android mobile wallet
2. Click the 'send' button to go to the send view in the app
3. Click the camera in the right top corner
4. Scan the QR Code from your address in the Nanovault desktop app (Windows)

Problem

As you can you see it adds the xrb: in front of the address and leaves the last 4 characters of the address out.
When I scan the QR Code from the official desktop wallet (beta) or from nanowallet.io it adds the address correctly so I assume it's a bug inside nanovault

Mac close issue.

There is no option to quit mac app. Need to force quit from taskbar.

reordering address book

I'd like to be able to reorder my address book by

• clicking and dragging one of the contacts, and dropping it somewhere else
• or up/down buttons that show up on hover

Choose the remote node

Is it possible to connect to a personal node instead of yours?

If yes, is it possible to add an easy settings on the interface?

Add localizations file

So we can transalte in proper language.

Feature request: offline mode

This would require two computers w/ an air-gap. The hot machine would provide the connection to the network and the cold machine would have the seed and perform signing.

The hot machine would either generate the POW itself, or transmit the last block info to the cold machine via QR-code to the cold machine so it could produce the POW though it would be ideal if the POW could just be computed on the hot machine.

The cold machine would produce the signed TX/RX and send it to the hot machine via QR code.

This would be a pretty ideal setup for air-gaped cold wallet operations.