Bugfixes to Tournament Module permissions for BWAPI versions 4.2.0 & 4.1.2

[davechurchill]

Bugfixes to Tournament Module permissions for BWAPI versions 4.2.0 & 4.1.2

[chriscoxe]

I've fixed it for both points, tested the new TournamentModule.dll files on my Win7 SP1 VMs (I modified the latest version & an old version of my bot to try using all the various permissions for the bugged TournamentModule.dll files for BWAPI 4.2.0 and 4.1.2 and confirmed that all permissions are allowed, then tested against the fixed TournamentModule.dll files for BWAPI 4.2.0 and 4.1.2 and verified the resulting behavior is as expected), and committed and pushed all the changes to the ladder branch of my fork, but only for BWAPI versions 4.2.0 and 4.1.2. I have not fixed it for BWAPI version 4.0.1 Beta (nor changed it for BWAPI version 3.7.4) because I don't think it is worth bothering and because I don't have the old compiler versions nor builds of old BWAPI versions set up (which would be a lot of hassle).

[chriscoxe]

Note: BASIL's Tournament Module (https://github.com/Bytekeeper/sc-tm) allows and disallows the same permissions as my new version except that BASIL also allows sendText/printf/setTextSize and has a config setting for the UserInput flag that defaults to allowing it. StarcraftAITournamentManager disallows them for BWAPI 3, so to avoid rocking the boat, I decided not to allow them in my changes.

I know SSCAIT allows leaveGame, sendText, and printf at least, and I gather it also allows setLatCom(false). I don't know whether it allows setCommandOptimizationLevel(0 or other values). Apart from that, I have no idea what SSCAIT allows and disallows because I don't think the source code is available (or if it is, at least not the up-to-date source code). I also have no idea what the defaults are for things like isLatComEnabled(), or what the command optimization level is initially.

[richard-kelly]

Fix from @chriscoxe merged into ladder branch.

[chriscoxe]

Re. 4.0.1 Beta, the AIIDE Rules page and the CIG Rules page don't mention 4.0.1 Beta, so no worries.