Add support for BWAPI 4.4.0 (but not 4.3.0 because it crashes a lot)

[davechurchill]

Add support for BWAPI 4.4.0 (but not 4.3.0 because it crashes a lot)

[chriscoxe]

Update 2019-03-24: I've just added support for BWAPI 4.4.0 and removed the support for BWAPI 4.3.0, so the rest of this old comment about testing peformed is no longer relevant.

I've compiled my bot (ZZZKBot) linking with BWAPI 4.3.0 and tested that my bot runs as expected using ChaosLauncher with the new TournamentModule.dll (and BWAPI 4.3.0 official BWAPI.dll, SNP_DirectIP.snp) on my Win7 SP1 VMs, and committed and pushed all the changes to the ladder branch of my fork.

[N00byEdge]

BWAPI 4.4 now instead? :D @davechurchill

[davechurchill]

We plan on supporting 4.4.0, I don't think we need 4.3 and 4.4

[chriscoxe]

In the "ladder" branch of my fork, I've just committed and pushed all the changes to add support for BWAPI 4.4.0 and remove support for BWAPI 4.3.0.

In terms of testing performed, I have compiled my bot (ZZZKBot) linking with BWAPI 4.4.0 and tested that my bot runs as expected using ChaosLauncher (using the updated plugin BWL files from BWAPI 4.4.0) and using StarcraftAITournamentManager, both using the new TournamentModule.dll (and BWAPI 4.4.0 official BWAPI.dll, SNP_DirectIP.snp) on my Win7 SP1 VMs. I have run ten games against each of a few bots. There were no crashes, and I didn't notice any other problems. I tested that the TM client sets the character_name and game_type_extra settings in bwapi.ini correctly according to all the supported versions of BWAPI (i.e. they are set if and only if the BWAPI version is 4.2.0 or higher). I also tested it in my earlier changes for BWAPI 4.3.0 but I forgot to mention it then.

[richard-kelly]

Fix from @chriscoxe merged into ladder branch.