Giter Site home page Giter Site logo

Comments (5)

fallahn avatar fallahn commented on May 28, 2024

or even simpler (aside from the fact those functions should be const):

sf::vector2u GetTileSize() const { return {m_tileWidth, m_tileHeight}; }

feel free to submit a pull request :)

from sfml-tmxloader.

Mars999 avatar Mars999 commented on May 28, 2024

sorry I have no idea on how to get a pull request please update it for me... sorry

thanks, just never used this before to do that I always just find bugs and inform them. I should learn this stuff more... no time right now... :(

from sfml-tmxloader.

fallahn avatar fallahn commented on May 28, 2024

Click the fork button to create your own fork of the repo on github

Clone your fork to your computer and modify the source code / make any changes. If this is enough for you then that's all you need to do for a modified version.

If you feel your changes can contribute to the original, push any commits to your fork on github. At the top right corner of the fork's page there's a link to Pull Request. Click it to submit your changes to the original repo.

https://help.github.com/articles/fork-a-repo/
https://help.github.com/articles/using-pull-requests/#fork--pull

from sfml-tmxloader.

Mars999 avatar Mars999 commented on May 28, 2024

Oops delete other posting...

also I guess it's uploaded? Please check to see if my changes made it?

Thanks! Great lib by the way!!!

from sfml-tmxloader.

fallahn avatar fallahn commented on May 28, 2024

I can see your fork, but you haven't pushed any changes to it yet. You need to commit your changes locally, then push them to your fork.

https://help.github.com/articles/pushing-to-a-remote/

When you can see your changes on the github page for your fork, you can then submit them as a pull request.

Thanks for making the effort to help out :)

from sfml-tmxloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.