Giter Site home page Giter Site logo

Comments (5)

pjbriggs avatar pjbriggs commented on July 21, 2024

Hello @bernt-matthias

Apologies for not looking at this sooner.

  1. It looks like Galaxy's fastqillumina type corresponds to Illumina 1.3+ format, which uses Phred64 quality encoding. It should be possible to add support for this format, if you can provide a small example file (an R1/R2 pair would be even better) with this format that I can use for testing (~10 reads should be sufficient).

  2. I'm reluctant to add access for the -phred64 option directly. My feeling is that it's better to update the tool to support specific Galaxy-recognised FASTQ formats where the encoding is known, and have the tool add -phred64 when appropriate. Do you have a specific use case for this option?

Let me know what you think, best wishes

Peter

from galaxy-tools.

bernt-matthias avatar bernt-matthias commented on July 21, 2024

Thanks for coming back. Reporting is a long time ago and I cant recall the intended use case. I just read the documentation and found:

If no quality encoding is specified, it will be determined automatically (since version 0.32)

So I guess its best to leave it as it is and not support --phred33/--phred64 options, but rather just accept all fastq Galaxy data types and set the output type the same as the input type... ?

from galaxy-tools.

pjbriggs avatar pjbriggs commented on July 21, 2024

Thanks for the clarification and additional information. I hadn't realised that Trimmomatic could determine the quality encoding automatically but as you say this would mean it's not necessary to implement explicit support for the -phred64 option.

As the tool already uses the format_source attribute to set the output type to match the input type (see the Galaxy tool documentation for info on this: https://docs.galaxyproject.org/en/release_18.05/dev/schema.html#id62), it does look like it's just a case of widening the acceptable input FASTQ types.

I'll need to generate some small FASTQs with different encodings for test cases (I guess "FASTQ Groomer" can do that for me). I'll update the thread once I've made some progress.

from galaxy-tools.

bernt-matthias avatar bernt-matthias commented on July 21, 2024

Great. Good idea to use FASTQ Groomer.

from galaxy-tools.

pjbriggs avatar pjbriggs commented on July 21, 2024

Now in tool version 0.36.6 & uploaded to toolsheds, so closing this as done.

from galaxy-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.