homebridge-platform-maxcube

[homebridge]

homebridge-platform-maxcube

[oznu]

Everything looks good now 😄

[oznu]

• - The plugin must successfully install.
• - The plugin must impliment the Homebridge Plugin Settings GUI.
• - The plugin must not start unless it is configured.
• - The plugin must not execute postinstall scripts that modify the users system in any way.
• - The plugin must not contain any analytics or calls that enable you to track the user.
• - The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.
• - The plugin must be published to npm and the source code available on GitHub.
• - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
• - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

---

The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.

The plugin will prevent Homebridge from loading if it can't find the device. I see you intentially don't call the callback on error to prevent the accessory from being removed.

https://github.com/normen/homebridge-platform-maxcube/blob/master/index.js#L25-L29

If you used the dynamic platform type (with configureAccessories) this would solve both problems.

[normen]

Yeah, forgot about that, sorry.. I'll report back when I moved the plugin to dynamic accessories, which was the plan anyway. Cheers!

[normen]

Version 2.0.0 was just released, fixing the issues by moving to the dynamic platform model.

[donavanbecker]

/check

[github-actions]

✅ Pre-checks completed successfully.