homebridge-denon-heos

[homebridge]

homebridge-denon-heos

[oznu]

@Martvvliet, the check verifies the published npm package.

[Martvvliet]

Thanks, thought so already, so just published a new version.

[donavanbecker]

• - The plugin must successfully install.
• - The plugin must implement the Homebridge Plugin Settings GUI.
• - The plugin must not start unless it is configured.
• - The plugin must not execute post-install scripts that modify the user's system in any way.
• - The plugin must not contain any analytics or calls that enable you to track the user.
• - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
• - The plugin must be published to npm and the source code available on GitHub.
• - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
• - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

---

@Martvvliet everything looks good, with your config.schema.json, you may want to consider changing some of the default parameters to placeholders so that it doesn't default input the values? unless this is your intent?

Just by clicking save after installing the plugin, i get this config.

        {
            "pollInterval": 3,
            "debugToInfo": false,
            "devices": [
                {
                    "name": "Denon Receiver",
                    "ip": "192.168.1.2",
                    "switchInfoMenu": true,
                    "inputs": [
                        {
                            "inputID": "MPLAY",
                            "name": "Apple TV"
                        }
                    ]
                }
            ],
            "switches": [
                {
                    "name": "Receiver on ...",
                    "ip": "192.168.1.2",
                    "pollAllInput": false,
                    "inputID": "MPLAY"
                }
            ],
            "volumeControl": [
                {
                    "name": "Receiver volume",
                    "ip": "192.168.1.2",
                    "volumeLimit": 60
                }
            ],
            "platform": "DenonAVR"

[donavanbecker]

[Martvvliet]

@donavanbecker Great thanks. WIll take a look at the placeholders. Is not my intention, so thanks for the tip :)

[github-actions]

The following pre-checks failed:

❌ The "homebridge" library was installed as a dependency.
❌ The "hap-nodejs" library was installed as a dependency.

Comment /check to run checks again.

[Martvvliet]

/check

[github-actions]

The following pre-checks failed:

❌ The "homebridge" library was installed as a dependency.
❌ The "hap-nodejs" library was installed as a dependency.

Comment /check to run checks again.

[Martvvliet]

/check

[github-actions]

✅ Pre-checks completed successfully.