humanoid-path-planner/hpp-util

Debugging tools for the HPP project

hpp-util

This package gathers technical tools for the HPP project. Features include:

• debugging
• benchmarks

Setup

To compile this package, it is recommended to create a separate build directory:

mkdir _build
cd _build
cmake [OPTIONS] ..
make install

Please note that CMake produces a CMakeCache.txt file which should be deleted to reconfigure a package from scratch.

Dependencies

The package depends on several packages which have to be available on your machine.

• System tools:
  • CMake (>=2.6)
  • pkg-config
  • usual compilation tools (GCC/G++, make, etc.)
• libtinyxml-dev

hpp-util's Issues

C++11 & `HPP_POSTCONDITION` with `BOOST_SCOPE_EXIT`

Hi,

If we try to compile this project in c++11, the tests do not pass, because at
https://github.com/humanoid-path-planner/hpp-util/blob/master/include/hpp/util/assertion.hh#L71 if an exception is raised, it can't be catched there:
https://github.com/humanoid-path-planner/hpp-util/blob/master/tests/assertion.cc#L101

Boost's doc on BOOST_SCOPE_EXIT provides the following warning since at least 1.50 (released in 2012):

Warning: The implementation executes the scope exit body within a destructor thus the scope exit body must never throw in order to comply with STL exception safety requirements.

I don't think that this HPP_POSTCONDITION is used anywhere, so I think that we should remove it, otherwise we would have to add CMAKE_CXX_STANDARD=98 to the CMakeLists (and to the packages that use this HPP_POSTCONDITION), to allow compilation of this package on compilers which have c++11 as the default standard, which is the case for the those provided with ubuntu 18.04.

License BSD 2

In agreement with the main authors, we intend to change the license of this package from LGPL-v3 to BSD 2 clauses. A pull request will follow soon to this effect.

C++11 & HPP_ASSERT

Hi,

There is an issue using HPP_ASSERT on boost::shared_ptr with C++11, raising en error during the compilation of hpp-manipulation because of a failed conversion to bool.

Line causing the error in hpp-manipulation:
https://github.com/humanoid-path-planner/hpp-manipulation/blob/6e38ce3a838ff365ec0941be881ec4760e407ef6/src/manipulation-planner.cc#L163

Because of the definition of macro HPP_ASSERT here:

hpp-util/include/hpp/util/assertion.hh

Line 36 in 46c057e

bool _x = (CONDITION); \

Indeed, in C++11, as stated here, the bool operator is implicit, so the cast fails. Adding an explicit cast would solve the issue.