Comments (6)
assert whelp.atk == 3
E AssertionError: assert 4 == 3
E + where 4 = <Minion ('Whelp')>.atk
This is how my case fails
Probably some related cases may fail due to the same reason.
Will check when go through cases.
from fireplace.
Yeah I'm aware of the failure mode. Maybe you can remove the other minion from the board after you've checked for it, I think there's a way to do it that doesn't trigger deathrattles (remove_from_game() was it?)
from fireplace.
Currently I haven't found remove_from_game().
All related operations are implemented as set:
target.zone = Zone.GRAVEYARD
And I think it is a good idea to add this to Minion and Weapon.
from fireplace.
@tonyyyye Make sure you're on Discord at https://discord.gg/hearthsim-devs -- We can chat there more easily and you can ask anything you like :)
from fireplace.
Besides Dire_wolf_alpha, Flametongue_Totem, Wild_Pyromancer will also cause the problem.
While all minions related could be solved by game.current_player.field[-1].bounce(),
Wild_Pyromancer is another problem, which was caused by modification of spell cycle in patch 9.2 .
Hearthstone Mechanics Update – We’ve changed some underlying rules to prevent Wild Pyromancer from triggering off of Mindgames
from fireplace.
There are no more after-spell-damages when summon a Wild Pyromancer, including this silvermoon portal.
The rest of the excetion cases are tested with like a 10k times without error, so I think it can be modified by that way.
The Wild Pyromancer("NEW1_020") problem will be mentioned by another issue.
from fireplace.
Related Issues (20)
- Secrets with Lord Jaraxxus HOT 5
- [test]Missing steps in attack cycle when Truesilver Champion triggers off Shadowboxer HOT 3
- Is there any way to choose WILD cards? HOT 5
- When Choose Twice, only second choose work. HOT 5
- [test]Spell cycle:Wild Pyromancer deals unexpected damages if it is created by a spell. HOT 2
- [test]solemn vigil does not restore its original cost after one's turn ends HOT 2
- When the card is discarded, it will enter the Zone.GRAVEYARD HOT 3
- Silence bug HOT 2
- [test] Test cases test_medivh fails when summon Sorcerer's Apprentice HOT 1
- [Test] Cenarius' choice EX1_573a needs to "- SELF" HOT 1
- [Suggest]Need more warning tags other than Invalid action
- [Test]Wild growth mana used issue. HOT 2
- build fail HOT 1
- choose one of three RandomCardPicker HOT 3
- small error on rogue.py? HOT 3
- [Test] dual class cards make test failed. HOT 1
- Proposing a PR to fix a few small typos
- where is the requirements.txt? HOT 2
- 'Hero' object has no attribute 'left_minion' with Sweeping Strikes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fireplace.