Giter Site home page Giter Site logo

Comments (5)

tonyyyye avatar tonyyyye commented on July 29, 2024

Yes I reproduced it and here is what i discovered.
class Battlecry
implements actions for battlecry as
source.game.main_power(source, actions, target)

Minion Brann gives it another main_power(), but when it misses Choose (and Index()) as a playable Minion which has
play(self, target=None, index=None, choose=None):

This could also be a potential problem for minions with tag Adapt.

@shinoi2 Please make me aware it if you have any new ideas about it.

from fireplace.

tonyyyye avatar tonyyyye commented on July 29, 2024

Maybe Brann can also work like another way like Mechwarper does.

By this I mean literally the description shows that it's the Player who can trigger battlecry twice but acturally only Cards in hand, including Minion/Hero/Weapon, can trigger it.

from fireplace.

jleclanche avatar jleclanche commented on July 29, 2024

This needs to be tested ingame, if possible with an hsreplay file for reference.

from fireplace.

tonyyyye avatar tonyyyye commented on July 29, 2024

It was tested.
In the program, the first choice is not finished with choice when the second comes out.
Don't know if a combined Discover method can be called, or an alternative ‘choose First/Second/Third’ parameter (not the card name) can be supplied.

from fireplace.

tonyyyye avatar tonyyyye commented on July 29, 2024

I did not test with Arch-Thief Rafaam("LOE_092") under the current environment and i think it's a special Discover with the only three cards offered.

This special battlecry will supposedly trigger twice when Brann is on board.
Since I decomposed this minion, can you help us with this test? @shinoi2

from fireplace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.