Giter Site home page Giter Site logo

Silence bug about fireplace HOT 2 CLOSED

shinoi2 avatar shinoi2 commented on July 29, 2024
Silence bug

from fireplace.

Comments (2)

tonyyyye avatar tonyyyye commented on July 29, 2024

I tried to reproduce it and got the logs below:

Clearing buffs from <Minion ('Chillwind Yeti')>
<Enchantment ('Power Word: Shield')> moves from <Zone.PLAY: 1> to <Zone.REMOVEDFROMGAME: 5>
<Enchantment ('Power Word: Shield')> moves from <Zone.PLAY: 1> to <Zone.REMOVEDFROMGAME: 5>

and

[fireplace.actions]: Silencing <TargetedAction: Silence()>
[fireplace.entity]: Clearing buffs from <Minion ('Chillwind Yeti')>
[fireplace.card]: <Enchantment ('Power Word: Shield')> moves from <Zone.PLAY: 1> to <Zone.REMOVEDFROMGAME: 5>
[fireplace.card]: <Enchantment ('Power Word: Shield')> moves from <Zone.PLAY: 1> to <Zone.REMOVEDFROMGAME: 5>

The silence procedure is:

  1. broadcast EventListener
  2. clear all stored buffs
  3. Wipe the event listeners

From this we can make it clear that the minion health is presented as original health + fuffs[]
while the actual health may have a calculation of damage and healing which is missing in fireplace .

In real game, I think, it is a little bit complicated (some of the conclusion need more testing):

  1. The buffs for the minion are presented under the buff list (shown by moving over the focus).
  2. The Silencing procedure will restore its origin atk whatever buffs it has taken.
  3. When the minion is damaged (RAGE/in red), the silence will
    1)set the minion to its default health value when the current health is no less than that of the original one and after being silenced the RAGE tag is removed.
    2)keep the current value and RAGE tag when the current health is less than that of the original one.
  4. The swap health/atk buff will do as it describes and remove the RAGE tag.
  5. When the minion is not damaged, the silence will reset the minion to its original attributes.
    TODO
  6. Haven't test 'swap h/a in hand' but the original form of 'Swift Messenger'(GIL_528) justified my guess.

from fireplace.

shinoi2 avatar shinoi2 commented on July 29, 2024

Fixed

from fireplace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.