Comments (3)
Yes I think you are right. The GRAVEYARD should store and only store all the DEAD minion, or the Resurrect BRM_017 will have a wrong choice range.
I tested with EX1_306 which justified my guess.
now the discard() is working in card.py
- log()
- set tags -> DISCARDED
- set Zone -> GRAVEYARD
so if a card is discarded, it has tags(or method called) like wisp.discarded() which has a True value.
from fireplace.
The problem is there is no such thing as the DISCARD zone, that was something I added later on. Hearthstone tracks a graveyard zone separately... we don't mimick that at this time. I dunno what to do about it.
from fireplace.
luckily we had preserved game.current_player.discarded. Maybe from this we can do something about it.
When discarded, append this card to game.current_player.discarded[], or select/filter the ones that has method of discarded().
Also, if the mechanism 'discarded card always goes into graveyard' does not change, the Resurrect and its related cards needs modification.
from fireplace.
Related Issues (20)
- [Test]Sometimes test for test_silvermoon_portal() fails HOT 6
- Secrets with Lord Jaraxxus HOT 5
- [test]Missing steps in attack cycle when Truesilver Champion triggers off Shadowboxer HOT 3
- Is there any way to choose WILD cards? HOT 5
- When Choose Twice, only second choose work. HOT 5
- [test]Spell cycle:Wild Pyromancer deals unexpected damages if it is created by a spell. HOT 2
- [test]solemn vigil does not restore its original cost after one's turn ends HOT 2
- Silence bug HOT 2
- [test] Test cases test_medivh fails when summon Sorcerer's Apprentice HOT 1
- [Test] Cenarius' choice EX1_573a needs to "- SELF" HOT 1
- [Suggest]Need more warning tags other than Invalid action
- [Test]Wild growth mana used issue. HOT 2
- build fail HOT 1
- choose one of three RandomCardPicker HOT 3
- small error on rogue.py? HOT 3
- [Test] dual class cards make test failed. HOT 1
- Proposing a PR to fix a few small typos
- where is the requirements.txt? HOT 2
- 'Hero' object has no attribute 'left_minion' with Sweeping Strikes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fireplace.