`cumulative_num_comparisons_from_blocking_rules_chart` fails for `link_only` AthenaLinker

[alanakilleen]

`cumulative_num_comparisons_from_blocking_rules_chart` fails for `link_only` AthenaLinker

[alanakilleen]

Opened #1740. Closing this ticket. Thank you!

[RobinL]

If I understand the question correctly, this is expected behaviour:
https://moj-analytical-services.github.io/splink/demos/tutorials/01_Prerequisites.html

[alanakilleen]

Oh I see, thank you! Would make sense to add a check for that when the Linker is created? I can create a feature request for that instead.

[RobinL]

Yes - good idea - I think @ThomasHepworth may have been thinking about it. Maybe he can weigh in

[ThomasHepworth]

Heya👋 If the error is due to the issue above, I believe we have an outstanding discussion somewhere (I've tried to find it, but we clearly didn't label is very well).

We have also been considering adding in the ability to generate column aliases for a while, but never found the time to do so.

Please do create an issue a feature request for this, link and close this issue and we will try to resolve it when we find the time.

Cheers!

[RobinL]

@ThomasHepworth I think an initial version of this could just check the columns are the same, and if not raise a warning to say the input dataframes are not conformant