Giter Site home page Giter Site logo

Comments (4)

JonathanLaidler avatar JonathanLaidler commented on June 17, 2024 1

Hi Robin,

Thanks for the reply. Yes, that's exactly what I was thinking.
I'd love to contribute to Splink! It'll be next week, but I'll have a go at this.

Cheers,

Jonny

from splink.

RobinL avatar RobinL commented on June 17, 2024

Hi Jonathan,

Yes, I think we should be able to do this.

If you're interested in contributing to Splink, you'd want to add an additional argument here e.g. register_udfs_automatically:

num_partitions_on_repartition=None,

The argument would then activate/deactivate this line of code from running:

self._register_udfs_from_jar()

Probably the new argument wants a default value that means the self._register_udfs_from_jar() runs, but if the user sets the value of register_udfs_automatically false, then self._register_udfs_from_jar() is not run.

We'll try to get around to doing this sometime next week hopefully if you're not able to add it.

Thanks,

Robin

from splink.

JonathanLaidler avatar JonathanLaidler commented on June 17, 2024

Linting errors now fixed, please try and merge again.
Thanks!

from splink.

RobinL avatar RobinL commented on June 17, 2024

Closed by #1774

from splink.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.