mttgdd/openfabmap-python3

Pybind11 and numpy array bindings to openFABMAP

openfabmap-python3's Issues

Compilation errors

Hi Matt,
I am trying to build this with OpenCV 3.4. I have cloned and built openCV 3.4 as well as opencv-contrib 3.4

There are a few issues building the repo:

1. The sub-modules did not clone correctly. I had to manually clone them into the respective folders in your repo. I think there was an issue with how they are called. I also had to clone your repo itself, the terminal inputs in the readme.md threw up public key errors it also seems like the name of the repo changed? openfabmap-python to openfabmap-python3?

2. Not using opencv built from the package installer [i.e sudo apt install libopencv-dev] results in line 3 of detectorsAndExtractors.cpp needing to be changed to point to nonfree.hpp in the contrib module [though this workaround never really worked on either repo so I have a suspicion that there is something amiss]

The complie then fails with the following error:

CMakeFiles/openfabmap_python3.dir/build.make:206: recipe for target 'CMakeFiles/openfabmap_python3.dir/src/detectorsAndExtractors.cpp.o' failed
make[2]: *** [CMakeFiles/openfabmap_python3.dir/src/detectorsAndExtractors.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/openfabmap_python3.dir/all' failed
make[1]: *** [CMakeFiles/openfabmap_python3.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

So I think there is something wrong here. Though when running just the cmake file of openFABMAP it finds openCV 3.4.14 and the non-free modules.

I have also have a dump of the whole terminal so that you can see that commands used, if this will help you.

I hope this makes sense to you.

Matt

example, seg-fault

Hi @mr-church, could you confirm that on a fresh pull of the docker image/clone of the repo/however you have it installed, that you now pass through this point in the example without seg-faulting:

use OpenCV cpp methods for image loading and feature extraction

My apologies for the error, it must have crept in when I was making changes to the API elsewhere. Just needed to pass explicit settings for OpenCV detector-extractors.