Giter Site home page Giter Site logo

Comments (6)

Juke34 avatar Juke34 commented on July 25, 2024

Thank you for your feedback. That would be definitely useful, we will add this information.

from emblmygff3.

Juke34 avatar Juke34 commented on July 25, 2024

Done.
Will be included in the next release (not planned yet. I will wait for more modifications). To have this improvement before the next EMBLmyGFF3 release, install EMBLmyGFF3 using git clone:

pip uninstall EMBLmyGFF3 #could be needed twice
git clone https://github.com/NBISweden/EMBLmyGFF3.git
cd EMBLmyGFF3/
python setup.py install

If you already installed the tool using git clone you will have to do so:

pip uninstall EMBLmyGFF3 #could be needed twice
git pull  #from the EMBLmyGFF3 git repository. It will update the code
python setup.py install #from the EMBLmyGFF3 git repository

from emblmygff3.

loraine-gueguen avatar loraine-gueguen commented on July 25, 2024

Thanks!
Would it be possible to catch all exceptions with a clue on the location into the GFF3 file ? The error examples number 1 and 3 in my comment above are not addressed by this commit, unless I'm mistaken (although, for error number 1, I admit that I can search for non ASCII character by a simple shell command)

from emblmygff3.

Juke34 avatar Juke34 commented on July 25, 2024

Actually having a CDS not multiple of three is allowed. So it is not an error, but translation method (which is part of biopython and not EMBLmyGFF3) raise a warning to inform you.

To fulfil your request I have now added an internal (in EMBLmyGFF3) Warning with the CDS ID when the CDS is not multiple of three. I'm not sure about the pertinence to add this warning, but it is now done.

For the following error

UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 5: ordinal not in range(128)

I don't have any test case to work with. Could you provide me a sample of your data ?

from emblmygff3.

loraine-gueguen avatar loraine-gueguen commented on July 25, 2024

I had a look on your commit (6816aa8). I agree with you that this may not be pertinent to add this warning... I thought it could be possible quite easy to catch all kind of errors indifferently from biopython and provide the feature ID where it occurs, but maybe I am mistaken... I thank you anyway.

For the ASCII error, you should have the error only by copy-paste this character into an attribute of the 9th column of the GFF3: "α" (greek alpha). Tell me if not.

Thank you

from emblmygff3.

Juke34 avatar Juke34 commented on July 25, 2024

The last commit (7398bd4) should have addressed the UnicodeDecodeError error.
Thank you for having catched this issue.

from emblmygff3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.