NOTEPAD++ v8.6.8 Crashed and throwing exception when launching on Windows Core Server 2022

[Pmalhotra2024]

NOTEPAD++ v8.6.8 Crashed and throwing exception when launching on Windows Core Server 2022

[xomx]

notepad-plus-plus/PowerEditor/src/WinControls/ImageListSet/ImageListSet.cpp

Lines 49 to 52 in 57a89b2

	DPIManagerV2::loadIcon(_hInst, MAKEINTRESOURCE(iconID), cx, cy, &hIcon, LR_DEFAULTSIZE);
	if (!hIcon)
	throw std::runtime_error("IconList::addIcon : LoadIcon() function return null");

@ozone10
Looks like we should offer also some alternative way. (problem is probably the COMMCTRL lib LoadIconWithScaleDown, it should be supported from the WinVista+ / WinServer2008+ but apparently there could be a problem with it)

[Pmalhotra2024]

Windows Server 2022 Core is a windows server without Desktop Experience feature.
It only provides PowerShell Terminal to run and launch apps from command line.
Notepad++ version 8.6.7 is working fine with Core machines. Only new update is crashing.

[xomx]

@donho

let me know if v8.6.8 works under your Win7

@rkwk
You could try to update/reinstall your installation of the MS Common Controls (COMCTL32) library on your Win7.

[Pmalhotra2024]

@Pmalhotra2024 Thank you for the information. Does only Windows 2022 Server come with "Sever Core" version?

@ozone10 I guess we need to distinguish Windows Server 2022 Core (and other previous versions) from the other Windows, for DPIManagerV2::loadIcon().

@Pmalhotra2024 Thank you for the information. Does only Windows 2022 Server come with "Sever Core" version?

@ozone10 I guess we need to distinguish Windows Server 2022 Core (and other previous versions) from the other Windows, for DPIManagerV2::loadIcon().

@Pmalhotra2024 Thank you for the information. Does only Windows 2022 Server come with "Sever Core" version?

@ozone10 I guess we need to distinguish Windows Server 2022 Core (and other previous versions) from the other Windows, for DPIManagerV2::loadIcon().

Windows Core editions are available since Windows Server 2016 was launched
Windows_Server-2016-English-Core
Windows_Server-2019-English-Core
Windows_Server-2022-English-Core

[rkwk]

Same on Windows 7.

[donho]

Minimum supported server | Windows Server 2008 [desktop apps only]
If server 2008 is supported by LoadIconWithScaleDown, I wonder how & why server 2022 is not.
But here is Windows Core Server 2022, so it could be the different between "Windows Server" and "Windows Server Core".

Anyone here who has Window Server experience are welcome to provide his/her opinion.

[donho]

Same on Windows 7.

OTOH, LoadIconWithScaleDown SOULD work on Windows 7. It might be an isolated case IMO.

I will manage to get a Windows 7 VM for reproducing it. In the meantime, for people who are under Windows 7, please let me know if v8.6.8 works under your Win7.

[donho]

@Pmalhotra2024
Thank you for the information.
Does only Windows 2022 Server come with "Sever Core" version?

@ozone10
I guess we need to distinguish Windows Server 2022 Core (and other previous versions) from the other Windows, for DPIManagerV2::loadIcon().

[donho]

@Pmalhotra2024
Could you check the PR #15314 and confirm me if crash has been fixed?

[Pmalhotra2024]

Unfortunately it is still crashing with same error.

[donho]

@Pmalhotra2024
Please try the PR #15315

[donho]

@Pmalhotra2024
In case that #15315 doesn't work to you, could you try #15316 ?
It contains debug info for letting us understand why the crash happen.