omegaweapondev/omegavision

A Modern SpigotMC plugin that allows players to toggle their nightvision status

Hey there! 😄

My name is OmegaWeaponDev and I am a SpigotMC/PaperMC plugin developer as well as a beginner Game Developer (Using C++ and Unreal Engine 4)

Currently I am more focused learning game development I am still highly into making plugins for people and providng the best support I possibly can for the current (5) plugins that I currently have listed on SpigotMC website which you can find here: https://www.spigotmc.org/resources/authors/omegaweapondev.14953/

If you are wanting a custom plugin developed for you, or needing some support for one of the plugins I offer, or even just wanting to have a chat. You are more than welcome to join the public discord server that I have created. You can find the invite link here: https://discord.gg/9nZTPcp.

The projects I am currently working on are:

A full recode of my plugin JoinPrivileges
A Udemy Unreal Engine C++ Course for Game Development

omegavision's Issues

[Feature]: /nightvision global add/remove limited to online players

Issue Description

When trying to run /nightvision global add/remove through console, I am told I need to be a player to use this command. Unsure if the same issue will occur when a plugin tries to run the command, but if so, that seems like a rather important issue.

Steps to Reproduce

1. Run /nightvision global add/remove through console

Error Messages

No response

Expected Behaviour

It should run the command as if it is being done by a player, and not be limited to only working when physically online.

Debug Information

https://pastebin.com/ytfC2iNf

Logs and Configs

No response

Additional Information

No response

Command messages in console

Currently, when doing a command via console there is no 'confirmation' message that appears like there is when using it in-game.

I suggest that when turning night vision on for everyone, toggling it for a single player etc. that it should display the appropriate messages.yml per command.

Reload issue -

issue-description

Plugin doesn't seem to want to be reloaded with /nv reload. Also, I checked my files with yaml error finder, it appears files are fine. /omegavision reload says the plugin reloaded - but doesnt apply my changes.

Error Messages

https://paste.helpch.at/qokejesuke.bash

Expected Behaviour

For NV to reload all file configurations to apply my configuration changes.

Debug Information

https://imgur.com/a/Zk4ECGq

Logs and Configs

https://paste.helpch.at/zivaherope.shell
https://paste.helpch.at/ocogesirej.makefile

Additional Information

No response

Introduce a config option or permission for who sees the global enable/disable message for all players

Enhancement Description

Currently, whenever /nightvision global add or /nightvision global remove is used, all players see the message in chat. I'd prefer this not be the case, and instead be toggleable via a permission or config option. I have tried setting the message as blank (just "") in the message.yml, however that just results in only the prefix being sent (possible bug?).

Functionality

It simply just won't send the message to normal players

Additional Information

No response

[Bug]: omegavision.nightvision.keepondeath doesn't actually work

Issue Description

A player who has permission to toggle NightVision will not keep NightVision upon death, even when they have the permission (config option set to true as well).

This is also the case for players who have the permission, but can only have NightVision if you yourself enable it for them (whether that be with /nv [player] or /nightvision global add).

Steps to Reproduce

1. Give a player omegavision.nightvision.keepondeath
2. Set Keep_Night_Vision_On_Death to true in the config
3. Have the player enable NightVision or enable it for them via one of the 2 methods listed previously
4. Do /kill [player]

Error Messages

No response

Expected Behaviour

The player should keep NightVision enabled

Debug Information

https://mcpaste.io/c44ee62040bd3014

Logs and Configs

No response

Additional Information

No response

Error in console when user does not have permission

[22:41:45 INFO]: Headle55_h0rs3mn issued server command: /nv
[22:41:45 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'nv' in plugin OmegaVision v2.4.7
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.16.5.jar:git-Purpur-1064]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:172) ~[patched_1.16.5.jar:git-Purpur-1064]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.dispatchCommand(CraftServer.java:810) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.PlayerConnection.handleCommand(PlayerConnection.java:2301) ~[?:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.PlayerConnection.c(PlayerConnection.java:2116) ~[?:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.PlayerConnection.a(PlayerConnection.java:2069) ~[?:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.PacketPlayInChat.a(PacketPlayInChat.java:50) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.PacketPlayInChat.a(PacketPlayInChat.java:8) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:55) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.TickTask.run(SourceFile:18) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.MinecraftServer.bb(MinecraftServer.java:1335) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.MinecraftServer.executeNext(MinecraftServer.java:1328) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.MinecraftServer.sleepForTick(MinecraftServer.java:1304) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1148) ~[patched_1.16.5.jar:git-Purpur-1064]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:291) ~[patched_1.16.5.jar:git-Purpur-1064]
at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.lang.NullPointerException
at me.omegaweapondev.omegavision.utils.MessageHandler.string(MessageHandler.java:22) ~[?:?]
at me.omegaweapondev.omegavision.command.ToggleCommand.toggleCommand(ToggleCommand.java:59) ~[?:?]
at me.omegaweapondev.omegavision.command.ToggleCommand.execute(ToggleCommand.java:44) ~[?:?]
at me.omegaweapondev.omegavision.library.commands.GlobalCommand.onCommand(GlobalCommand.java:17) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.16.5.jar:git-Purpur-1064]
... 19 more

[Bug]: Could not pass event PlayerItemConsumeEvent to OmegaVision v2.5.7

Issue Description

Not sure exactly.

Steps to Reproduce

No clue,

Error Messages

16.12 13:18:22 [Server] ERROR Could not pass event PlayerItemConsumeEvent to OmegaVision v2.5.7
16.12 13:18:22 [Server] INFO java.lang.NullPointerException: Cannot invoke "java.util.Map.put(Object, Object)" because the return value of "java.util.Map.get(Object)" is null
16.12 13:18:22 [Server] INFO at me.omegaweapondev.omegavision.utils.UserDataHandler.setEffectStatus(UserDataHandler.java:122) ~[OmegaVision-2.5.7.jar:?]
16.12 13:18:22 [Server] INFO at me.omegaweapondev.omegavision.events.PlayerListener.onBucketUse(PlayerListener.java:220) ~[OmegaVision-2.5.7.jar:?]
16.12 13:18:22 [Server] INFO at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor152.execute(Unknown Source) ~[?:?]
16.12 13:18:22 [Server] INFO at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[paper-api-1.18-R0.1-SNAPSHOT.jar:?]
16.12 13:18:22 [Server] INFO at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[paper-api-1.18-R0.1-SNAPSHOT.jar:git-Paper-66]
16.12 13:18:22 [Server] INFO at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.18-R0.1-SNAPSHOT.jar:?]
16.12 13:18:22 [Server] INFO at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[paper-api-1.18-R0.1-SNAPSHOT.jar:?]
16.12 13:18:22 [Server] INFO at net.minecraft.world.entity.LivingEntity.completeUsingItem(LivingEntity.java:3807) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.server.level.ServerPlayer.completeUsingItem(ServerPlayer.java:1704) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.world.entity.LivingEntity.updateUsingItem(LivingEntity.java:3669) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.server.level.ServerPlayer.updateUsingItem(ServerPlayer.java:2282) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.world.entity.LivingEntity.updatingUsingItem(LivingEntity.java:3650) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.world.entity.LivingEntity.tick(LivingEntity.java:2868) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.world.entity.player.Player.tick(Player.java:268) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.server.level.ServerPlayer.doTick(ServerPlayer.java:669) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.server.network.ServerGamePacketListenerImpl.tick(ServerGamePacketListenerImpl.java:315) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.network.Connection.tick(Connection.java:526) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.server.network.ServerConnectionListener.tick(ServerConnectionListener.java:201) ~[?:?]
16.12 13:18:22 [Server] INFO at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1636) ~[paper-1.18.jar:git-Paper-66]
16.12 13:18:22 [Server] INFO at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:480) ~[paper-1.18.jar:git-Paper-66]
16.12 13:18:22 [Server] INFO at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1470) ~[paper-1.18.jar:git-Paper-66]
16.12 13:18:22 [Server] INFO at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1264) ~[paper-1.18.jar:git-Paper-66]
16.12 13:18:22 [Server] INFO at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317) ~[paper-1.18.jar:git-Paper-66]
16.12 13:18:22 [Server] INFO at java.lang.Thread.run(Thread.java:833) ~[?:?]

Expected Behaviour

No error?

Debug Information

https://pastebin.com/iSn4tkyW

Logs and Configs

No response

Additional Information

No response

Auto disable per world

I suggest a config option that allows you to specify what world a player's night vision will auto-disable, possibly introduce a permission bypass as well. Or, instead of a config option, just have it auto-disable when they enter a world that the omegavision.toggle permission is not set in.

It'd be good to also introduce a messages.yml option for when nightvision is auto-disabled.

[Bug]: Incorrect message being sent when trying to enable NightVision after death

Issue Description

If a player does not have omegavision.nightvision.keepondeath set to true, but they have NightVision enabled upon death, they will be told their NightVision has been toggled off when trying to enable it upon respawn.

Steps to Reproduce

1. Enable NightVision
2. Die
3. Try Enable NightVision, it will then tell you NightVision has been toggled off

Error Messages

No response

Expected Behaviour

It should enable NightVision and tell you it's been turned on.

Debug Information

https://mcpaste.io/c44ee62040bd3014

Logs and Configs

No response

Additional Information

No response

[Bug]: OmegaVision v2.5.10 generated an exception while executing task 385831

Issue Description

31.12 03:04:51 [Server] WARN [OmegaVision] Plugin OmegaVision v2.5.10 generated an exception while executing task 385831
31.12 03:04:51 [Server] INFO java.lang.NullPointerException: Cannot invoke "java.util.Map.getOrDefault(Object, Object)" because the return value of "java.util.Map.get(Object)" is null
31.12 03:04:51 [Server] INFO at me.omegaweapondev.omegavision.utils.UserDataHandler.lambda$saveUserDataToFile$1(UserDataHandler.java:104) ~[OmegaVision-2.5.10.jar:?]
31.12 03:04:51 [Server] INFO at org.bukkit.craftbukkit.v1_18_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.18.jar:git-Paper-66]
31.12 03:04:51 [Server] INFO at org.bukkit.craftbukkit.v1_18_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[paper-1.18.jar:git-Paper-66]
31.12 03:04:51 [Server] INFO at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[paper-1.18.jar:git-Paper-66]
31.12 03:04:51 [Server] INFO at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
31.12 03:04:51 [Server] INFO at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]

Steps to Reproduce

Not sure, a player disconnected and the error occured

Error Messages

No response

Expected Behaviour

No error, I guess.

Debug Information

https://pastebin.com/kmbC21gs

Logs and Configs

No response

Additional Information

No response

Join event error?

issue-description

Getting this error after joining.
I haven't edited anything within the plugin, and was only provided the jar.

Error Messages

https://paste.helpch.at/agafunobec.sql

Expected Behaviour

I think... the expected behaviour is to not produce console errors.

Debug Information

https://imgur.com/a/Bghtxhs

Logs and Configs

https://paste.helpch.at/celoqajipa.makefile - Messages
https://paste.helpch.at/tetucuwugi.shell - Config

Both default - nothing edited.

Additional Information

No response

Double message appears for the user you manually enable/disable Night Vision for

If you do /nv [user] on a double message will appear for said user saying their Night Vision has been turned on. If you do /nv [user] off a double message will appear saying their Night Vision has been turned off. At first I thought maybe there was a copy-paste of messages in the messages.yml file, but it doesn't seem that there is a specific message for when another player manually toggles a users Night Vision.

Incorrect message being sent when attempting to enable NightVision upon login

issue-description

Set Night_Vision_Login to true in the config and don't give yourself omegavision.nightvision.login. Enable NightVision, log out and then back in, and try enabling NightVision again. The message that will display is that you're disabling NightVision, even though it is already disabled.

Error Messages

No response

Expected Behaviour

When trying to enable NightVision, it should say NightVision has been enabled.

Debug Information

https://pastebin.com/CdfeYRs7

Logs and Configs

No response

Additional Information

No response

Double enable message being sent when using /nightvision global add

issue-description

When you use /nightvision global add it sends 2 messages saying NightVision has been enabled for all players.

Error Messages

No response

Expected Behaviour

When using the command it should only send 1 message

Debug Information

https://pastebin.com/CdfeYRs7

Logs and Configs

No response

Additional Information

No response

Console detects the wrong 'new version'

When the plugin is enabled, it displays that the Current version is 2.3.6 and says the new version is 2.3.2, as seen here

Error on PlayerJoinEvent

Version: Latest as of 6/14/2020
Minecraft Version: 1.15.2-R01-SNAPSHOT

Console Error:
https://pastebin.com/xQTBNDKm