Comments (4)
Thanks for the patch!
Some functors still have mutable ptr
member variables with a single instance that gets overwritten and is returned by value for each invocation (and in some cases the ptr
instance is unused now). That is better than to return by const reference, but not thread-safe if the constructors are invoked concurrently from different threads. I suggest to eliminate all member variables and only return new instances, either a temporary or an instance created as a local variable and returned by value.
from rtt_geometry.
Addressed in b8e97bc
from rtt_geometry.
I added the patch. Sorry I got confused by who was holding the data. Should be good for merge now
from rtt_geometry.
Fixed in #26. Thanks to @ahoarau!
from rtt_geometry.
Related Issues (11)
- Migrate Eigen typekit from itasc to new eigen_typekit package HOT 2
- eigen_typekit and kdl_typekit do not install package.xml HOT 8
- Error loading libkdl-transport-mqueue-gnulinux.so through docker when openGL is enabled HOT 1
- Support accessing eigen_matrix elements in eigen_typekit
- Arm compilation issue HOT 2
- Do not use namespace Eigen and KDL for Orocos types
- Readme HOT 1
- Move this repo to "orocos" organization HOT 1
- Should we separate the ROS-dependent and non-ROS-dependent packages in rtt_geometry? HOT 3
- Should we move kdl_lua into the orocos_kinematics_dynamics repository? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rtt_geometry.