Comments (9)
Which version of the bundle do you use? 1.1.6.0 is the latest version supporting PHP 7.1 and the code looks different there.
from httplugbundle.
I double this: I get incompatibility fatal error.
Relevant composer.json parts:
{
"require": {
"php": ">=7.1",
"symfony/symfony": "^3.4",
"php-http/guzzle6-adapter": "^2.0",
"php-http/httplug-bundle": "^1.18"
}
}
Symfony 3.4.43 with httplug 2.2.0 and httplug-bundle 1.18 installed.
The reason is that \Http\HttplugBundle\Collector\Collector::collect
does not define the last $exception
parameter to be of type ?Exception
Works fine on 1.17.0
from httplugbundle.
Which PHP version do you use when you run into this issue?
from httplugbundle.
I have some problem.
Symfony 3.4
httplug-bundle 1.18
php 7.2
from httplugbundle.
in #387 i make the lowest version test with php 7.2. the test is green with 7.2, so either we are missing a test on that collector or something weird is going on.
we do test the collector: https://github.com/php-http/HttplugBundle/blob/master/tests/Unit/Collector/CollectorTest.php
why does this not fail during the tests?
from httplugbundle.
@lies Are you sure that this is happening on PHP 7.2? Please note that the PHP version used on the command-line may be different from the one used when serving your application over HTTP.
from httplugbundle.
Problem confirmed here.
PHP 7.1.33, but composer config.platform.php is PHP 7.2.5.
Symfony 3.4.5 (problematic file)
HttplugBundle 1.19.0 (problematic file)
I can confirm also that the bug appeared in 1.18.0.
from httplugbundle.
Well, If you are running your application on PHP 7.1, you must not set the platform PHP version to 7.2 as you will get non-compatible dependencies then.
from httplugbundle.
if you hack around with the platform configuration, i recommend you set your requirements, as well as indirect requirements, to exact version numbers that you know work together. (e.g. find in the httplug bundle changelog where we drop support for php 7.1 and pin your requirement to php-http/httplug-bundle to the version that came right before that).
from httplugbundle.
Related Issues (20)
- The httplug.collector.twig.http_message service is deprecated since version 1.17 HOT 5
- Xdebug nested issue HOT 1
- The data collector does not have reset tag HOT 1
- Can't test throwing an exception. Help needed
- 1.22 crash on cache clear in symfony 4.4 HOT 1
- Not allow null value for cache default_ttl HOT 6
- ErrorPlugin cannot be configured HOT 1
- The collector formatter needs to implement Http\Message\Formatter::formatResponseForRequest HOT 1
- [Profiler] No captured body (Symfony Client) HOT 4
- Switch from Http\Client\HttpClient to Psr\Http\Client\ClientInterface HOT 4
- Package php-http/message-factory is abandoned, you should avoid using it. Use psr/http-factory instead HOT 7
- Header authentication service configuration HOT 2
- Support Symfony 7
- Add Factory for NoPrivateNetworkHttpClient HOT 3
- [Symfony 7.1] The `Symfony\Component\HttpKernel\DependencyInjection\Extension` class is considered internal since Symfony 7.1, to be deprecated in 8.1; use `Symfony\Component\DependencyInjection\Extension\Extension` instead HOT 1
- "message":"User Deprecated: Class \"Nyholm\\Psr7\\Factory\\HttplugFactory\" is deprecated since version 1.8, use \"Nyholm\\Psr7\\Factory\\Psr17Factory\" HOT 1
- phpstan: add vcr plugin for stricter checks
- raise minimum php and symfony versions
- increase phpstan level
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httplugbundle.