Comments (4)
oh indeed, we should do that. it would be another line right after https://github.com/php-http/HttplugBundle/blob/1.x/src/Resources/config/services.xml#L50 (and we could mark the alias for HttpClient as deprecated.)
do you want to create a pull request for that?
from httplugbundle.
we want to keep using the adapters to still provide the HttpAsyncClient. the Httplug HttpClient extends the PSR ClientInterface, people should depend on that rather than the deprecated HttpClient interface.
if you find places where we can update the documentation or code to talk about the PSR ClientInterface, glad if you can point them out or even do a pull request to cleanup things.
from httplugbundle.
In that case - is it possible then to create a default alias for the Psr\Http\Client\ClientInterface
$ ./bin/console debug:container|grep httplug.client
Http\Client\HttpClient alias for "httplug.client.default"
Http\Client\HttpClient $default alias for "httplug.client.default"
Psr\Http\Client\ClientInterface $default alias for "httplug.client.default"
httplug.client alias for "httplug.client.default"
httplug.client.default alias for "httplug.client.default"
httplug.client.default Http\Client\Common\PluginClient
httplug.client.default.client Http\Client\HttpClient
httplug.client.default.plugin.base_uri Http\Client\Common\Plugin\BaseUriPlugin
httplug.client.default.plugin.base_uri.base_uri Psr\Http\Message\UriInterface
That's what we have now: it's possible to type hint Http\Client\HttpClient
but Psr\Http\Client\ClientInterface
is not hinteable unless the name is changed to $default
everywhere in the codebase.
from httplugbundle.
I totally will do tomorrow then :-)
from httplugbundle.
Related Issues (20)
- The httplug.collector.twig.http_message service is deprecated since version 1.17 HOT 5
- Collector not compatible with Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface HOT 9
- Xdebug nested issue HOT 1
- The data collector does not have reset tag HOT 1
- Can't test throwing an exception. Help needed
- 1.22 crash on cache clear in symfony 4.4 HOT 1
- Not allow null value for cache default_ttl HOT 6
- ErrorPlugin cannot be configured HOT 1
- The collector formatter needs to implement Http\Message\Formatter::formatResponseForRequest HOT 1
- [Profiler] No captured body (Symfony Client) HOT 4
- Package php-http/message-factory is abandoned, you should avoid using it. Use psr/http-factory instead HOT 7
- Header authentication service configuration HOT 2
- Support Symfony 7
- Add Factory for NoPrivateNetworkHttpClient HOT 3
- [Symfony 7.1] The `Symfony\Component\HttpKernel\DependencyInjection\Extension` class is considered internal since Symfony 7.1, to be deprecated in 8.1; use `Symfony\Component\DependencyInjection\Extension\Extension` instead HOT 1
- "message":"User Deprecated: Class \"Nyholm\\Psr7\\Factory\\HttplugFactory\" is deprecated since version 1.8, use \"Nyholm\\Psr7\\Factory\\Psr17Factory\" HOT 1
- phpstan: add vcr plugin for stricter checks
- raise minimum php and symfony versions
- increase phpstan level
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httplugbundle.